Folder re-org to fit new MCU K22F variances #3136
Conversation
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 945 All builds and test passed! |
This is a simple re-structure of the K22F folder to allow other MCU variances to land here. Created the MCU_K22F512 device but left the 'K22F' as a target for the FRDM-K22F board. Rebased to master
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 951 All builds and test passed! |
|
@mbed-bot: TEST HOST_OSES=ALL |
| @@ -482,11 +482,11 @@ | |||
| "release_versions": ["2"], | |||
| "device_name": "MK20DX256xxx7" | |||
| }, | |||
| "K22F": { | |||
| "MCU_K22F512": { | |||
There was a problem hiding this comment.
This target needs to have the public flag set to false
| @@ -495,6 +495,10 @@ | |||
| "release_versions": ["2", "5"], | |||
There was a problem hiding this comment.
I think we typically only place the release_versions field in the "leaf" target, eg. the target that is the furthest down the inheritance chain. So in this case I would move this to the K22F target definition.
| @@ -482,11 +482,11 @@ | |||
| "release_versions": ["2"], | |||
| "device_name": "MK20DX256xxx7" | |||
| }, | |||
| "K22F": { | |||
| "MCU_K22F512": { | |||
| "supported_form_factors": ["ARDUINO"], | |||
There was a problem hiding this comment.
I'd say this belongs in the K22F target definition, since the shared MCU doesn't really have a form factor.
|
[Build 1070] |
|
New PR #3177 to circumvent repo & fork permissions. Review comments incorporated. |
Description
This is a re-structure of the K22F folder to allow more K22F variances to be plumbed in.
'MCU_K22F512' device has been created and the FRDM-K22F board is using it on this proposal.
Note: the name of the target remains unchanged: 'K22F'.
Another PR will come later to add support for the 'MCU_K22F1M0' variance to support a partner's platform.
Status
READY
Migrations
NO
Related PRs
NA for now
Deploy notes
Not required
Steps to test or reproduce
None. Should not affect the existing 'K22F' target
Please review and share feedback
@0xc0170 @sg- @maclobdell @bridadan