Skip to content

Folder re-org to fit new MCU K22F variances #3136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion targets/TARGET_Freescale/mbed_rtx.h
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
#define OS_CLOCK 96000000
#endif

#elif defined(TARGET_K22F)
#elif defined(TARGET_MCU_K22F)

#ifndef INITIAL_SP
#define INITIAL_SP (0x20010000UL)
Expand Down
10 changes: 7 additions & 3 deletions targets/targets.json
Original file line number Diff line number Diff line change
Expand Up @@ -482,11 +482,11 @@
"release_versions": ["2"],
"device_name": "MK20DX256xxx7"
},
"K22F": {
"MCU_K22F512": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This target needs to have the public flag set to false

"supported_form_factors": ["ARDUINO"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say this belongs in the K22F target definition, since the shared MCU doesn't really have a form factor.

"core": "Cortex-M4F",
"supported_toolchains": ["ARM", "GCC_ARM", "IAR"],
"extra_labels": ["Freescale", "KSDK2_MCUS", "FRDM", "KPSDK_MCUS", "KPSDK_CODE"],
"extra_labels": ["Freescale", "KSDK2_MCUS", "MCU_K22F", "MCU_K22F512", "FRDM", "KPSDK_MCUS", "KPSDK_CODE"],
"is_disk_virtual": true,
"macros": ["CPU_MK22FN512VLH12", "FSL_RTOS_MBED"],
"inherits": ["Target"],
Expand All @@ -495,6 +495,10 @@
"release_versions": ["2", "5"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we typically only place the release_versions field in the "leaf" target, eg. the target that is the furthest down the inheritance chain. So in this case I would move this to the K22F target definition.

"device_name": "MK22DN512xxx5"
},
"K22F": {
"inherits": ["MCU_K22F512"],
"extra_labels_add": ["FRDM"]
},
"KL27Z": {
"inherits": ["Target"],
"core": "Cortex-M0+",
Expand Down Expand Up @@ -2150,4 +2154,4 @@
"inherits": ["SARA_NBIOT"],
"extra_labels": ["ublox", "HI2110", "SARA_NBIOT"]
}
}
}