Skip to content

Coding convention changes #3268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 22, 2016
Merged

Coding convention changes #3268

merged 9 commits into from
Nov 22, 2016

Conversation

mmahadevan108
Copy link
Contributor

Description

Coding convention changes

Status

**READY

@mmahadevan108
K66F: Coding convention fixes
652c81c 
Signed-off-by: Mahadevan Mahesh <[email protected]>
@mmahadevan108
K82F: Coding convention fixes
682df90 
Signed-off-by: Mahadevan Mahesh <[email protected]>
@mmahadevan108
KL27Z: Coding convention fixes
279925e 
Signed-off-by: Mahadevan Mahesh <[email protected]>
@mmahadevan108
KL43Z: Coding convention fixes
31d6bb9 
Signed-off-by: Mahadevan Mahesh <[email protected]>
@mmahadevan108
KL82Z: Coding convention fixes
5356246 
Signed-off-by: Mahadevan Mahesh <[email protected]>
@mmahadevan108
KW24D: Coding convention fixes
26146e8 
Signed-off-by: Mahadevan Mahesh <[email protected]>
@mmahadevan108
K64F: Coding convention fixes
05382af 
Signed-off-by: Mahadevan Mahesh <[email protected]>
@mmahadevan108
K22F: Coding convention fixes
93aca0b 
Signed-off-by: Mahadevan Mahesh <[email protected]>
@mmahadevan108
Kinetis SDK: Coding convention fixes
b78e552 
Signed-off-by: Mahadevan Mahesh <[email protected]>
@mmahadevan108
Copy link
Contributor Author

cc @sg- @0xc0170

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 16, 2016

/morph test-nightly

@bridadan
Copy link
Contributor

We were moving some of the CI machines around and the server cable got bumped, so the nightly job got stopped unfortunately. I will restart it now.

/morph test-nightly

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1110

Test failed!

@mmahadevan108
Copy link
Contributor Author

@bridadan I don't understand the reason for the test failure.

@bridadan
Copy link
Contributor

The test failure seems to be spurious, the event queue took a little longer to service an event than it normally does on one of the boards (NCS36510), though the board shouldn't have been affected by this change set. And I was unable to reproduce the failure locally after performing the same merges that the CI did. So I don't think its necessary to run the nightly again. I'll just run the mbed 2 tests now and then it should be good to come in.

@bridadan
Copy link
Contributor

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@mbed-bot
Copy link

[Build 1122]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@mmahadevan108
Copy link
Contributor Author

Can this be merged in please. Thank you.

@0xc0170 0xc0170 merged commit 905a173 into ARMmbed:master Nov 22, 2016
@mmahadevan108 mmahadevan108 deleted the Coding_Convention_Changes branch November 23, 2016 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmahadevan108 @0xc0170 @bridadan @mbed-bot