I2C fix added, SPI slave fixes added and SPISLAVE enabled

[pradeep-gr]

Notes:

• Pull requests will not be accepted until the submitter has agreed to the contributer agreement.
• This is just a template, so feel free to use/remove the unnecessary things

Description

A few sentences describing the overall goals of the pull request's commits.

Status

READY/IN DEVELOPMENT/HOLD

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

YES | NO

Related PRs

List related PRs against other branches:

branch	PR
other_pr_production	link
other_pr_master	link

Todos

• Tests
• Documentation

Deploy notes

Notes regarding the deployment of this PR. These should note any
required changes in the build environment, tools, compilers, etc.

Steps to test or reproduce

Outline the steps to test or reproduce the PR here.

[pradeep-gr]

@maclobdell
This PR created from new feature branch and committed only I2C & SPI changes. Still I am seeing flash merge commits added to this PR. As I am new to GIT please let me know how to raise separate PR only for I2C and SPI.

[maclobdell]

Hi Pradeep, looks like your branch named "origin" has a base that is on top of your master branch which has the other commits, and the base of your master branch is the one that forks off the ARMmbed master branch. So, basically you want your "origin" branch to fork directly from the ARMmbed master branch, in order to only have the i2c commit in the PR.

[maclobdell]

Hi Pradeep, I just tried the following steps and it seems to accomplish the previous recommendation I made. I pulled the latest updates from github.com/armmbed/mbed-os (also called 'origin' in my case), then checked out the origin/master branch. Created a new branch from that point, gave the branch a new name, then "cherry picked" the commit that makes the i2c fixes onto the new branch. I use Git Extensions tool, but this should be able to be done via git commands or other git tools. I hope this helps.

[pradeep-gr]

@maclobdell
I have created new branch from https://github.com/ARMmbed/mbed-os but not able to push branch to GIT
as i do not have permission.

[bridadan]

Hi @pradeep-gr, you're almost there! You're currently trying to push a branch to the ARMmbed repository for mbed-os, which it is correctly preventing you from doing :)

You need to push it to your "fork" of the mbed-os repo, which I believe you have one here: https://github.com/pradeep-gr/mbed-os5-onsemi. (If you look at the top of the page, you'll see the text "forked from ARMmbed/mbed-os"), which is your clue that this your "fork")

If you run the following commands you should then be able to submit a PR:

cd D:\MBED\GIT_HUB\MBED_OS_BRANCH
git remote add pradeep-gr https://github.com/pradeep-gr/mbed-os5-onsemi
git checkout feature_i2c_spislave
git push pradeep-gr feature_i2c_spislave

At this point GitHub should let you submit the PR! Hope that helps!

[0xc0170]

One small addition to the above:

Always check what are your remotes (I run this command always when I switch repositories, as I have many remotes often)

git remote -v

In this case, it would show that origin is mbed-os repository, not your fork :-)

[pradeep-gr]

@maclobdell @bridadan @0xc0170 Thanks for your help to raise separate PR. I have raised PR for I2C and SPI fixes. #3611.

[bridadan]

@pradeep-gr great, thanks for doing that! I'll close this one and we'll continue the discussion on #3611