[NUC472] Support no-XRAM configuration #3767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need separate linker files for each toolchain ? Can't they be the same and use that extra label to add parts that are needed (I did not make any diff to see what's new in this PR if it's just one region or somethign more). Just wondering if there's copy-paste that we could avoid. |
|
/morph test |
|
@0xc0170 To support XRAM/no-XRAM configurations simultaneously, source code can be easily distinguished by extra label without branch, but linker files cannot in the same way. If mbed build tool supports preprocessing of linker files, it would be OK to have just one linker file for each toolchain. |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
sg-
added
ready for merge
release-version: 5.4.0
and removed
needs: CI
needs: review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for no-XRAM configuration for the NUMAKER_PFM_NUC472 target. This configuration enables evaluation for products that needn't external SRAM which is attached with the NuMaker-PFM-NUC472 board.