Introducing UBLOX_C030 platform. #3992

RobMeades · 2017-03-22T18:23:23Z

This pull request introduces the UBLOX_C030 platform. This is a "maker" development board which includes an STM32F4 processor, a cellular module, a GNSS module, a few other peripheral chips and Arduino pin-out. It is a successor to the C027 platform.

The board port is ready in this submission, integration of cellular and GNSS module interfaces will follow.
ARM, IAR and GCC toolsets are supported and all mbed platform tests pass.

0xc0170 · 2017-03-23T13:34:55Z

ARM, IAR and GCC toolsets are supported and all mbed platform tests pass.

Can you please share test results?

RobMeades · 2017-03-23T14:10:39Z

Here they are for GCC. Do you need them for ARM and IAR as well?

ublox_c030_tests_gcc.txt

adbridge · 2017-03-23T15:33:12Z

/morph test

mbed-bot · 2017-03-23T18:28:53Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1726

All builds and test passed!

0xc0170 · 2017-03-29T12:12:05Z

targets/TARGET_STM/TARGET_STM32F4/TARGET_UBLOX_C030/device/TOOLCHAIN_IAR/stm32f439xx.icf

+define symbol __ICFEDIT_region_BKPSRAM_end__   = 0x40024FFF;
+/*-Sizes-*/
+/*Heap 1/2 of ram and stack 1/8*/
+define symbol __ICFEDIT_size_cstack__ = 0x6000;


If this is for mbed 5 only, isn't this stack size too big (its for ISR stack) ?

Frankly, I just copied the ODIN one as the processor is the same RAM-wise. What size would you suggest for the needs of mbed-os?

Reduced it to 4 kbytes as discussed.

0xc0170 · 2017-03-29T21:13:12Z

/morph test

mbed-bot · 2017-03-30T03:59:24Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1787

All builds and test passed!

adbridge · 2017-03-30T16:25:09Z

retest uvisor

RobMeades · 2017-03-30T22:44:36Z

Have moved TARGET_UBLOX_C030 under an STM32F437xG sub-directory in alignment with @adustm's new structure.

RobMeades · 2017-04-03T08:22:21Z

Is this uVisor build/test fail a real one? Can someone pass me the failure reason?

0xc0170 · 2017-04-03T08:31:08Z

Is this uVisor build/test fail a real one? Can someone pass me the failure reason?

Jenkins error, investigating and restarting jobs here.

0xc0170 · 2017-04-03T08:31:34Z

retest uvisor

bridadan · 2017-04-03T19:35:19Z

/morph test

bridadan · 2017-04-03T19:36:28Z

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

mbed-bot · 2017-04-03T22:47:00Z

[Build 1330]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

mbed-bot · 2017-04-04T02:38:53Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1821

All builds and test passed!

0xc0170 · 2017-04-04T08:49:29Z

Waiting for Jenkins CI to be fixed (some hw related issues currently).

RobMeades · 2017-04-04T15:31:18Z

Found some badly named files, now fixed.

0xc0170 · 2017-04-04T15:37:06Z

/morph test

adustm · 2017-04-04T18:57:06Z

Hello @RobMeades
Thank you for this file structure. It seems fine to me.
Kind ergards
Armelle

mbed-bot · 2017-04-04T19:00:38Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1828

All builds and test passed!

bridadan

Looks really good, though it seems like there's an awful lot of #ifdef checks. I understand they may be necessary though. Would you mind clarifying?

bridadan · 2017-04-04T19:59:51Z

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F437xG/device/stm32f4xx.h

+  #include "stm32f423xx.h"
+#else
+ #error "Please select first the target STM32F4xx device used in your application (in stm32f4xx.h file)"
+#endif


Is it necessary to have all of these #ifdef checks? Can't we streamline this? Or is this done this way to reduce the number of changes between ST provided sources?

‎This is boiler plate STM code, maybe not so necessary with the new directory structure: @adustm your view?

We'll discuss this in ST team. I'll let you know. Best regards

bridadan · 2017-04-04T20:00:42Z

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F437xG/device/stm32f4xx.h

+/* Uncomment the line below according to the target STM32 device used in your
+   application 
+  */
+#if !defined (STM32F405xx) && !defined (STM32F415xx) && !defined (STM32F407xx) && !defined (STM32F417xx) && \


This seems a bit heavy on the #ifdef checks, can this not be simplified? Perhaps removing some of the commented out code?

@bridadan Be aware this is device drivers that come outside of this repository. Good feedback, however should not block this pull request.

bridadan

@bridadan Be aware this is device drivers that come outside of this repository. Good feedback, however should not block this pull request.

Agreed, thanks for following up on this!

Ports for Upcoming Targets 3841: Add nRf52840 target ARMmbed/mbed-os#3841 3992: Introducing UBLOX_C030 platform. ARMmbed/mbed-os#3992 Fixes and Changes 3951: [NUCLEO_F303ZE] Correct ARDUINO pin ARMmbed/mbed-os#3951 4021: Fixing a macro to detect when RTOS was in use for the NRF52840_DK ARMmbed/mbed-os#4021 3979: KW24D: Add missing SPI defines and Arduino connector definitions ARMmbed/mbed-os#3979 3990: UBLOX_C027: construct a ticker-based wait, rather than calling wait_ms(), in the ARMmbed/mbed-os#3990 4003: Fixed OBOE in async serial tx for NRF52 target, fixes #4002 ARMmbed/mbed-os#4003 4012: STM32: Correct I2C master error handling ARMmbed/mbed-os#4012 4020: NUCLEO_L011K4 remove unsupported tool chain files ARMmbed/mbed-os#4020 4065: K66F: Move bss section to m_data_2 Section ARMmbed/mbed-os#4065 4014: Issue 3763: Reduce heap allocation in the GCC linker file ARMmbed/mbed-os#4014 4030: [STM32L0] reduce IAR heap and stack size for small targets ARMmbed/mbed-os#4030 4109: NUCLEO_L476RG : minor serial pin update ARMmbed/mbed-os#4109 3982: Ticker - kl25z bugfix for handling events in the past ARMmbed/mbed-os#3982

RobMeades force-pushed the c030-dev branch from 40e0b76 to 9f2aeb9 Compare March 23, 2017 13:34

adbridge added the needs: review label Mar 23, 2017

0xc0170 reviewed Mar 29, 2017

View reviewed changes

RobMeades force-pushed the c030-dev branch from 9f2aeb9 to f16e71f Compare March 29, 2017 18:22

0xc0170 added needs: CI and removed needs: review labels Mar 29, 2017

RobMeades force-pushed the c030-dev branch from f16e71f to 70e5967 Compare March 30, 2017 22:42

0xc0170 approved these changes Apr 4, 2017

View reviewed changes

Introducing UBLOX_C030 platform.

7387c09

RobMeades force-pushed the c030-dev branch from 70e5967 to 7387c09 Compare April 4, 2017 15:23

bridadan reviewed Apr 4, 2017

View reviewed changes

0xc0170 added ready for merge and removed needs: CI labels Apr 6, 2017

bridadan approved these changes Apr 6, 2017

View reviewed changes

sg- added release-version: 5.4.3 scope: new-target and removed ready for merge labels Apr 6, 2017

sg- merged commit 7a35a4d into ARMmbed:master Apr 6, 2017

Introducing UBLOX_C030 platform. #3992

Introducing UBLOX_C030 platform. #3992

Uh oh!

Conversation

RobMeades commented Mar 22, 2017

Uh oh!

0xc0170 commented Mar 23, 2017

Uh oh!

RobMeades commented Mar 23, 2017

Uh oh!

adbridge commented Mar 23, 2017

Uh oh!

mbed-bot commented Mar 23, 2017

Output

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Mar 29, 2017

Uh oh!

mbed-bot commented Mar 30, 2017

Output

Uh oh!

adbridge commented Mar 30, 2017

Uh oh!

RobMeades commented Mar 30, 2017

Uh oh!

RobMeades commented Apr 3, 2017

Uh oh!

0xc0170 commented Apr 3, 2017

Uh oh!

0xc0170 commented Apr 3, 2017

Uh oh!

bridadan commented Apr 3, 2017

Uh oh!

bridadan commented Apr 3, 2017

Uh oh!

mbed-bot commented Apr 3, 2017

Uh oh!

mbed-bot commented Apr 4, 2017

Output

Uh oh!

0xc0170 commented Apr 4, 2017

Uh oh!

RobMeades commented Apr 4, 2017

Uh oh!

0xc0170 commented Apr 4, 2017

Uh oh!

adustm commented Apr 4, 2017

Uh oh!

mbed-bot commented Apr 4, 2017

Output

Uh oh!

bridadan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bridadan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!