Skip to content

Move target related code into it's own directory #3995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2017

Conversation

theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Mar 22, 2017

This should make it easier to navigate the code base, and reduces
technical debt.

Testing

  • /morph test : to verify that I did not break post-bulid scripts

This should make it easier to navigate the code base
@theotherjimmy
Copy link
Contributor Author

/morph test

@theotherjimmy
Copy link
Contributor Author

theotherjimmy commented Mar 22, 2017

@0xc0170 After this is merged, we should push partners to put there target code here. I moved all of it that's currently in the tools. I just want new target code to go here too.

@theotherjimmy
Copy link
Contributor Author

@c1728p9 Part of the technical debt I was talking about earlier.

@theotherjimmy
Copy link
Contributor Author

@bridadan Any more tests to run?

@theotherjimmy
Copy link
Contributor Author

theotherjimmy commented Mar 22, 2017

@screamerbg Could we mention the owners of the moved target code in this PR to get their input on the move? in particular this PR affects the location of LPC and NCS target-specific files.

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1720

All builds and test passed!

@bulislaw
Copy link
Member

Looks good, thanks for notifying Realtek.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 23, 2017

@0xc0170 After this is merged, we should push partners to put there target code here. I moved all of it that's currently in the tools. I just want new target code to go here too.

+1, will do

Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving the changes! We should run the mbed 2 bot too just to double check

@bridadan
Copy link
Contributor

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@screamerbg
Copy link
Contributor

Like it! LGTM

@mbed-bot
Copy link

[Build 1314]
FAILURE: Something went wrong when building and testing.

@bridadan
Copy link
Contributor

This is failing due to the issue I mention here: #4021 (comment)

We'll need help from Nordic to fix the issue, stay tuned over on #4021

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 29, 2017

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@mbed-bot
Copy link

[Build 1325]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@sg- sg- merged commit 8784913 into ARMmbed:master Mar 29, 2017
@theotherjimmy theotherjimmy deleted the targets-refactor branch March 29, 2017 21:26
Archcady added a commit to Archcady/mbed-os that referenced this pull request Mar 31, 2017
Archcady added a commit to Archcady/mbed-os that referenced this pull request Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants