Move contents of project_api to export/__init__.py #3997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file `project_api.py` was poorly named and caused much confusion. Given that it was actually a front end to the exporters, I put it into the export sub-dir.
theotherjimmy
force-pushed
the
remove-project-api
branch
from
15be4fc to
70ac607
Compare
|
/morph export-build |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 139 All exports and builds passed! |
|
yeah! good to go. |
|
Gonna run the basic test too just to make sure we don't gunk up the other PRs. /morph test |
|
Sounds good. |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
huh. That's strange. |
|
It's a timing test bug caused by CI machine load. We should really look at this again @c1728p9 @studavekar /morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
0xc0170
approved these changes
Mar 28, 2017
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file
project_api.pywas poorly named and caused much confusion.Given that it was actually a front end to the exporters, I put it into
the export sub-dir.
Testing