Fix a small bug in subtract_basepath #4013
Conversation
|
/morph export-build |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 140 Exporter Build failed! |
|
This is failing due to the issue I mention here: #4021 (comment) We'll need help from Nordic to fix the issue, stay tuned over on #4021 |
|
/morph export-build |
theotherjimmy
force-pushed
the
fix-subtract-basepath
branch
from
79a1c71 to
7a95781
Compare
|
rebased to resolve merge conflict after #3997 was merged. |
|
/morph export-build |
Result: FAILUREYour command has finished executing! Here's what you wrote!
|
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 149 All exports and builds passed! |
|
retest uvisor |
|
retest uvisor |
It was causing tracebacks on the website
theotherjimmy
force-pushed
the
fix-subtract-basepath
branch
from
7a95781 to
20edbe3
Compare
|
/morph export-build |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 151 All exports and builds passed! |
|
This patch appears to be reliant on #3997 which is marked for 5.5, thus relabeling this one accordingly. |
It was causing tracebacks on the website. The make_key function of the
export object would use the basepath of every file and would not prefix
it with the export path. I don't know why we added the prefix in the
first place, so I removed it. Further, using any path other than "."
would result in ".." being the only group. that's definitely strange
behavior, but easy to work around: just pass in "."
TESTS