Error when bootloader is specified but does not exist #4136

theotherjimmy · 2017-04-07T16:33:09Z

Descritpion

This patch changes the behavior when a bootloader is specified, but not
present. It is now considered a Bad Config™.

How to reproduce

Take the mbed-os-example-bootloader-blinky example and delete the
bootloader directory. You will now see a ~~nice~~awful IOError.

New behavior

Do the steps to reproduce, but with this branch as mbed-os. The error
message that you will get it a ConfigException:
"Bootloader not found".

TODO

Write unit test that tests this behavior
Ensure that the unit test runs as part of Travis CI

theotherjimmy · 2017-04-07T16:49:26Z

@MaggieMei You caused this error on the online compiler about 10 hours ago, FYI.

@0xc0170 Could you continue to be a great gatekeeper?

@c1728p9 I said I would do it. Now look at what I've done. 😈

0xc0170 · 2017-04-10T09:05:22Z

tools/config.py

@@ -502,6 +502,8 @@ def regions(self):
                                  "build a bootloader project")
        if 'target.bootloader_img' in target_overrides:
            filename = target_overrides['target.bootloader_img']
+            if not exists(filename):
+                raise ConfigException("Bootoalder %s not found" % filename)


Typo: Bootloader. Once fixed, please run tests

lol. Let me fix that.

I also made a typo in the branch name.

theotherjimmy · 2017-04-10T16:54:16Z

@0xc0170 I fixed the typo. Thanks for the review!

0xc0170 · 2017-04-12T09:47:00Z

/morph test-nightly

mbed-bot · 2017-04-12T16:49:01Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1895

Example Build failed!

bridadan · 2017-04-18T15:02:56Z

/morph test-nightly

mbed-bot · 2017-04-19T01:30:44Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 27

Test failed!

sg- · 2017-04-19T05:13:25Z

@studavekar @bridadan

[1492557014.19][CONN][INF] found KV pair in stream: {{max_heap_usage;3984}}, queued...
[1492557014.20][HTST][ERR] orphan event in main phase: {{max_heap_usage;3984}}, timestamp=1492557014.195000
[1492557014.26][CONN][INF] found KV pair in stream: {{__thread_info;"0x00000d869-0x000000000",112,800}}, queued...
[1492557014.26][HTST][ERR] orphan event in main phase: {{__thread_info;"0x00000d869-0x000000000",112,800}}, timestamp=1492557014.259000
[1492557014.31][CONN][INF] found KV pair in stream: {{__thread_info;"0x00000cd7d-0x000000000",1428,4096}}, queued...
[1492557014.31][HTST][ERR] orphan event in main phase: {{__thread_info;"0x00000cd7d-0x000000000",1428,4096}}, timestamp=1492557014.311000
[1492557014.36][CONN][INF] found KV pair in stream: {{__thread_info;"0x000003d45-0x000000000",592,1200}}, queued...
[1492557014.38][HTST][ERR] orphan event in main phase: {{__thread_info;"0x000003d45-0x000000000",592,1200}}, timestamp=1492557014.364000
[1492557014.42][CONN][INF] found KV pair in stream: {{__thread_info;"0x0000024b5-0x020000cdc",160,512}}, queued...
[1492557014.43][HTST][ERR] orphan event in main phase: {{__thread_info;"0x0000024b5-0x020000cdc",160,512}}, timestamp=1492557014.418000
[1492557014.48][CONN][INF] found KV pair in stream: {{__thread_info;"0x0000022a1-0x020000cdc",120,512}}, queued...
[1492557014.49][HTST][ERR] orphan event in main phase: {{__thread_info;"0x0000022a1-0x020000cdc",120,512}}, timestamp=1492557014.481000
[1492557014.53][CONN][INF] found KV pair in stream: {{__thread_info;"0x000002219-0x0200014d8",128,512}}, queued...
[1492557014.54][HTST][ERR] orphan event in main phase: {{__thread_info;"0x000002219-0x0200014d8",128,512}}, timestamp=1492557014.533000
[1492557014.59][CONN][INF] found KV pair in stream: {{__thread_info;"0x00000cdc5-0x000000000",72,512}}, queued...
[1492557014.59][HTST][ERR] orphan event in main phase: {{__thread_info;"0x00000cdc5-0x000000000",72,512}}, timestamp=1492557014.587000
[1492557014.61][CONN][INF] found KV pair in stream: {{end;failure}}, queued...
[1492557014.61][HTST][INF] __notify_complete(False)
[1492557014.62][CONN][INF] found KV pair in stream: {{__exit;0}}, queued...
[1492557014.62][HTST][INF] __exit(0)
[1492557014.63][HTST][INF] __exit_event_queue received
[1492557014.63][HTST][INF] test suite run finished after 14.07 sec...
[1492557014.63][CONN][INF] received special even '__host_test_finished' value='True', finishing
[1492557014.67][HTST][INF] CONN exited with code: 0
[1492557014.67][HTST][INF] No events in queue
[1492557014.67][HTST][INF] stopped consuming events
[1492557014.67][HTST][INF] host test result() call skipped, received: False
[1492557014.67][HTST][INF] calling blocking teardown()
[1492557014.73][HTST][INF] teardown() finished
[1492557014.73][HTST][INF] {{result;failure}}

studavekar · 2017-04-19T07:38:07Z

looks like more than 1/4 of echo packets received didn't match the size

[1492557005.42][CONN][RXD] [00] sent...256 Bytes
[1492557005.94][CONN][RXD] [00] recv...-3001 Bytes
[1492557005.97][CONN][RXD] [01] sent...256 Bytes
[1492557006.49][CONN][RXD] [01] recv...-3001 Bytes

failure was asserted TEST_ASSERT(success > 3*ECHO_LOOPS/4);

0xc0170 · 2017-04-19T10:44:51Z

looks like more than 1/4 of echo packets received didn't match the size

Seems like random issue, and not not related to this changeset.

cc @geky

geky · 2017-04-19T15:55:12Z

The Austin site actually had internal networking issues last night, we suspect that was responsible for these test failures.
/morph test-nightly

mbed-bot · 2017-04-20T00:25:14Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 39

All builds and test passed!

adbridge · 2017-04-20T14:59:05Z

@theotherjimmy Presumably this still needs the test adding before this should be merged?

theotherjimmy · 2017-04-20T16:06:02Z

@adbridge Yup. I'm going to rebase first.

The changes to build_api.py make the error happen when running things like get_config.py

theotherjimmy · 2017-04-20T16:26:28Z

@adbridge I added the unit test. I need to refactor the testing frameworks to use one system.

adbridge · 2017-04-20T16:35:05Z

@theotherjimmy Is this unit test now being automatically run in the ci ?

theotherjimmy · 2017-04-20T16:35:47Z

That's the next check. I'm going to look a travis in a minute or two.

theotherjimmy · 2017-04-20T16:37:56Z

sigh we're waiting in queue

theotherjimmy · 2017-04-20T18:47:47Z

I saw the test run.

theotherjimmy · 2017-04-20T19:32:52Z

I named the test wrong. Re-pushed the commit with a better name

0xc0170 · 2017-04-21T12:07:29Z

/morph test-nightly

theotherjimmy · 2017-04-21T15:22:50Z

It still ran.

mbed-bot · 2017-04-21T16:29:43Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 60

Test failed!

0xc0170 · 2017-04-24T09:29:05Z

/morph test-nightly

mbed-bot · 2017-04-24T19:26:51Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 75

Test failed!

0xc0170 · 2017-04-25T09:25:42Z

Interesting, havent yet seen this one, odin fails for tests-mbedtls-selftest ? Not the same as previosly, I'll rerun.

/morph test-nightly

bridadan · 2017-04-25T14:05:30Z

@0xc0170 I remember seeing this once long ago. The device is reporting the failure, so it's definitely legit (not an infrastructure issue). May be worth mentioning to ublox?

0xc0170 · 2017-04-25T14:07:28Z

cc @andreaslarssonublox - please have a look at #4136 (comment) (the failure for odin there)

mbed-bot · 2017-04-25T19:35:05Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 83

All builds and test passed!

andreaslarssonublox · 2017-04-26T08:34:03Z

@0xc0170 Thanks for the info. We will look at it.
u-blox ref: TE_OM2-46

…lwip_broadcast Release mbed OS 5.4.5 and mbed lib v142 Ports for Upcoming Targets Fixes and Changes 4059: [Silicon Labs] Rename targets ARMmbed#4059 4115: Support for Qt Creator Generic project export and associated Makefile ARMmbed#4115 3915: Feature vscode ARMmbed#3915 4205: tests: race test - add not supported for single threaded env ARMmbed#4205 4187: [NCS36510] Reduce default heap size allocated by IAR to 1/4 of RAM ARMmbed#4187 4145: test - add nanostack to examples.json file ARMmbed#4145 4093: Update.py: New feature - update a branch instead of a fork, plus general improvements. ARMmbed#4093 4225: fixed missing device_name for xDot and removed progen ARMmbed#4225 4243: Config: config header file should contain new line ARMmbed#4243 4251: Fix C++11 build error w/ u-blox EVK-ODIN-W2 ARMmbed#4251 4236: STM32 Fixed warning related to __packed redefinition ARMmbed#4236 4224: Add `mbed new .` output to export ARMmbed#4224 4190: LPC4088: Enable LWIP feature ARMmbed#4190 4136: Error when bootloader is specified but does not exist ARMmbed#4136 3881: Remove debug links to printf/exit in NDEBUG builds ARMmbed#3881 4260: Inherit Xadow M0 target from LPC11U35_501 ARMmbed#4260 4249: Add consistent button names across targets ARMmbed#4249 4254: Removed unused variable in TARGET_NXP/lpc17_emac.c ARMmbed#4254

0xc0170 approved these changes Apr 10, 2017

View reviewed changes

0xc0170 requested changes Apr 10, 2017

View reviewed changes

0xc0170 added the needs: work label Apr 10, 2017

theotherjimmy force-pushed the bootlader-exists branch from 55e204e to 2117122 Compare April 10, 2017 16:54

0xc0170 approved these changes Apr 12, 2017

View reviewed changes

0xc0170 removed the needs: work label Apr 12, 2017

0xc0170 added the needs: CI label Apr 12, 2017

0xc0170 added ready for merge and removed needs: CI labels Apr 20, 2017

adbridge added needs: work and removed ready for merge labels Apr 20, 2017

theotherjimmy force-pushed the bootlader-exists branch from 2117122 to 760480d Compare April 20, 2017 16:06

Error when bootloader is specified but does not exist

2a84ddd

The changes to build_api.py make the error happen when running things like get_config.py

theotherjimmy force-pushed the bootlader-exists branch from 760480d to 3ffc1fb Compare April 20, 2017 16:25

theotherjimmy added needs: CI and removed needs: work labels Apr 20, 2017

theotherjimmy force-pushed the bootlader-exists branch from 3ffc1fb to 8ced133 Compare April 20, 2017 19:31

Add a config test to check for failing bootloader images

8048ec3

theotherjimmy force-pushed the bootlader-exists branch from 8ced133 to 8048ec3 Compare April 20, 2017 19:32

0xc0170 added ready for merge and removed needs: CI labels Apr 26, 2017

theotherjimmy merged commit 7f0ed3b into ARMmbed:master May 2, 2017

theotherjimmy added release-version: 5.4.5 and removed ready for merge labels May 2, 2017

Error when bootloader is specified but does not exist #4136

Error when bootloader is specified but does not exist #4136

Uh oh!

Conversation

theotherjimmy commented Apr 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Descritpion

How to reproduce

New behavior

TODO

Uh oh!

theotherjimmy commented Apr 7, 2017

Uh oh!

0xc0170 Apr 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theotherjimmy commented Apr 10, 2017

Uh oh!

0xc0170 commented Apr 12, 2017

Uh oh!

mbed-bot commented Apr 12, 2017

Output

Uh oh!

bridadan commented Apr 18, 2017

Uh oh!

mbed-bot commented Apr 19, 2017

Output

Uh oh!

sg- commented Apr 19, 2017

Uh oh!

studavekar commented Apr 19, 2017

Uh oh!

0xc0170 commented Apr 19, 2017

Uh oh!

geky commented Apr 19, 2017

Uh oh!

mbed-bot commented Apr 20, 2017

Output

Uh oh!

adbridge commented Apr 20, 2017

Uh oh!

theotherjimmy commented Apr 20, 2017

Uh oh!

theotherjimmy commented Apr 20, 2017

Uh oh!

adbridge commented Apr 20, 2017

Uh oh!

theotherjimmy commented Apr 20, 2017

Uh oh!

theotherjimmy commented Apr 20, 2017

Uh oh!

theotherjimmy commented Apr 20, 2017

Uh oh!

theotherjimmy commented Apr 20, 2017

Uh oh!

0xc0170 commented Apr 21, 2017

Uh oh!

theotherjimmy commented Apr 21, 2017

Uh oh!

mbed-bot commented Apr 21, 2017

Output

Uh oh!

0xc0170 commented Apr 24, 2017

Uh oh!

mbed-bot commented Apr 24, 2017

Output

Uh oh!

0xc0170 commented Apr 25, 2017

Uh oh!

bridadan commented Apr 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Apr 25, 2017

Uh oh!

mbed-bot commented Apr 25, 2017

theotherjimmy commented Apr 7, 2017 •

edited

Loading

0xc0170 Apr 10, 2017 •

edited

Loading

bridadan commented Apr 25, 2017 •

edited

Loading

andreaslarssonublox commented Apr 26, 2017 •

edited

Loading