Skip to content

Config: config header file should contain new line #4243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2017

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Apr 28, 2017

Tested with ARM

Before this patch

Compile [  5.3%]: analogout_api.c
[Warning] mbed_config.h@30,0:  #1-D: last line of file ends without a newline
Compile [ 10.5%]: analogin_api.c
[Warning] mbed_config.h@30,0:  #1-D: last line of file ends without a newline
Compile [ 15.8%]: startup_LPC17xx.S
[Warning] mbed_config.h@30,0:  #1-D: last line of file ends without a newline
Compile [ 21.1%]: can_api.c
[Warning] mbed_config.h@30,0:  #1-D: last line of file ends without a newline

After this patch:

Compile [  2.2%]: AnalogIn.cpp
Compile [  4.4%]: BusIn.cpp
Compile [  6.7%]: BusOut.cpp
Compile [  8.9%]: BusInOut.cpp
Compile [ 11.1%]: FlashIAP.cpp
Compile [ 13.3%]: Ethernet.cpp
Compile [ 15.6%]: I2C.cpp
Compile [ 17.8%]: CAN.cpp
Compile [ 20.0%]: I2CSlave.cpp
Compile [ 22.2%]: InterruptIn.cpp
Compile [ 24.4%]: SPI.cpp

We shall be careful with warnings (not adding more to the codebase that we already have :-) )

@theotherjimmy

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K

@theotherjimmy
Copy link
Contributor

Let's do this then.

@theotherjimmy
Copy link
Contributor

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 109

All builds and test passed!

@theotherjimmy
Copy link
Contributor

wooooooop

@theotherjimmy theotherjimmy merged commit f2a648d into ARMmbed:master Apr 28, 2017
@0xc0170 0xc0170 deleted the fix_configtmpl_line branch April 29, 2017 10:33
exmachina-auto-deployer pushed a commit to exmachina-dev/mbed-os that referenced this pull request May 16, 2017
…lwip_broadcast

Release mbed OS 5.4.5 and mbed lib v142

Ports for Upcoming Targets

Fixes and Changes

4059: [Silicon Labs] Rename targets ARMmbed#4059
4115: Support for Qt Creator Generic project export and associated Makefile ARMmbed#4115
3915: Feature vscode ARMmbed#3915
4205: tests: race test - add not supported for single threaded env ARMmbed#4205
4187: [NCS36510] Reduce default heap size allocated by IAR to 1/4 of RAM ARMmbed#4187
4145: test - add nanostack to examples.json file ARMmbed#4145
4093: Update.py: New feature - update a branch instead of a fork, plus general improvements. ARMmbed#4093
4225: fixed missing device_name for xDot and removed progen ARMmbed#4225
4243: Config: config header file should contain new line ARMmbed#4243
4251: Fix C++11 build error w/ u-blox EVK-ODIN-W2 ARMmbed#4251
4236: STM32 Fixed warning related to __packed redefinition ARMmbed#4236
4224: Add `mbed new .` output to export ARMmbed#4224
4190: LPC4088: Enable LWIP feature ARMmbed#4190
4136: Error when bootloader is specified but does not exist ARMmbed#4136
3881: Remove debug links to printf/exit in NDEBUG builds ARMmbed#3881
4260: Inherit Xadow M0 target from LPC11U35_501 ARMmbed#4260
4249: Add consistent button names across targets ARMmbed#4249
4254: Removed unused variable in TARGET_NXP/lpc17_emac.c ARMmbed#4254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants