Modified the TARGET_GHI_MBUINO/PeripheralNames.h and targets/hal/TARGET_... #422
Conversation
…ET_NXP/TARGET_LPC11UXX/TARGET_GHI_MBUINO/PinNames.h to reflect the mBuino base hardware; I commented out the non useful SPI pins and Serial pins from our hardware build; For pwmout, I removed the non useful pins and added two more pins that are part of our hardware build.
|
The changes to pwmout_api.c serial_api.c and spi_api.c aren't go to work as You need to remove all pin to peripheral definitions from the xxx_api.c -s On Wed, Jul 30, 2014 at 12:58 PM, Aron L. Phillips <[email protected]
|
…hal/TARGET_NXP/TARGET_LPC11UXX/TARGET_GHI_MBUINO/PinNames.h to reflect the mBuino base hardware;" This reverts commit 6b910f2.
…ogin, i2c, pwmout, serial, & spi) to follow an example from Erik O. from this platform: https://github.com/mbedmicro/mbed/blob/master/libraries/mbed/targets/hal/TARGET_Freescale/TARGET_KLXX/TARGET_KL46Z/PeripheralPins.c to allow for advanced compatibility of platforms; Subsequently, the Peripheral Pin Definitions were added to the file called PeripheralPins.c to accommodate the removal of the definitions from the main xxx_api.c files and added it to each respective Target folder; Added PeripheralPin.h to point to the PeripheralPin.c files in the target directories.
|
I made the changes as recommended and modified all of the target platforms to accommodate the changes. It will be in another pull request. Without the changes made to the other platforms, the other six would have been broken too. |
…commodate for the specific chip that the mBuino platform uses LPC11U24FHI33/301 which is 6kB in the SRAM vs 8kB;
Added ('GHI_MBUINO', ('ARM', 'uARM', 'GCC_ARM')), to the OFFICIAL_MBED_LIBRARY_BUILD section of build_release.py.
|
I worked with Sam Grove to make sure that all of the changes had been correct. I am awaiting final approval. |
|
Hello, can you remove the commented PinMap definitions from HAL files? Can you please sign the mbed contributor agreement at https://mbed.org/contributor_agreement ? Regards, |
Removed the pin definition comments from the xxx_api.c files; Added GHI_MBUINO to the build_travis.py target section.
|
PinMap definition comments have been removed and the build_travis.py file was updated with the GHI_MBUINO target. |
|
thanks, have you signed the mbed contributor agreement? What's your nick on mbed.org? |
|
Greetings Martin, Yes, I did agree to the contributor's agreement. My nickname is Experiment626 on mbed.org and Experiment-626 on github. Sincerely, Aron Sent via the Samsung GALAXY S® 5, an AT&T 4G LTE smartphone -------- Original message -------- thanks, have you signed the mbed contributor agreement? What's your nick on mbed.org? — |
[TARGET_LPC11UXX] PeripheralNames.h and PinMap definitions separation for LPC11UXX platforms
...NXP/TARGET_LPC11UXX/TARGET_GHI_MBUINO/PinNames.h to reflect the mBuino base hardware;
I commented out the non useful SPI pins and Serial pins from our hardware build;
For pwmout, I removed the non useful pins and added two more pins that are part of our hardware build.
As this is my first time making a platform, I am unsure if the changes I made are proper. Please advise to any errors I may have made.