Skip to content

DISCO_L072CZ_LRWAN1: add a new platform #4256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 8, 2017

Conversation

arostm
Copy link
Contributor

@arostm arostm commented May 2, 2017

Description

This PR add this new board

Status

READY

Migrations

NO

CC @bcostm @adustm

@arostm arostm closed this May 2, 2017
@arostm arostm reopened this May 2, 2017
@arostm arostm changed the title DISCO_L072CZ_ DISCO_L072CZ_LRWAN1: add a new platform May 2, 2017
Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"STM", "STM32L0", "STM32L072CZ", "STM32L072xx"
All look like they should be in the hierarchy, not added as extra labels. This is a thought, If you can change it in this PR, I would welcome it, but it's not necicary

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not add extra junk to the tools please.

@@ -0,0 +1,397 @@
<html>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry these are mbed os2 test results.
I deleted the files

@@ -0,0 +1,397 @@
<html>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry these are mbed os2 test results.
I deleted the files

@@ -0,0 +1,213 @@
/* mbed Microcontroller Library
*******************************************************************************
* Copyright (c) 2016, STMicroelectronics
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2017 please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, i made the date change

@bcostm
Copy link
Contributor

bcostm commented May 3, 2017

LGTM

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better. Thanks.

@theotherjimmy
Copy link
Contributor

/morph test

1 similar comment
@bridadan
Copy link
Contributor

bridadan commented May 3, 2017

/morph test

@mbed-bot
Copy link

mbed-bot commented May 3, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 143

All builds and test passed!

'NUCLEO_L152RE': {'name': 'NUCLEO-L152RE', 'mcuId': 'STM32L152RETx'},
'NUCLEO_L432KC': {'name': 'NUCLEO-L432KC', 'mcuId': 'STM32L432KCUx'},
'NUCLEO_L476RG': {'name': 'NUCLEO-L476RG', 'mcuId': 'STM32L476RGTx'},
'B96B_F446VE': {'name': 'B96B-F446VE', 'mcuId': 'STM32F446VETx'},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that line ending has changed or something, but the whole file is modified. Can you please look at this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added this line : 'DISCO_L072CZ_LRWAN1': {'name': 'DISCO-L072CZ-LRWAN1', 'mcuId': 'STM32L072CZTx'}, and for the other lines, i shifted the other lines so that the 'name' are aligned

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're going to play with the style, could you make sure that the lines are no longer than 80 characters?

@theotherjimmy
Copy link
Contributor

/morph export-build

@adbridge
Copy link
Contributor

adbridge commented May 4, 2017

Oulu CI failed with:
Open TMI schema validation failed?
@tommikas ?

@mbed-bot
Copy link

mbed-bot commented May 4, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 24

All exports and builds passed!

@tommikas
Copy link
Contributor

tommikas commented May 5, 2017

@adbridge That's unrelated and doesn't cause builds to fail. I retriggered the build and it now passed.

I think what happened in this case was that a build caused certain test HW to get allocated and not properly released. Before the allocation timed out this build tried to allocate them and failed. The build causing the problem has now been fixed.

{"target": "DISCO_L072CZ_LRWAN1",
"toolchains": "GCC_ARM",
"tests": {"" : ["MBED_2", "MBED_10", "MBED_11", "MBED_16"],
"rtos" : ["RTOS_1", "RTOS_2", "RTOS_3"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: as preparation for upcoming RTX update, these rtos tests from these scripts will be removed (tests will be in the codebase but executed via mbed cli).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.