-
Notifications
You must be signed in to change notification settings - Fork 3k
DISCO_L072CZ_LRWAN1: add a new platform #4256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"STM", "STM32L0", "STM32L072CZ", "STM32L072xx"
All look like they should be in the hierarchy, not added as extra labels. This is a thought, If you can change it in this PR, I would welcome it, but it's not necicary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not add extra junk to the tools please.
tools/DISCO_L072CZ_LRWAN1.html
Outdated
@@ -0,0 +1,397 @@ | |||
<html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry these are mbed os2 test results.
I deleted the files
tools/NUCLEO_L073RZ.html
Outdated
@@ -0,0 +1,397 @@ | |||
<html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry these are mbed os2 test results.
I deleted the files
@@ -0,0 +1,213 @@ | |||
/* mbed Microcontroller Library | |||
******************************************************************************* | |||
* Copyright (c) 2016, STMicroelectronics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2017 please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, i made the date change
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better. Thanks.
/morph test |
1 similar comment
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
'NUCLEO_L152RE': {'name': 'NUCLEO-L152RE', 'mcuId': 'STM32L152RETx'}, | ||
'NUCLEO_L432KC': {'name': 'NUCLEO-L432KC', 'mcuId': 'STM32L432KCUx'}, | ||
'NUCLEO_L476RG': {'name': 'NUCLEO-L476RG', 'mcuId': 'STM32L476RGTx'}, | ||
'B96B_F446VE': {'name': 'B96B-F446VE', 'mcuId': 'STM32F446VETx'}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that line ending has changed or something, but the whole file is modified. Can you please look at this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added this line : 'DISCO_L072CZ_LRWAN1': {'name': 'DISCO-L072CZ-LRWAN1', 'mcuId': 'STM32L072CZTx'}, and for the other lines, i shifted the other lines so that the 'name' are aligned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're going to play with the style, could you make sure that the lines are no longer than 80 characters?
/morph export-build |
Oulu CI failed with: |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 24 All exports and builds passed! |
@adbridge That's unrelated and doesn't cause builds to fail. I retriggered the build and it now passed. I think what happened in this case was that a build caused certain test HW to get allocated and not properly released. Before the allocation timed out this build tried to allocate them and failed. The build causing the problem has now been fixed. |
{"target": "DISCO_L072CZ_LRWAN1", | ||
"toolchains": "GCC_ARM", | ||
"tests": {"" : ["MBED_2", "MBED_10", "MBED_11", "MBED_16"], | ||
"rtos" : ["RTOS_1", "RTOS_2", "RTOS_3"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: as preparation for upcoming RTX update, these rtos tests from these scripts will be removed (tests will be in the codebase but executed via mbed cli).
Description
This PR add this new board
Status
READY
Migrations
NO
CC @bcostm @adustm