Skip to content

Release candidate for mbed-os-5.4.6 #4356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 72 commits into from
May 25, 2017
Merged

Release candidate for mbed-os-5.4.6 #4356

merged 72 commits into from
May 25, 2017

Conversation

adbridge
Copy link
Contributor

No description provided.

bulislaw and others added 30 commits May 21, 2017 14:35
emac settings are only available after powered up.

Signed-off-by: Tony Wu <[email protected]>
mbed_lwip_set_mac_address calls mbed_mac_address to get hwaddr
from device, but device may not be accessible until it is powered
up and initialized.

This patch delays mbed_lwip_set_mac_address call until device is
ready.

Signed-off-by: Tony Wu <[email protected]>
The USB ISTR register consists of a mix of bits that are
write-zero-to-clear and read only bits.  As such, to clear a bit in
the ISTR, you should simply write the bitwise-NOT of the bit to clear.
Previously, the __HAL_PCD_CLEAR_FLAG() macro would do a bitwise-AND
with the ISTR register contents to clear a bit, but this could result
in another bit being inadvertently cleared if it is set by hardware
between the read and the write of the ISTR register.

Similarly, the USB endpoint registers have two bits that are
write-zero-to-clear, USB_EP_CTR_RX and USB_EP_CTR_TX, but the
PCD_CLEAR_RX_EP_CTR() and PCD_CLEAR_TX_EP_CTR() macros wrote back the
last read value for one of these bits when clearing the other bit.
This could result in inadvertent clearing of one of these bits if it
were set by the hardware between the read and the write.  These macros
have now both been adjusted to always write one to the bit not being
cleared to prevent inadvertent clears.
use Intelhex::write_hex_file instead of IntelHex::tofile
Change the irq_handler parameter of NVIC_SetVector from a function
pointer to a uin32_t so it matches the cmsis specification. This
prevents the following problem from occurring in RTX5 when building
for IAR:
The error: Error[Pe167]: argument of type "void (*)(void)" is incompatible
with parameter of type "uint32_t".
…he code for mbed ci shield test -> analogin_api.c, W7500x_adc.c, gpio_irq_api.c, W7500x_gpio.c Modifying the code for fix bug -> W7500x_uart.c(register control driver problem), W7500x_uart.h, pinmap.c(pullup, pulldown problem)
@adbridge
Copy link
Contributor Author

/morph test-nightly

@adbridge
Copy link
Contributor Author

/morph mbed2-release

@adbridge
Copy link
Contributor Author

/morph export-build

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 292

Example Prep failed!

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 36

Exporter Build failed!

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph mbed2-release

@adbridge
Copy link
Contributor Author

/morph test-nightly

@adbridge
Copy link
Contributor Author

/morph export-build

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 37

Exporter Build failed!

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 295

Example Build failed!

@adbridge
Copy link
Contributor Author

Still problems with exporters!
NRF51_DK and TY51822R3 both for IAR

07:47:58 Building configuration: mbed-os-example-blinky - mbed-os-example-blinky
07:47:58 Updating build tree...
07:47:58 Build error: Multiple tools write to the same file.
07:47:58   File: C:\mj\workspace\bm_wrap\311\examples\mbed-os-example-blinky\BUILD\Obj\analogin_api.o
07:47:58   Tool 1: C/C++ Compiler, when processing C:\mj\workspace\bm_wrap\311\examples\mbed-os-example-blinky\mbed-os\targets\TARGET_NORDIC\TARGET_NRF5\analogin_api.c
07:47:58   Tool 2: C/C++ Compiler, when processing C:\mj\workspace\bm_wrap\311\examples\mbed-os-example-blinky\mbed-os\targets\TARGET_NORDIC\TARGET_NRF5\TARGET_MCU_NRF51822_UNIFIED\analogin_api.c

@theotherjimmy

@adbridge
Copy link
Contributor Author

Example build also still failing for NRF52_DK

8:18:47 Compiling mbed-os-example-ble-Thermometer for NRF52_DK, IAR
08:19:00 [ERROR] 
08:19:00 [mbed] ERROR: "c:\mj\workspace\bm_wrap\310\.env\scripts\python.exe" returned error code 1.
08:19:00 [mbed] ERROR: Command "c:\mj\workspace\bm_wrap\310\.env\scripts\python.exe -u C:\mj\workspace\bm_wrap\310\examples\mbed-os-example-ble-Thermometer\mbed-os\tools\make.py -t IAR -m NRF52_DK --source . --build .\BUILD\NRF52_DK\IAR --silent" in "C:\mj\workspace\bm_wrap\310\examples\mbed-os-example-ble-Thermometer"
08:21:18 [ERROR] 
08:21:18 [mbed] ERROR: "c:\mj\workspace\bm_wrap\310\.env\scripts\python.exe" returned error code 1.
08:21:18 [mbed] ERROR: Command "c:\mj\workspace\bm_wrap\310\.env\scripts\python.exe -u C:\mj\workspace\bm_wrap\310\examples\mbed-os-example-ble-BatteryLevel\mbed-os\tools\make.py -t IAR -m NRF52_DK --source . --build .\BUILD\NRF52_DK\IAR --silent" in "C:\mj\workspace\bm_wrap\310\examples\mbed-os-example-ble-BatteryLevel"

@pan- @theotherjimmy (looks like your fix Jimmy didn't quite fix everything ? )

@0xc0170
Copy link
Contributor

0xc0170 commented May 22, 2017

nordic and iar exporters issue - #4349 so all issues are IAR related?

@adbridge
Copy link
Contributor Author

Yeah all issues seem to be IAR related

@JanneKiiskila
Copy link
Contributor

When can we get the release? We would need the update git hash for inclusion to our release.
@geky @adbridge

@adbridge
Copy link
Contributor Author

@JanneKiiskila The patch release follows the normal published schedule, ie meaning the release is due tomorrow. However we're currently being delayed by some Nordic issues causing CI failures and thus are gating the release candidate. @pan- is looking at them . As soon as we can get them fixed and get the candidate passing the CI tests, then there will be an examples update , followed ~1 day later by the release itself.

@adbridge
Copy link
Contributor Author

/morph test-nightly

@adbridge
Copy link
Contributor Author

/morph export-build

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 42

All exports and builds passed!

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 332

Test failed!

@0xc0170
Copy link
Contributor

0xc0170 commented May 24, 2017

retest uvisor

@0xc0170
Copy link
Contributor

0xc0170 commented May 24, 2017

/morph test-nightly

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 337

All builds and test passed!

@0xc0170
Copy link
Contributor

0xc0170 commented May 25, 2017

@adbridge All green !

@adbridge adbridge merged commit 5fff7e1 into mbed-os-5.4 May 25, 2017
@adbridge
Copy link
Contributor Author

/morph mbed2-release

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph mbed2-release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.