Move duplicated analogin and pwmout to NRF52 directory #4366
Conversation
|
/morph test |
|
/morph export-build |
|
@pan- @screamerbg FYI |
There was a problem hiding this comment.
This patch will cause trouble for NRF52840 based targets which also require them. NRF52840 target doesn't define the label MCU_NRF52 (here) .
Maybe these files can go in a folder shared between NRF52832 and NRF52840 based target but it also requires a change in targets.json.
|
@pan- Thanks! I missed that. Any recomendations? |
theotherjimmy
force-pushed
the
dedupe-nordic
branch
from
34b0ce6 to
da9b8f3
Compare
|
/morph export-build |
Result: FAILUREYour command has finished executing! Here's what you wrote!
|
Result: FAILUREYour command has finished executing! Here's what you wrote!
|
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 40 Exporter Build failed! |
|
@pan- is looking at the failure . It is this error for some targets : |
|
@adbridge No, it is different than this untraceable error or the one this PR fix. |
Without this fix macro defined as -DFOO="BAR" won't be correctly handled by uvision.
Without this fix macro defined as -DFOO="BAR" won't be correctly interpreted by the compiler.
|
/morph test-nightly |
|
/morph export-build |
|
Thanks for the fixes @pan-! |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 41 All exports and builds passed! |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
@theotherjimmy Could you comment on the tests results ? I do not understand how the failure can be the linked to this PR. |
|
@pan- There were few devices which went bad causing erroneous results, re-triggering the job /morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
/morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Description
Resolves #4349
Both
analogin_api.candpwmapi.cwould fail for anyMCU_NRF51822_UNIFIEDtarget, as the files were duplicated there, when they seem to be intended for
any
MCU_NRF52target. This PR moves the files from the root to the lattertarget.
Status
Ready
Todos