Skip to content

Add port tests for ticker and lp ticker #4628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

c1728p9
Copy link
Contributor

@c1728p9 c1728p9 commented Jun 24, 2017

Add a test to make sure timer events scheduled for the past fire immediately, and add a test to ensure many events occurring at once do not cause a stack overflow.

@c1728p9
Copy link
Contributor Author

c1728p9 commented Jun 24, 2017

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 629

Build failed!

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 26, 2017

retest uvisor

return greentea_case_setup_handler(source, index_of_case);
}

utest::v1::status_t lp_ticker_setup(const Case *const source, const size_t index_of_case)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be protected also, same as 2 lp ticker cases?

Add a test to make sure timer events scheduled for the past fire
immediately, and add a test to ensure many events occurring at
once do not cause a stack overflow.
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 26, 2017

Rebased, fix that compilation error, we can rerun the tests

/morph test

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 26, 2017

Thanks Russ, this is great for testing the events in the past. I was able to rebase this, and run on some devices that I knew had some problems.

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 635

Test failed!

@theotherjimmy
Copy link
Contributor

@studavekar Was this failure related to this PR? or unstable tests?

@c1728p9
Copy link
Contributor Author

c1728p9 commented Jun 26, 2017

/morph test

@c1728p9
Copy link
Contributor Author

c1728p9 commented Jun 26, 2017

/morph test-nightly

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 27, 2017

I want to highlight #4644 and somehow align these 2 PR. Please @c1728p9 look at it, this test might need some refactor based on the result of 4644 but would like to have this test in for tickers (events in the past, and schedule a new one in the future).

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 657

All builds and test passed!

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 658

Test failed!

@studavekar
Copy link
Contributor

@c1728p9 looks like _hal-ticker_port seems to be failing on a large number of devices http://mbed-ci-master-2.austin.arm.com:8081/job/test_matrix/600/#showFailuresLink

@theotherjimmy
Copy link
Contributor

@c1728p9 Bump. What's the status?

@c1728p9
Copy link
Contributor Author

c1728p9 commented Jul 11, 2017

This will be updated when #4644 is.

@theotherjimmy
Copy link
Contributor

@c1728p9 Bump. any news?

@c1728p9
Copy link
Contributor Author

c1728p9 commented Jul 18, 2017

Closing this PR since the tests aren't relevant after #4644. Will open a new PR with updated tests in the future.

@c1728p9 c1728p9 closed this Jul 18, 2017
@sg- sg- removed the needs: work label Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants