Fix beetle and lpc176x set ticker event in the past #4633
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…past If the event is in the past, set pending interrupt instead of directly using timestamp.
Add a test to make sure timer events scheduled for the past fire immediately, and add a test to ensure many events occurring at once do not cause a stack overflow.
|
This should be replaced by #4644 , I'll reopen if that is not a case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #4632, for more platforms.
As we now have tests for this use case, these 2 are failing. If an event has a timestamp in the past, it either does not produce any callback or just crashes. This PR fixes it.
Will need a rebase once #4628 is being merged (it is included here) to be able to run the test. This was tested on Ach pro, before this patch ,the test would fail, with this patch, passes. Will run CI to get beetle passing.
this is the commit with fixes: f530acf
cc @mmorenobarm @toyowata @c1728p9