Skip to content

FlashIAP: Add explicit read function to flash_api.h #4720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2017
Merged

FlashIAP: Add explicit read function to flash_api.h #4720

merged 1 commit into from
Jul 7, 2017

Conversation

marcuschangarm
Copy link
Contributor

@marcuschangarm marcuschangarm commented Jul 6, 2017

On some platforms, the in-application memory is not memory mapped
and therefore cannot be accessed using memcpy.

The flash_read function added to flash_api.h (with a weak
implementation using memcpy in mbed_flash_api.c) can be used for
reading data from areas that are not memory mapped.

@marcuschangarm
Copy link
Contributor Author

@sg- As we discussed.

On some platforms, the in-application memory is not memory mapped
and therefore cannot be accessed using memcpy.

The flash_read function added to flash_api.h (with a weak
implementation using memcpy in mbed_flash_api.c) can be used for
reading data from areas that are not memory mapped.
@marcuschangarm
Copy link
Contributor Author

I think we need a more unique name than flash_read. I imagine that is quite common in SDKs.

Copy link
Contributor

@sg- sg- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM but someone has funky editor settings - looks like yours stripped some dead white space and someone else initially added 👍

@adbridge
Copy link
Contributor

adbridge commented Jul 7, 2017

/morph test

@mbed-bot
Copy link

mbed-bot commented Jul 7, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 744

All builds and test passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants