-
Notifications
You must be signed in to change notification settings - Fork 3k
REALTEK_RTL8195AM: FlashIAP read and address scope #4721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REALTEK_RTL8195AM: FlashIAP read and address scope #4721
Conversation
@adbridge Could you review this? |
@c1728p9 Could you review? |
/morph test |
So the flash address starts from 0x0? The Image 1 (0x0000 - 0xAFFF) area is not for application usage, so maybe the flash accessible address should start from 0xB000 (which is start address of Image 2) |
As far as I understand, the purpose of the API is to give unrestricted access to the NVM where the application is stored and users of this API knows that all safeties are off. |
If that's the case, I'll agree to start from 0x0000. |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
There was a problem with bot, let me restart the job /morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
The FlashIAP is supposed to have access to the full application memory, so the address scope has been changed to encompass the entire external flash. The address translation has also been changed to reflect the memory layout in the documentation: Realtek Ameba1 Memory Layout: 5.1 Flash Memory
I fixed a bug preventing the mbed-hal flash test to pass. In some instances the flash_on command wasn't called. |
/morph test |
@Archcady please rereview |
Looks good, thanks. |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Description
The FlashIAP is supposed to have access to the full application
memory, so the address scope has been changed to encompass
the entire external flash.
The address translation has also been changed to reflect the memory
layout in the documentation:
Realtek Ameba1 Memory Layout: 5.1 Flash Memory
Related PRs
Needs API change from #4720 to work.
Tests
Tested using GCC and ARM.