Skip to content

Correct long call macros for ARMC6 #5090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2017

Conversation

theotherjimmy
Copy link
Contributor

This should fix the extremely long compile times for the Realtek
RTL8195AM board. Could I get someone from Realtek to review?

@adbridge adbridge requested review from Archcady and removed request for Archcady September 13, 2017 15:05
@adbridge
Copy link
Contributor

@Archcady could you take a look at this please?

#ifdef CONFIG_RELEASE_BUILD_LIBRARIES
#define _LONG_CALL_
#define _LONG_CALL_ROM_
#ifdef E_CUT_ROM_DOMAIN
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tung7970 do we have this micro definition?

@theotherjimmy
Copy link
Contributor Author

/morph test

@theotherjimmy
Copy link
Contributor Author

@tommikas It looks like RAAS when down on this run. Is this something that has been fixed in the mean time?

@studavekar
Copy link
Contributor

/morph test

@mbed-bot
Copy link

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1308

Test failed!

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1310

Test failed!

@theotherjimmy
Copy link
Contributor Author

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1313

All builds and test passed!

@tommikas
Copy link
Contributor

@theotherjimmy Yep. I just didn't restart the jobs yesterday because the CI was under unusually heavy load at the time. Should be ok atm.

@theotherjimmy
Copy link
Contributor Author

@tommikas It looks like a failure in a python script in some unrelated tools:

13:22:03 [eth-8040-0]     msg = self.format(record)
13:22:03 [eth-8040-0]   File "/usr/lib/python2.7/logging/__init__.py", line 734, in format
13:22:03 [eth-8040-0]     return fmt.format(record)
13:22:03 [eth-8040-0]   File "/usr/lib/python2.7/logging/__init__.py", line 465, in format
13:22:03 [eth-8040-0]     record.message = record.getMessage()
13:22:03 [eth-8040-0]   File "/usr/lib/python2.7/logging/__init__.py", line 329, in getMessage
13:22:03 [eth-8040-0]     msg = msg % self.args
13:22:03 [eth-8040-0] TypeError: not all arguments converted during string formatting
13:22:03 [eth-8040-0] Logged from file opentmi_client.py, line 189
13:22:03 [eth-8040-0] Traceback (most recent call last):
13:22:03 [eth-8040-0]   File "/usr/lib/python2.7/logging/__init__.py", line 861, in emit
13:22:03 [eth-8040-0]     msg = self.format(record)
13:22:03 [eth-8040-0]   File "/usr/lib/python2.7/logging/__init__.py", line 734, in format
13:22:03 [eth-8040-0]     return fmt.format(record)
13:22:03 [eth-8040-0]   File "/usr/lib/python2.7/logging/__init__.py", line 465, in format
13:22:03 [eth-8040-0]     record.message = record.getMessage()
13:22:03 [eth-8040-0]   File "/usr/lib/python2.7/logging/__init__.py", line 329, in getMessage
13:22:03 [eth-8040-0]     msg = msg % self.args
13:22:03 [eth-8040-0] TypeError: not all arguments converted during string formatting

@theotherjimmy theotherjimmy merged commit 1ce1246 into ARMmbed:master Sep 15, 2017
@theotherjimmy theotherjimmy deleted the fix-realtek-warns branch September 15, 2017 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants