Skip to content

Correct booting on Nordic devices with ARMC6 #5091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2017
Merged

Correct booting on Nordic devices with ARMC6 #5091

merged 2 commits into from
Sep 19, 2017

Conversation

theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Sep 13, 2017 •
edited
Loading

READY
This should correct the booting of nordic devices so that they boot with
ARM6

@adbridge adbridge mentioned this pull request Sep 15, 2017
Closed
@theotherjimmy
Copy link
Contributor Author

Needs #5090

@theotherjimmy
Copy link
Contributor Author

@c1728p9 Can you confirm that this patch worked for you?

@c1728p9
Copy link
Contributor

c1728p9 commented Sep 15, 2017

Works for me with ARMC6 on nrf51 and nrf52 dk

@theotherjimmy
Copy link
Contributor Author

@studavekar Let's test this one with ARMC6 now that #5090 is in.

@studavekar
Copy link
Contributor

@theotherjimmy, yeah this would run with ARM 6.6.

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1321

All builds and test passed!

@theotherjimmy
Copy link
Contributor Author

@studavekar I do not see ARMC6 in that run. Was it enabled?

@studavekar
Copy link
Contributor

studavekar commented Sep 16, 2017 •
edited
Loading

I guess the job started before the change, re-triggering

/morph test

@studavekar
Copy link
Contributor

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1323

Build failed!

@theotherjimmy
Copy link
Contributor Author

build errors unrelated to this PR. Fixing in a subsequent PR.

/morph test

@adbridge
Copy link
Contributor

@theotherjimmy Who should review this ?

@theotherjimmy
Copy link
Contributor Author

@c1728p9 Already did.

@studavekar
Copy link
Contributor

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1336

All builds and test passed!

@adbridge adbridge merged commit f18d2d8 into ARMmbed:master Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c1728p9 c1728p9 c1728p9 approved these changes

Assignees
No one assigned
Labels
release-version: 5.6.0-rc2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@theotherjimmy @c1728p9 @studavekar @mbed-bot @adbridge