Timeout & LowPowerTimeout tests #5106

fkjagodzinski · 2017-09-14T15:41:43Z

Description

Added unit tests for timeout classes

Timeout,
LowPowerTimeout.

Status

READY

Preceding PR's needed:

~~TimerEvent tests #5046~~ -- provides a fix for several boards failing to handle a delay of 0 us,
~~MCUXpresso: Fix LPTimer issue when using multiple timeout objects #5347~~ -- provides a fix for LowPowerTimeout: Inconsistent delay when using multilple timeout objects #5150,

Issues to be resolved before merge:

~~STM32: lp_ticker_fire_interrupt: Event handler not called instantly when scheduled with past timestamp #5159~~
~~NCS36510: Timeout: Inconsistent delay when using multilple timeout objects #5431~~
~~Fire interrupt function broken for nrf5x targets #5284~~

0xc0170 · 2017-09-21T12:46:14Z

TESTS/mbed_drivers/timeout/main.cpp

+    sem->release();
+}
+
+void timeout_inc_callback(volatile uint32_t *cnt) {


coding style alignment in this file

Ok, I fixed brace positions for function declarations.

0xc0170 · 2017-09-21T12:50:12Z

cc @pan- @c1728p9

theotherjimmy · 2017-10-02T15:24:38Z

/morph test

theotherjimmy · 2017-10-02T15:25:08Z

/morph test-nightly

mbed-bot · 2017-10-03T07:06:19Z

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test-nightly

mbed-bot · 2017-10-03T07:06:19Z

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test

fkjagodzinski · 2017-10-03T14:54:26Z

As suggested in #5163 I've made an update to avoid code duplication:

rebased onto master (c60194f),
extracted test case templates to a header file,
added unit tests for LowPowerTimeout.

fkjagodzinski · 2017-10-03T14:59:30Z

TESTS/mbed_drivers/lp_timeout/main.cpp

+    Case("Callback override (with attach_us)", test_override<AttachUSTester<LowPowerTimeout> >),
+
+    Case("Multiple timeouts running in parallel (with attach)", test_multiple<AttachTester<LowPowerTimeout> >),
+    Case("Multiple timeouts running in parallel (with attach_us)", test_multiple<AttachUSTester<LowPowerTimeout> >),


These two tests with multiple LowPowerTimeout objects fail on K64F, NUCLEO_F070RB, NUCLEO_L476RG. Waiting for the outcome of #5150.

fkjagodzinski · 2017-10-03T14:59:54Z

TESTS/mbed_drivers/lp_timeout/main.cpp

+    Case("Multiple timeouts running in parallel (with attach_us)", test_multiple<AttachUSTester<LowPowerTimeout> >),
+
+    Case("Zero delay (with attach)", test_no_wait<AttachTester<LowPowerTimeout> >),
+    Case("Zero delay (with attach_us)", test_no_wait<AttachUSTester<LowPowerTimeout> >),


These tests fail on NUCLEO_F070RB, NUCLEO_F429ZI and NUCLEO_L476RG -- issue #5159.

0xc0170 · 2017-10-04T08:14:24Z

Thanks for the report, I'll label this as needs preceeding PR, and we need to wait for the fixes until this is made green

bulislaw

What do you think about moving the tests to
TESTS/mbed_drivers/timeout/{lp_timeout,timeout}/

Also can we make all the tests common (and the same) unless there are some characteristic of the specific timeout that we test.

bulislaw · 2017-10-04T09:48:55Z

TESTS/mbed_drivers/lp_timeout/main.cpp

+
+    Case("Zero delay (with attach)", test_no_wait<AttachTester<LowPowerTimeout> >),
+    Case("Zero delay (with attach_us)", test_no_wait<AttachUSTester<LowPowerTimeout> >),
+
    Case("500us LowPowerTimeout", lp_timeout_500us, greentea_failure_handler),


Can we make these tests common for both test suites?

Sure, I'll move these test cases to the header file.

fkjagodzinski · 2017-10-04T10:39:37Z

What do you think about moving the tests to
TESTS/mbed_drivers/timeout/{lp_timeout,timeout}/

@bulislaw That was my initial idea but as it turned out this would require changing test discovery procedure which now expects strictly defined dir structure

mbed-os/tools/test_api.py

Lines 2046 to 2050 in 373e6ab

    
           # If the test case folder is not called 'host_tests' and it is 
        
           # located two folders down from the main 'TESTS' folder (ex. TESTS/testgroup/testcase) 
        
           # then add it to the tests 
        
           path_depth = get_path_depth(relpath(d, walk_base_dir)) 
        
           if path_depth == 2:

so I chose a simpler solution.

bulislaw · 2017-10-04T11:05:16Z

@bulislaw That was my initial idea but as it turned out this would require changing test discovery procedure which now expects strictly defined dir structure

ok, makes sense.

adbridge · 2017-10-16T15:27:48Z

@fkjagodzinski @bulislaw is this now ready ?

fkjagodzinski · 2017-10-16T15:32:34Z

is this now ready ?

@adbridge PR needs a minor update. Should be ready tomorrow.

fkjagodzinski · 2018-02-28T16:42:10Z

Update:

rebased onto master, which is now at 8b6a7aa,
further increased a tolerance of measured delay SHORT_DELTA_US to 2000 us -- I have seen an error of 1597 us on NRF51_DK during my local tests.

Now all the boards that failed before, that is NCS36510, NRF51_DK and NRF52_DK, pass every test case!

@bulislaw, @0xc0170 could you take alook and accept this PR again, please? No changes (apart that SHORT_DELTA_US) were introduced.

fkjagodzinski · 2018-03-01T13:02:56Z

@bulislaw, @0xc0170, @cmonr Could you run morph tests please? I'm curious to see the results; there is still one issue left for NCS36510 (#5431) but this does not show up in my local tests using GCC_ARM toolchain and I don't have access to other toolchains at the moment.

bulislaw · 2018-03-01T13:42:27Z

@fkjagodzinski we are very close to a code freeze for 5.8, only PR critical for 5.8 can be run on the CI till we freeze (hopefully tomorrow). Next week should look better, we'll run it then.

fkjagodzinski · 2018-03-07T15:46:27Z

@0xc0170, @cmonr Could you update the labels with needs: review and needs: CI, and/or run morph tests please?

cmonr · 2018-03-07T16:58:47Z

@0xc0170 @bulislaw Could y'all take another look? It looks like this is ready to go again.

@0xc0170 Does this still need the DNM label?

@fkjagodzinski We can't start CI until we have at least one review OK the PR.

0xc0170 · 2018-03-07T17:54:16Z

/morph build

mbed-ci · 2018-03-07T18:32:17Z

Build : SUCCESS

Build number : 1381
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5106/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-03-07T20:24:06Z

Exporter Build : SUCCESS

Build number : 1035
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5106/

mbed-ci · 2018-03-08T10:39:08Z

Test : FAILURE

Build number : 1164
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5106/1164

0xc0170 · 2018-03-08T10:44:34Z

Restarting, a device error

/morph test

mbed-ci · 2018-03-08T20:43:47Z

Test : SUCCESS

Build number : 1172
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5106/1172

theotherjimmy added the needs: review label Sep 14, 2017

0xc0170 requested changes Sep 21, 2017

View reviewed changes

0xc0170 added needs: work and removed needs: review labels Sep 21, 2017

fkjagodzinski force-pushed the timeout_tests branch from 5eb67d2 to bddb14b Compare September 21, 2017 14:25

bulislaw previously approved these changes Sep 26, 2017

View reviewed changes

0xc0170 previously approved these changes Sep 27, 2017

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Sep 27, 2017

fkjagodzinski force-pushed the timeout_tests branch from bddb14b to c111ed3 Compare October 3, 2017 14:45

fkjagodzinski changed the title ~~Timeout tests~~ Timeout & LowPowerTimeout tests Oct 3, 2017

fkjagodzinski commented Oct 3, 2017

View reviewed changes

fkjagodzinski mentioned this pull request Oct 3, 2017

LowPowerTimeout tests #5163

Closed

0xc0170 added do not merge needs: preceding PR and removed needs: CI labels Oct 4, 2017

bulislaw reviewed Oct 4, 2017

View reviewed changes

fkjagodzinski force-pushed the timeout_tests branch from c111ed3 to a0829ee Compare October 18, 2017 15:29

fkjagodzinski dismissed stale reviews from 0xc0170 and bulislaw via 82f781c February 28, 2018 16:28

fkjagodzinski force-pushed the timeout_tests branch from a0829ee to 82f781c Compare February 28, 2018 16:28

cmonr added the needs: review label Mar 7, 2018

0xc0170 removed the do not merge label Mar 7, 2018

0xc0170 approved these changes Mar 7, 2018

View reviewed changes

0xc0170 removed needs: preceding PR needs: review labels Mar 9, 2018

0xc0170 approved these changes Mar 9, 2018

View reviewed changes

0xc0170 added the ready for merge label Mar 9, 2018

cmonr added release-version: 5.7.1 release-version: 5.8.1 and removed release-version: 5.7.1 labels Mar 12, 2018

cmonr merged commit b18c88e into ARMmbed:master Mar 15, 2018

cmonr removed the ready for merge label Mar 15, 2018

fkjagodzinski deleted the timeout_tests branch March 16, 2018 09:05

This was referenced Mar 20, 2018

Zero delay (attach) test fails for REALTEK_RTL8195AM #6410

Closed

Fix resetting of max_eirp and antenna_gain values #6401

Closed

fkjagodzinski mentioned this pull request Apr 11, 2018

lp_ticker and RTC tests failing for platforms based on STM32F412xx #6591

Closed

Timeout & LowPowerTimeout tests #5106

Timeout & LowPowerTimeout tests #5106

Uh oh!

Conversation

fkjagodzinski commented Sep 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Status

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Sep 21, 2017

Uh oh!

theotherjimmy commented Oct 2, 2017

Uh oh!

theotherjimmy commented Oct 2, 2017

Uh oh!

mbed-bot commented Oct 3, 2017

Uh oh!

mbed-bot commented Oct 3, 2017

Uh oh!

fkjagodzinski commented Oct 3, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Oct 4, 2017

Uh oh!

bulislaw left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fkjagodzinski commented Oct 4, 2017

Uh oh!

bulislaw commented Oct 4, 2017

Uh oh!

adbridge commented Oct 16, 2017

Uh oh!

fkjagodzinski commented Oct 16, 2017

Uh oh!

fkjagodzinski commented Feb 28, 2018

Uh oh!

fkjagodzinski commented Mar 1, 2018

Uh oh!

bulislaw commented Mar 1, 2018

Uh oh!

fkjagodzinski commented Mar 7, 2018

Uh oh!

cmonr commented Mar 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Mar 7, 2018

Uh oh!

mbed-ci commented Mar 7, 2018

Triggering tests

Uh oh!

mbed-ci commented Mar 7, 2018

Uh oh!

mbed-ci commented Mar 8, 2018

Uh oh!

0xc0170 commented Mar 8, 2018

Uh oh!

mbed-ci commented Mar 8, 2018

Uh oh!

Uh oh!

fkjagodzinski commented Sep 14, 2017 •

edited

Loading

cmonr commented Mar 7, 2018 •

edited

Loading