Fix resetting of max_eirp and antenna_gain values

[kivaisan]

Description

This is a fix for issue #6391

max_eirp and antenna_gain are floating point variables. Values of these
were incorrectly read from MIB as integer and therefore incorrect values
were set.

Pull request type

• Fix
• Refactor
• New target
• Feature
• Breaking change

[kivaisan]

@AnttiKauppila @kjbracey-arm , please review.

[0xc0170]

/morph build

[AnttiKauppila]

@0xc0170 This needs to be labeled 5.8.1

[kivaisan]

Updated commit description with "Lora:" prefix

[mbed-ci]

Build : SUCCESS

Build number : 1489
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6401/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

[mbed-ci]

Exporter Build : SUCCESS

Build number : 1135
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6401/

[cmonr]

The updated commit after the last morph build command caused the completed status to be lost.

Restarting build: /morph build

[mbed-ci]

Build : SUCCESS

Build number : 1498
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6401/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

[mbed-ci]

Exporter Build : SUCCESS

Build number : 1141
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6401/

[mbed-ci]

Test : FAILURE

Build number : 1280
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6401/1280

[cmonr]

sigh
And now it looks like we need a rebase.

@studavekar Could you have a look at the test failures? A whole bunch of Timing Drift failures just happened, and they don't appear to be PR related.

[studavekar]

@studavekar Could you have a look at the test failures? A whole bunch of Timing Drift failures just happened, and they don't appear to be PR related.

This was merged recently #5106 , few observation when working on the PR #5106 (comment) .

not sure if it was well tested before merging we should make sure any changes to tests are tested well. If not we will end up in tests that fail inconsistently(time drift tests would depend on load on the system which may cause transport delay ).

@cmonr we should be careful about merging changes to tests!

[kivaisan]

#6279 was merged and it refactors this code so this fix is no longer valid. But this #6279 is going to mbed-os 5.9 release.

@cmonr @0xc0170 This fix PR is still needed for mbed-os 5.8.x, so do I need rebase this to some other branch?

[kjbracey]

If #6279 avoids the problem in a different way, as I think it does, then resubmit this as a PR to the mbed-os-5.8 branch. Make very clear in the PR / commit message that the problem no longer occurs on master due to #6279 / master commit id. (All patch fixes or their equivalent have to be already present on master).

[kivaisan]

This PR can be closed. I just created a new PR for 5.8 branch: #6414.