Skip to content

Lora: Fix resetting of max_eirp and antenna_gain values (mbed-os 5.8 branch) #6414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Lora: Fix resetting of max_eirp and antenna_gain values (mbed-os 5.8 branch) #6414

wants to merge 1 commit into from

Conversation

kivaisan
Copy link
Contributor

Description

This is a fix for issue #6391. Please note that this commit is only for mbed-os 5.8 branch. In master this issue no longer occurs due to PR #6279.

max_eirp and antenna_gain are floating point variables. Values of these
were incorrectly read from MIB as integer and therefore incorrect values
were set.

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change

This is a fix for issue #6391

max_eirp and antenna_gain are floating point variables. Values of these
were incorrectly read from MIB as integer and therefore incorrect values
were set.
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 21, 2018

We are currently not taking directly to the release branch. We will take it from here, and add it manually to 5.8.1

@AnttiKauppila
Copy link

@0xc0170 Please label this with 5.8.1

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 21, 2018

@0xc0170 Please label this with 5.8.1

We are aware of this and take this manually as specified above once release candidate is created. Will get in

@adbridge
Copy link
Contributor

@AnttiKauppila To be more clear. The release script works on PRs that are already merged to master branch and creates patches from those which then go to the release-candidate branch along with all others tagged for the same release. A PR is then raised from the release-candidate to the release branch and that PR is tested in CI. As this cannot be merged directly to the release branch , tagging it would break the release script. We will thus have to deal with this manually.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 4, 2018

Marked for 5.8.2 (@adbridge @cmonr ), once we run the script, this should be removed and cherry-picked. I checked 5.8.1, the commit was not propagated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants