Skip to content

Change LPC54608 to LPC546XX to include support for LPC54608/18/28 #5162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2017
Merged

Change LPC54608 to LPC546XX to include support for LPC54608/18/28 #5162

merged 1 commit into from
Oct 3, 2017

Conversation

mmahadevan108
Copy link
Contributor

Same code-base can support LPC54608/18/28 platform family.

Status

**READY

Todos

  • Tests
    mbed tests passed on the 54608 board.

@mmahadevan108
Copy link
Contributor Author

cc @maclobdell @0xc0170

@mmahadevan108
Copy link
Contributor Author

cc @theotherjimmy

@gorazdko
Copy link
Contributor

could you add ethernet_api.c?

@mmahadevan108
Copy link
Contributor Author

mmahadevan108 commented Sep 22, 2017 •
edited
Loading

I am working to add ethernet support as a separate PR.

@mmahadevan108 mmahadevan108 force-pushed the Support_LPC54618 branch 2 times, most recently from b86fa8b to 55bfb32 Compare September 22, 2017 18:54
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 29, 2017

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1447

Build Prep failed!

@mmahadevan108
Copy link
Contributor Author

Resolved conflicts.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 2, 2017

/morph test

@mbed-bot
Copy link

mbed-bot commented Oct 2, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1492

All builds and test passed!

@theotherjimmy
Copy link
Contributor

@mmahadevan108 Could you change the sha of the last commit to kick out Circle CI? we'll retrigger testing after that.

@mmahadevan108
Copy link
Contributor Author

@theotherjimmy I am not familiar how to do this, can you please provide more details.

@theotherjimmy
Copy link
Contributor

@mmahadevan108 You could run git commit --amend on the last commit in the series, without making any changes. Then you would force push, git push -f.

@maclobdell
Copy link
Contributor

@theotherjimmy please kick off the tests and try to get this merged urgently and released in 5.6.2.

@theotherjimmy
Copy link
Contributor

/morph test

@mbed-bot
Copy link

mbed-bot commented Oct 3, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1513

All builds and test passed!

@theotherjimmy theotherjimmy merged commit 2291644 into ARMmbed:master Oct 3, 2017
@mmahadevan108 mmahadevan108 deleted the Support_LPC54618 branch October 13, 2017 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.6.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mmahadevan108 @gorazdko @0xc0170 @mbed-bot @theotherjimmy @maclobdell @adbridge