New Target: Mbed Connect Cloud board #5305

@andcor02, copy features/FEATURE_LWIP/lwip-interface/lwip-eth/arch/TARGET_STM/TARGET_STM32F4/TARGET_UBLOX_EVK_ODIN_W2/ to features/FEATURE_LWIP/lwip-interface/lwip-eth/arch/TARGET_STM/TARGET_STM32F4/TARGET_MBED_CONNECT_ODIN/

This fixed it for me in ARMCC5

andcor02 · 2017-10-20T10:05:15Z

Thanks for the help Jan! Pushed changes!

0xc0170 · 2017-10-23T14:29:41Z

/morph build

mbed-ci · 2017-10-23T14:57:20Z

Build : SUCCESS

Build number : 308
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5305/

Triggering tests

/morph test
/morph uvisor-test

mbed-ci · 2017-10-23T16:00:28Z

Test : SUCCESS

Build number : 139
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5305/139

adbridge

There are a number of minor formatting issues. Could we please fix ?

adbridge · 2017-10-26T10:09:38Z

...nterface/lwip-eth/arch/TARGET_STM/TARGET_STM32F4/TARGET_MBED_CONNECT_ODIN/stm32f4_eth_conf.c

+void _eth_config_mac(ETH_HandleTypeDef *heth)
+{
+    ETH_MACInitTypeDef macconf =
+        {


Shouldn't this '{' be on the line above?

adbridge · 2017-10-26T10:10:25Z

...nterface/lwip-eth/arch/TARGET_STM/TARGET_STM32F4/TARGET_MBED_CONNECT_ODIN/stm32f4_eth_conf.c

+        .TransmitFlowControl = ETH_TRANSMITFLOWCONTROL_DISABLE,
+        .VLANTagComparison = ETH_VLANTAGCOMPARISON_16BIT,
+        .VLANTagIdentifier = 0x0U,
+        };


I think this '}' should line up with ETH_MACInitTypeDef

adbridge · 2017-10-26T10:11:03Z

...nterface/lwip-eth/arch/TARGET_STM/TARGET_STM32F4/TARGET_MBED_CONNECT_ODIN/stm32f4_eth_init.c

+    if (id == 0xFF){
+        p++;
+    }
+    else {


This should be
} else {

adbridge · 2017-10-26T10:11:50Z

...nterface/lwip-eth/arch/TARGET_STM/TARGET_STM32F4/TARGET_MBED_CONNECT_ODIN/stm32f4_eth_init.c

+        HAL_GPIO_Init(GPIOA, &GPIO_InitStructure);
+
+        /* Configure PB13 */
+	    GPIO_InitStructure.Pin = GPIO_PIN_13 | GPIO_PIN_11 | GPIO_PIN_12;


Indenting issue here ?

adbridge · 2017-10-26T10:12:13Z

...nterface/lwip-eth/arch/TARGET_STM/TARGET_STM32F4/TARGET_MBED_CONNECT_ODIN/stm32f4_eth_init.c

+
+        /* Configure PC1, PC4 and PC5 */
+        GPIO_InitStructure.Pin = GPIO_PIN_1 | GPIO_PIN_4 | GPIO_PIN_5;
+	    HAL_GPIO_Init(GPIOC, &GPIO_InitStructure);


Indenting issue here

Need to review again after changes

andcor02 · 2017-10-31T11:01:12Z

@adbridge @0xc0170 , Fixed, please check and merge

adbridge

Just a couple more minor tweaks, the rest looks ok

adbridge · 2017-10-31T11:07:05Z

...nterface/lwip-eth/arch/TARGET_STM/TARGET_STM32F4/TARGET_MBED_CONNECT_ODIN/stm32f4_eth_conf.c

+        .ReceiveFlowControl = ETH_RECEIVEFLOWCONTROL_DISABLE,
+        .TransmitFlowControl = ETH_TRANSMITFLOWCONTROL_DISABLE,
+        .VLANTagComparison = ETH_VLANTAGCOMPARISON_16BIT,
+        .VLANTagIdentifier = 0x0U, };


@andcor02 Sorry to be a pain, the terminating brace should be on it's own line and directly underneath the E of ETH_MACInitTypeDef macconf . I don't think there should be a comma after the last entry either.

adbridge · 2017-10-31T11:10:28Z

...nterface/lwip-eth/arch/TARGET_STM/TARGET_STM32F4/TARGET_UBLOX_EVK_ODIN_W2/stm32f4_eth_conf.c

@@ -48,8 +47,7 @@ void _eth_config_mac(ETH_HandleTypeDef *heth)
        .ReceiveFlowControl = ETH_RECEIVEFLOWCONTROL_DISABLE,
        .TransmitFlowControl = ETH_TRANSMITFLOWCONTROL_DISABLE,
        .VLANTagComparison = ETH_VLANTAGCOMPARISON_16BIT,
-        .VLANTagIdentifier = 0x0U,
-        };
+        .VLANTagIdentifier = 0x0U, };


@andcor02 When I commented that the terminating brace should be underneath the ETH, I meant on it's own line and directly underneath the E of ETH_MACInitTypeDef macconf . I don't think there should be a comma after the last entry either.

See changes

…it, added ublox changes Corrected error Corrected error in targets json Reworked JSON Added lwip-eth to Connect ODIN removes ARM CC error Fixed formating issues Correct formating error in .json Indentation errors

studavekar · 2017-10-31T20:26:12Z

/morph build

mbed-ci · 2017-10-31T20:51:09Z

Build : SUCCESS

Build number : 401
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5305/

Triggering tests

/morph test
/morph uvisor-test

mbed-ci · 2017-10-31T22:49:59Z

Test : SUCCESS

Build number : 195
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5305/195

adbridge

Some other minor possible updates and then we should be good to go.

adbridge · 2017-11-07T12:38:00Z

...nterface/lwip-eth/arch/TARGET_STM/TARGET_STM32F4/TARGET_MBED_CONNECT_ODIN/stm32f4_eth_init.c

+    memcpy((void*)&id, (void*)pTemp, 1);
+
+    if (id == 0xFF){
+        p++;


p++ is done in both parts of the conditional. Would it be better to write as :

p++; if (id != 0xFF){ memcpy((void*)&len, (void*)p++, 1); p += len; }

??

adbridge · 2017-11-07T12:42:44Z

...nterface/lwip-eth/arch/TARGET_STM/TARGET_STM32F4/TARGET_MBED_CONNECT_ODIN/stm32f4_eth_init.c

+            pTemp = increment(pTemp);
+        }
+        if (pFound != NULL) {
+            memcpy(_macAddr, pFound->data, 6);


I assume the 6 is the size of the macAddr - could this be a #define then ?

adbridge · 2017-11-07T12:43:05Z

...nterface/lwip-eth/arch/TARGET_STM/TARGET_STM32F4/TARGET_MBED_CONNECT_ODIN/stm32f4_eth_init.c

+            _macRetrieved = 1;
+        }
+    }
+    memcpy(mac, _macAddr, 6);


Same comment as above

adbridge · 2017-11-07T12:43:56Z

...nterface/lwip-eth/arch/TARGET_STM/TARGET_STM32F4/TARGET_UBLOX_EVK_ODIN_W2/stm32f4_eth_init.c

@@ -25,8 +25,7 @@ static C029_OTP_Header *increment(C029_OTP_Header *pTemp)

    if (id == 0xFF){


Same comment as the one above about this conditional structure

adbridge · 2017-11-07T13:36:00Z

Last set of comments , purely possible improvements. Agreed they should go back to the maintainers of these files for inclusion in subsequent PRs. Thus accepting this one

adbridge · 2017-11-07T13:38:35Z

@studavekar Why has a new comment kicked off the CI again?! This is not right

mbed-ci · 2017-11-07T14:09:06Z

Build : FAILURE

Build number : 447
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5305/

adbridge · 2017-11-07T15:06:54Z

Looks like we have a possible genuine failure:
REALTEK_RTL8195AM (netsocket tests for all toolchains)

        [Error] mbed_config.h@60,90: 'WIFI_SSID' was not declared in this scope
        [Error] mbed_config.h@60,101: 'WIFI_PASSWORD' was not declared in this scope
        [Error] mbed_config.h@60,116: 'WIFI_SECURITY' was not declared in this scope
        [Error] mbed_config.h@60,131: 'WIFI_CHANNEL' was not declared in this scope

0xc0170 · 2017-11-07T15:18:26Z

Yes, that is correct, #5445 - once CI is back again, this should get first in !

0xc0170 · 2017-11-08T11:36:54Z

/morph build

mbed-ci · 2017-11-08T12:04:21Z

Build : SUCCESS

Build number : 455
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5305/

Triggering tests

/morph test
/morph uvisor-test

mbed-ci · 2017-11-08T13:07:58Z

Test : SUCCESS

Build number : 274
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5305/274

0xc0170 · 2017-11-09T16:52:44Z

/morph export-build

mbed-ci · 2017-11-09T18:04:04Z

Exporter Build : SUCCESS

Build number : 98
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5305/

andcor02 mentioned this pull request Oct 12, 2017

New Target Mbed Connect Cloud board #5262

Closed

0xc0170 added the needs: review label Oct 12, 2017

0xc0170 previously approved these changes Oct 12, 2017

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Oct 13, 2017

0xc0170 added needs: work and removed needs: CI labels Oct 19, 2017

theotherjimmy changed the title ~~New Target Mbed Connect Cloud board - redo!~~ New Target: Mbed Connect Cloud board Oct 23, 2017

theotherjimmy added scope: new-target needs: CI and removed needs: work labels Oct 23, 2017

0xc0170 added ready for merge and removed needs: CI labels Oct 23, 2017

adbridge requested changes Oct 26, 2017

View reviewed changes

adbridge added needs: work and removed ready for merge labels Oct 26, 2017

adbridge requested changes Oct 31, 2017

View reviewed changes

theotherjimmy added needs: review and removed needs: work labels Nov 6, 2017

adbridge requested changes Nov 7, 2017

View reviewed changes

adbridge approved these changes Nov 7, 2017

View reviewed changes

0xc0170 added ready for merge and removed needs: review labels Nov 8, 2017

0xc0170 added needs: CI and removed ready for merge labels Nov 9, 2017

0xc0170 added ready for merge release-version: 5.6.5 and removed needs: CI labels Nov 10, 2017

0xc0170 merged commit 47bae16 into ARMmbed:master Nov 10, 2017

0xc0170 removed the ready for merge label Nov 10, 2017

		@@ -25,8 +25,7 @@ static C029_OTP_Header increment(C029_OTP_Header pTemp)

		if (id == 0xFF){

New Target: Mbed Connect Cloud board #5305

New Target: Mbed Connect Cloud board #5305

Uh oh!

Conversation

andcor02 commented Oct 12, 2017

Description

Status

Migrations

Uh oh!

mbed-ci commented Oct 12, 2017

Triggering tests

Uh oh!

0xc0170 commented Oct 12, 2017

Uh oh!

mbed-ci commented Oct 12, 2017

Triggering tests

Uh oh!

mbed-ci commented Oct 13, 2017

Uh oh!

screamerbg commented Oct 13, 2017

Uh oh!

andreaslarssonublox commented Oct 14, 2017

Uh oh!

0xc0170 commented Oct 18, 2017

Uh oh!

mbed-ci commented Oct 18, 2017

Uh oh!

0xc0170 commented Oct 19, 2017

Uh oh!

janjongboom commented Oct 20, 2017

Uh oh!

andcor02 commented Oct 20, 2017

Uh oh!

0xc0170 commented Oct 23, 2017

Uh oh!

mbed-ci commented Oct 23, 2017

Triggering tests

Uh oh!

mbed-ci commented Oct 23, 2017

Uh oh!

adbridge left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andcor02 commented Oct 31, 2017

Uh oh!

adbridge left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

studavekar commented Oct 31, 2017

Uh oh!

mbed-ci commented Oct 31, 2017

Triggering tests

Uh oh!

mbed-ci commented Oct 31, 2017

Uh oh!

adbridge left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!