Add tests for critical section HAL API

[maciejbocianski]

Description

This PR contains critical section HAL API tests.
Test were created based on documentation provided in PR #5346

Status

READY

Migrations

NO

Notes

in order to run these tests #5346 has to be merged first,

Todos

• adopt test for NRF5X series

[maciejbocianski]

@scartmell-arm
as discussed it would be good to have hal_in_critical_section function to cover NRF5x like targets which mask application interrupts rather than disable all interrupts

[maciejbocianski]

support for NRF5x added

[0xc0170]

wasn't there somewhere a request for having function to check if interrupts are enabled? Or even an implementation?

[maciejbocianski]

indeed, there is function hal_in_critical_section(), but it would be nice to verify API functions by something form outside critical section API. us_ticker could be used to check interrupts but unfortunately it utilises core_util_critical_section_ (which also call HAL critical API ) and it brakes the test. Generly we should always use platform core_util_critical_section not HAL, in particular we cannot use both in the same time

[0xc0170]

I was concerned about the portability (how this function can grow in time).

Looks fine to test this here.

[0xc0170]

/morph build

[cmonr]

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 910
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5789/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

[cmonr]

Jenkins didn't report abort.

/morph export-build

[mbed-ci]

Test : FAILURE

Build number : 752
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5789/752

[mbed-ci]

Exporter Build : SUCCESS

Build number : 590
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5789/

[maciejbocianski]

@scartmell-arm @0xc0170
I have added fix for masked interrupts check on NRF52

It turned out that none of interrupts handled by ISER/ICER[1] is actually enabled(used)
and (NVIC->ISER[1] & __NRF_NVIC_APP_IRQS_1) != 0 always returns false.

I modified the checking code from:

return (((NVIC->ISER[0] & __NRF_NVIC_APP_IRQS_0) != 0) 
           && ((NVIC->ISER[1] & __NRF_NVIC_APP_IRQS_1) != 0));

to:

return (((NVIC->ISER[0] & __NRF_NVIC_APP_IRQS_0) != 0) 
           || ((NVIC->ISER[1] & __NRF_NVIC_APP_IRQS_1) != 0));

Now we check __NRF_NVIC_APP_IRQS_1 only when __NRF_NVIC_APP_IRQS_0 are masked

[0xc0170]

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 934
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5789/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

[mbed-ci]

Exporter Build : SUCCESS

Build number : 621
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5789/

[0xc0170]

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 951
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5789/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

[mbed-ci]

Test : SUCCESS

Build number : 781
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5789/781

[mbed-ci]

Exporter Build : SUCCESS

Build number : 638
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5789/