Revise the structure in RZ_A1 related directory #5813

TomoYamanaka · 2018-01-09T09:57:25Z

Description

I registed GR-LYCHEE as a Renesas new Mbed board.
And same as Cortex-M targets, I changed the folder structure to combine files that can be shared in RZ_A1 related directory.

In the below "features/FEATURE_LWIP" folders, same as Cortex-M targets, I changed the folder structure to combine files that can be shared as RZ/A1 related. And I renamed the folder name to "TARGET_RZ_A1XX" in order to make commonality explicit. - "features/FEATURE_LWIP" folder <before> \features\FEATURE_LWIP\lwip-interface\lwip-eth\arch\TARGET_RZ_A1H \features\FEATURE_LWIP\lwip-interface\lwip-eth\arch\TARGET_VK_RZ_A1H <after> \features\FEATURE_LWIP\lwip-interface\lwip-eth\arch\TARGET_RZ_A1XX

In "targets/TARGET_RENESAS" folders, same as Cortex-M targets, I changed the folder structure to combine files that can be shared as RZ/A1 related. And I renamed the folder name to "TARGET_RZ_A1XX" in order to make commonality explicit. - "targets/TARGET_RENESAS" folder <before> \targets\TARGET_RENESAS\TARGET_RZ_A1H \targets\TARGET_RENESAS\TARGET_VK_RZ_A1H <after> \targets\TARGET_RENESAS\TARGET_RZ_A1XX

…ctory I made be available in common whatever the board related to RZ_A1 in the below files. - Since there are the table code of Pinmap differs for each board, I moved the code to "PeripheralPins" file for each board, and changed to include PeripheralPins.h. analogin_api.c, can_api.c, gpio_irq_api.c, i2c_api.c, pinmap.c, port_api.c, pwmout_api.c, serial_api.c, spi_api.c and us_ticker.c - Since there are some board-specific processes, I enclosed the processes with "#ifdef" and rearranged the functions to make be easier to enclose. can_api.c, ethernet_api.c and serial_api.c - Since there are the driver configuration values differs for each board, I added "mbed_drv_cfg.h" file for each board and defined macros for the values, and changed to refer to the macros. can_api.c, gpio_api.c, pwmout_api.c and rtc_api.c

As a result of revision of folder structure, I changed the values of "extra_labels" of RZ_A1-related in targets.json.

For LWIP communication speedup in RZ_A1 related, I changed the below macro value and added the definition processing in RZ/A1 related header file(lwipopts_conf.h). For this reason, those macros are overrode by RZ/A1 related values, not default values.

I modified the debug message when using LWIP in RZ/A1 related mbed boards. In eth_arch_enetif_init(), sys_thread_new() was called and task name is appeared as debug information, but task name for debug was a mistake.

0xc0170 · 2018-01-09T14:04:48Z

Please review travis failure (.s - should be .S extension)

TomoYamanaka · 2018-01-10T02:29:02Z

I rebased my commits to change extention from .s to .S.

0xc0170

Could this be split into 2 PR, one revise the dir structure , second on top of it, adding new target ?

I left few comments

0xc0170 · 2018-01-10T10:59:14Z

features/FEATURE_LWIP/lwip-interface/lwip-eth/arch/TARGET_RZ_A1XX/rza1_emac.c


 #define RECV_TASK_PRI           (osPriorityNormal)
 #define PHY_TASK_PRI            (osPriorityNormal)
 #define PHY_TASK_WAIT           (200)

+WEAK int ethernetext_init(ethernet_cfg_t *p_ethcfg) { return -1;}


all functions here should have alignment as follows:

WEAK int ethernetext_init(ethernet_cfg_t *p_ethcfg) { return -1; }

0xc0170 · 2018-01-10T11:01:07Z

targets/TARGET_RENESAS/TARGET_RZ_A1XX/trng_api.c

+extern void trng_free_esp32(void);
+extern int trng_get_bytes_esp32(uint8_t *output, size_t length, size_t *output_length);
+
+void trng_init(trng_t *obj) {


{ new line in all these functions in this commit

0xc0170 · 2018-01-10T11:01:51Z

targets/TARGET_RENESAS/TARGET_RZ_A1XX/TARGET_GR_LYCHEE/trng_api_esp32.cpp

+ */
+
+#if defined(DEVICE_TRNG)
+#include "mbed.h"


Can you include what is required here rather than one-do-it-all header file?

TomoYamanaka · 2018-01-11T07:54:31Z

I will split this PR to two PRs. One is "revise the dir structure", other is "add new target".
Of course, I will reflect your above comments.

First:
I will revise this PR(only "revise the dir structure" excepting GR-LYCHEE related commits).
Second:
After this PR("revise the dir structure") was merged, I will PR "add new target" as a new request.

TomoYamanaka · 2018-01-11T08:56:37Z

I rebased those commits to separate "new target(GR-LYCHEE)" related commit from this PR, and renamed this PR title. This PR is contents of "revise the dir structure" RZ_A1 related.

I added the function declarations of Ethernet functions that have a WEAK attribute. Although several Ethernet functions was called in rza1_emac.c, GR-LYCHEE don't have Ethernert feature. But there may be case that GR-LYCHEE uses LWIP feature. In this case, since GR-LYCHEE will occur the build error, I addressed the error by defining the functions with a WEAK attribute. For reason of WEAK attribute, there is no influence in GR-PEACH and VK_RZ_A1H that have Ethernet feature.

0xc0170

Thanks for splitting the PR.

Looks good to me the new structure, one question is if we could use target inheritance

0xc0170 · 2018-01-11T12:24:07Z

targets/targets.json

@@ -2430,7 +2430,7 @@
        "supported_form_factors": ["ARDUINO"],
        "core": "Cortex-A9",
        "program_cycle_s": 2,
-        "extra_labels": ["RENESAS", "MBRZA1H"],
+        "extra_labels": ["RENESAS", "RZ_A1XX", "RZA1H", "MBRZA1H"],


Would it be better to create RZ_A1XX target that the other would inherit from ? Thus device_has and all others would be also inherited. It could look like this:

- RZ_A1XX - RZ_A1H - VK_RZ_A1H

Not everything can be inherited. For example, in case of VK_RZ_A1H, "release_versions" is 2 only, and in case of GR_LYCHEE(will be next PR), there is not "Ethernet" function.
Thus, I will create "RZ_A1XX" target in the form of items that can be shared, and will inherit it in both RZ_A1H and VK_RZ_A1H.

0xc0170 · 2018-01-11T12:25:31Z

targets/TARGET_RENESAS/TARGET_RZ_A1XX/TARGET_VK_RZ_A1H/mbed_drv_cfg.h

@@ -0,0 +1,19 @@
+#ifndef MBED_DRV_CFG_H


Please add copyrigh header files (as the rest of th files contain it)

I will add the copyright in the below header files.
targets/TARGET_RENESAS/TARGET_RZ_A1XX/TARGET_RZ_A1H/mbed_drv_cfg.h
targets/TARGET_RENESAS/TARGET_RZ_A1XX/TARGET_VK_RZ_A1H/mbed_drv_cfg.h

cmonr · 2018-01-11T16:43:35Z

/morph build

mbed-ci · 2018-01-11T17:00:17Z

Build : SUCCESS

Build number : 842
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5813/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2018-01-11T18:41:56Z

Exporter Build : FAILURE

Build number : 507
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5813/

mbed-ci · 2018-01-11T19:21:27Z

Test : SUCCESS

Build number : 687
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5813/687

I modified the lack of copyright in the below header files that I added for commonizing the RZ_A1 related files. - targets/TARGET_RENESAS/TARGET_RZ_A1XX/TARGET_RZ_A1H/mbed_drv_cfg.h - targets/TARGET_RENESAS/TARGET_RZ_A1XX/TARGET_VK_RZ_A1H/mbed_drv_cfg.h

TomoYamanaka · 2018-01-12T06:08:18Z

@0xc0170

Thank you for your comments. I added two commits that reflected your above advice.

0xc0170 · 2018-01-12T08:10:07Z

targets/targets.json

+    "RZ_A1H": {
+        "inherits": ["RZ_A1XX"],
+        "supported_form_factors": ["ARDUINO"],
+        "extra_labels_add": ["RZA1H", "MBRZA1H"],
        "device_has": ["ANALOGIN", "CAN", "ETHERNET", "I2C", "I2CSLAVE", "I2C_ASYNCH", "INTERRUPTIN", "PORTIN", "PORTINOUT", "PORTOUT", "PWMOUT", "RTC", "SERIAL", "SERIAL_ASYNCH", "SERIAL_FC", "SPI", "SPISLAVE", "SPI_ASYNCH", "STDIO_MESSAGES"],


small improvement - if RZ_A1XX is the parent, that one contains the implementation for entire HAL, therefore device_has can be moved there. Each inherited target can overwrite it add/remove.

features as well, then RZ A1H and VK RZ A1 targets have only few attributes to define, same for the upcominig new target.

I added the "RZ_A1XX" label for commonizing the setting in targets.json, and inherited in both RZ_A1H and VK_RZ_A1H.

TomoYamanaka · 2018-01-12T09:37:06Z

@0xc0170

I rebased my commit due to apply small improvement that you mentioned.

0xc0170

VK RZ A1H should now compile and can be added release version for mbed 2?

0xc0170 · 2018-01-12T10:33:40Z

/morph build

TomoYamanaka · 2018-01-12T10:38:11Z

VK RZ A1H should now compile and can be added release version for mbed 2?

Regaring VK_RZ_A1H, @mbedNoobNinja will be in charge of updating.
Please refer to #5777.

mbed-ci · 2018-01-12T10:49:59Z

Build : SUCCESS

Build number : 850
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5813/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2018-01-12T13:14:44Z

Exporter Build : SUCCESS

Build number : 520
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5813/

mbed-ci · 2018-01-12T15:08:20Z

Test : SUCCESS

Build number : 694
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5813/694

0xc0170 · 2018-01-12T15:17:15Z

@mbedNoobNinja FYI

TomoYamanaka added 6 commits January 9, 2018 16:48

Change the values of RZ_A1 related "extra_labels" in targets.json

1b303ab

As a result of revision of folder structure, I changed the values of "extra_labels" of RZ_A1-related in targets.json.

Modify the TYPO of debug info when using LWIP in RZ/A1 related

9cbd678

I modified the debug message when using LWIP in RZ/A1 related mbed boards. In eth_arch_enetif_init(), sys_thread_new() was called and task name is appeared as debug information, but task name for debug was a mistake.

TomoYamanaka mentioned this pull request Jan 9, 2018

VK RZ A1H: needs an update from RZ A1H (cmsis, rtos related) #5777

Closed

0xc0170 added the needs: work label Jan 9, 2018

TomoYamanaka force-pushed the master branch from c3a6559 to df219c4 Compare January 10, 2018 02:14

0xc0170 reviewed Jan 10, 2018

View reviewed changes

TomoYamanaka force-pushed the master branch from df219c4 to 3380d48 Compare January 11, 2018 08:51

TomoYamanaka changed the title ~~Registration GR-LYCHEE board and Revise the structure in RZ_A1 related directory~~ Revise the structure in RZ_A1 related directory Jan 11, 2018

TomoYamanaka force-pushed the master branch from 3380d48 to 0d00be3 Compare January 11, 2018 09:12

0xc0170 reviewed Jan 11, 2018

View reviewed changes

0xc0170 reviewed Jan 12, 2018

View reviewed changes

Add "RZ_A1XX" label for commonizing in targets.json

3fddcc1

I added the "RZ_A1XX" label for commonizing the setting in targets.json, and inherited in both RZ_A1H and VK_RZ_A1H.

TomoYamanaka force-pushed the master branch from 738ddff to 3fddcc1 Compare January 12, 2018 09:23

0xc0170 approved these changes Jan 12, 2018

View reviewed changes

0xc0170 added needs: review and removed needs: work labels Jan 12, 2018

0xc0170 added needs: CI and removed needs: review labels Jan 12, 2018

0xc0170 added ready for merge and removed needs: CI labels Jan 12, 2018

0xc0170 added the release-version: 5.7.4 label Jan 15, 2018

0xc0170 merged commit 2d83463 into ARMmbed:master Jan 15, 2018

0xc0170 removed the ready for merge label Jan 15, 2018

TomoYamanaka mentioned this pull request Jan 16, 2018

Registration GR-LYCHEE board as a new mbed board #5857

Merged

cmonr added release-version: 5.7.4 and removed release-version: 5.7.4 labels Jan 27, 2018

Revise the structure in RZ_A1 related directory #5813

Revise the structure in RZ_A1 related directory #5813

Uh oh!

Conversation

TomoYamanaka commented Jan 9, 2018

Description

Uh oh!

0xc0170 commented Jan 9, 2018

Uh oh!

TomoYamanaka commented Jan 10, 2018

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TomoYamanaka commented Jan 11, 2018

Uh oh!

TomoYamanaka commented Jan 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmonr commented Jan 11, 2018

Uh oh!

mbed-ci commented Jan 11, 2018

Triggering tests

Uh oh!

mbed-ci commented Jan 11, 2018

Uh oh!

mbed-ci commented Jan 11, 2018

Uh oh!

TomoYamanaka commented Jan 12, 2018

Uh oh!

0xc0170 Jan 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TomoYamanaka commented Jan 12, 2018

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Jan 12, 2018

Uh oh!

TomoYamanaka commented Jan 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbed-ci commented Jan 12, 2018

Triggering tests

Uh oh!

mbed-ci commented Jan 12, 2018

Uh oh!

mbed-ci commented Jan 12, 2018

Uh oh!

0xc0170 commented Jan 12, 2018

Uh oh!

Uh oh!

TomoYamanaka commented Jan 11, 2018 •

edited

Loading

0xc0170 Jan 12, 2018 •

edited

Loading

TomoYamanaka commented Jan 12, 2018 •

edited

Loading