add support for STM32L443RC & WISE-1510 #5904

ithinuel · 2018-01-23T14:38:10Z

Description

This PR add support for the STM32L443RC and the WISE-1510 module.
This was tested with @kivaisan on mbed-os-example-lora

Status

MERGED

Todos

Tests
Documentation

0xc0170 · 2018-01-23T14:46:49Z

targets/targets.json

@@ -1472,6 +1472,23 @@
        "release_versions": ["2", "5"],
        "device_name": "STM32L433RC",
        "bootloader_supported": true
+    },
+	"WISE_1510": {


no release version? will be added later?

I'm not sure about which revision it's aiming.
Should it be current 5.7 or next release 5.8 ?

release_versions can be 2 or 5 or both. I assume 5 should be defined here

oh, ok, I add it now.

jeromecoutant

Hi
Here is a quick review
Thx

jeromecoutant · 2018-01-24T08:30:00Z

.gitignore

@@ -72,6 +72,9 @@ debug.log
 # Cscope
 cscope.*

+# Ctags
+tags


Not related to the PR

Should be sent via separate PR

jeromecoutant · 2018-01-24T08:36:47Z

targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L443xC/device/TOOLCHAIN_ARM_STD/stm32l443xx.sct

+   .ANY (+RO)
+  }
+
+  RW_IRAM1 0x20000000 0x0000C000  { ; RW data 48k L4-SRAM1


In STM32L443, SRAM2 and SRAM1 and continuous.
You can prefer to get a bigger SRAM1. See #5171

These two ranges offer different features namely the hardware parity check and the standby retain mode on SRAM2.
In order to let the end-user free to choose to use it or not, shouldn't we rather add a special section to allow this use case and avoid the user to tweak the linker script him/herself ?

jeromecoutant · 2018-01-24T08:37:20Z

targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L443xC/device/TOOLCHAIN_GCC_ARM/STM32L443XX.ld

+{
+  FLASH (rx)   : ORIGIN = MBED_APP_START, LENGTH = MBED_APP_SIZE
+  SRAM2 (rwx)  : ORIGIN = 0x1000018C, LENGTH = 16k - 0x18C
+  SRAM1 (rwx)  : ORIGIN = 0x20000000, LENGTH = 48k


Same comment, you can increase RAM size from 48k to 64k

jeromecoutant · 2018-01-24T08:41:01Z

targets/targets.json

+            }
+        },
+        "release_versions": ["5"],
+        "device_has_add": ["ANALOGOUT", "LOWPOWERTIMER", "SERIAL_FC", "SERIAL_ASYNCH", "CAN", "TRNG", "FLASH", "AES"],


DEVICE_AES doesn't exist ?

Should it be the macro MBEDTLS_CONFIG_HW_SUPPORT instead ?

0xc0170 · 2018-01-24T12:30:50Z

Please check travis failures

ithinuel · 2018-01-26T13:16:10Z

/morph build

mbed-ci · 2018-01-26T13:36:39Z

Build : SUCCESS

Build number : 971
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5904/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2018-01-26T15:16:08Z

Exporter Build : SUCCESS

Build number : 657
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5904/

cmonr · 2018-01-29T16:20:59Z

/morph build

cmonr · 2018-01-29T16:21:32Z

@jeromecoutant Are you good with the latest commits for this PR?

jeromecoutant

Increase RAM size from 48k to 64k is optional, and can be checked later.

mbed-ci · 2018-01-29T16:53:01Z

Build : SUCCESS

Build number : 991
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5904/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2018-01-29T18:49:46Z

Exporter Build : SUCCESS

Build number : 685
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5904/

mbed-ci · 2018-01-30T00:53:17Z

Test : SUCCESS

Build number : 814
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5904/814

0xc0170 · 2018-01-30T08:56:50Z

/morph uvisor-test

0xc0170 · 2018-01-30T10:46:10Z

/morph uvisor-test

ithinuel · 2018-01-30T20:19:11Z

All green 🕺 !

mbed-ci · 2018-01-30T21:23:11Z

Exporter Build : FAILURE

Build number : 703
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5904/

cmonr · 2018-01-30T21:49:07Z

@ithinuel Not sure why the above exporter build just ran. If we need some sort of action from you, we'll let you know.

ithinuel · 2018-01-30T21:50:13Z

Ok, no problem, you know where I stand 😉

cmonr · 2018-01-30T23:00:00Z

@ithinuel It looks like this PR + #5947 + some unfortunate timing is causing the new build issues.

I'm going to move forward with the revert PR, and once it passes all of its tests, merge it in. After it's merged in, I'd like you to restore your branch, and create a new PR.

The issue appears to have been the timing that the morph build commands occurred between the two PRs.

ithinuel changed the title ~~add basic support for STM32L443RC & WISE-1510~~ add support for STM32L443RC & WISE-1510 Jan 23, 2018

0xc0170 added needs: review scope: new-target labels Jan 23, 2018

0xc0170 reviewed Jan 23, 2018

View reviewed changes

jeromecoutant reviewed Jan 24, 2018

View reviewed changes

0xc0170 added needs: work and removed needs: review labels Jan 24, 2018

add support for STM32L443RC & WISE-1510

e6b19d8

cmonr added needs: review and removed needs: work labels Jan 29, 2018

jeromecoutant approved these changes Jan 29, 2018

View reviewed changes

0xc0170 approved these changes Jan 30, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Jan 30, 2018

cmonr added the release-version: 5.7.5 label Jan 30, 2018

cmonr merged commit b87e98c into ARMmbed:master Jan 30, 2018

cmonr removed needs: CI scope: new-target labels Jan 30, 2018

ithinuel deleted the add-wise-1510 branch January 30, 2018 21:10

This was referenced Jan 30, 2018

Let libraries, targets configure bootloader #5909

Merged

Revert "add support for STM32L443RC & WISE-1510" #5977

Closed

theotherjimmy mentioned this pull request Jan 30, 2018

STM32L4 : add missing ST HAL UART functions #5947

Merged

ithinuel restored the add-wise-1510 branch January 31, 2018 00:39

ithinuel mentioned this pull request Jan 31, 2018

Wise 1510: fix a silent conflict with PR #5947 #5982

Merged

cmonr added the scope: new-target label Feb 5, 2018

add support for STM32L443RC & WISE-1510 #5904

add support for STM32L443RC & WISE-1510 #5904

Uh oh!

Conversation

ithinuel commented Jan 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Status

Todos

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeromecoutant left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ithinuel Jan 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Jan 24, 2018

Uh oh!

ithinuel commented Jan 26, 2018

Uh oh!

mbed-ci commented Jan 26, 2018

Triggering tests

Uh oh!

mbed-ci commented Jan 26, 2018

Uh oh!

cmonr commented Jan 29, 2018

Uh oh!

cmonr commented Jan 29, 2018

Uh oh!

jeromecoutant left a comment

Choose a reason for hiding this comment

Uh oh!

mbed-ci commented Jan 29, 2018

Triggering tests

Uh oh!

mbed-ci commented Jan 29, 2018

Uh oh!

mbed-ci commented Jan 30, 2018

Uh oh!

0xc0170 commented Jan 30, 2018

Uh oh!

0xc0170 commented Jan 30, 2018

Uh oh!

ithinuel commented Jan 30, 2018

Uh oh!

mbed-ci commented Jan 30, 2018

Uh oh!

cmonr commented Jan 30, 2018

Uh oh!

ithinuel commented Jan 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmonr commented Jan 30, 2018

Uh oh!

Uh oh!

ithinuel commented Jan 23, 2018 •

edited

Loading

ithinuel Jan 24, 2018 •

edited

Loading

ithinuel commented Jan 30, 2018 •

edited

Loading