-
Notifications
You must be signed in to change notification settings - Fork 3k
Wise 1510: fix a silent conflict with PR #5947 #5982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/morph build |
It's missing in the commit message how is this fixing it (what is actually in this PR, what I can guess from the actual changes, mbed added defines for this target were missing?) |
If this fixes the error, then #5977 can be closed. As soon as this gets green, will get in and the other closed |
Build : SUCCESSBuild number : 1018 Triggering tests/morph test |
I can confirm this fixes the bug ! 👍 |
Test : SUCCESSBuild number : 830 |
/morph uvisor-test |
Exporter Build : SUCCESSBuild number : 705 |
Exporter Build : FAILUREBuild number : 706 |
I've just noticed the last run, that is default target, looks like an error (the previous run is actually valid, and looks all being tested) |
Description
PR #5947 requires some additional defines.
This PR completes #5904 and fixes the latent "conflict".
Status
READY