add support for the murata's module CMWX1ZZABZ-078 based on STM32L0 #5905

ithinuel · 2018-01-23T14:51:23Z

Description

This PR add support for the STM32L082CZ and murata's CMWX1ZZABZ-078 module.
This was tested with @kivaisan on mbed-os-example-lora

Status

WORK IN PROGRESS

Related PR

Update CMSIS pack #5937

Todos

Tests
Documentation

0xc0170 · 2018-01-23T15:52:08Z

/morph build

0xc0170 · 2018-01-23T15:52:34Z

@ithinuel mbed test results from all 3 toolchains?

mbed-ci · 2018-01-23T16:16:28Z

Build : SUCCESS

Build number : 923
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5905/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

jeromecoutant

Hi
Here is a quick review :-)

jeromecoutant · 2018-01-23T16:39:37Z

.gitignore

@@ -72,6 +72,9 @@ debug.log
 # Cscope
 cscope.*

+# Ctags
+tags


not related to the PR ?

No indeed, does it need to have its own PR ?

Yes please. I know it seems small, but it helps in keeping pull requests atomic and relevant to their subject.

Feel free to reference this PR to indicate that it's related.

jeromecoutant · 2018-01-23T16:43:08Z

...ARGET_STM/TARGET_STM32L0/TARGET_STM32L0x2xB/device/TOOLCHAIN_ARM_MICRO/startup_stm32l053xx.S

@@ -0,0 +1,239 @@
+;******************** (C) COPYRIGHT 2016 STMicroelectronics ********************
+;* File Name          : startup_stm32l053xx.s


fixed (removed)

jeromecoutant · 2018-01-23T16:43:25Z

targets/TARGET_STM/TARGET_STM32L0/TARGET_STM32L0x2xB/device/TOOLCHAIN_ARM_MICRO/stm32l053x8.sct

@@ -0,0 +1,44 @@
+; Scatter-Loading Description File
+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;


fixed (removed)

jeromecoutant · 2018-01-23T16:43:46Z

targets/TARGET_STM/TARGET_STM32L0/TARGET_STM32L0x2xB/device/TOOLCHAIN_ARM_STD/stm32l053x8.sct

@@ -0,0 +1,44 @@
+; Scatter-Loading Description File
+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;


wrong file name

fixed (removed)

jeromecoutant · 2018-01-23T16:51:10Z

targets/targets.json

+        "core": "Cortex-M0+",
+        "extra_labels_add": ["STM32L0", "STM32L0x2xB", "STM32L082KB", "STM32L082xx"],
+        "detect_code": [],
+        "device_has_add": ["ANALOGOUT", "LOWPOWERTIMER", "SERIAL_FC", "SERIAL_ASYNCH", "TRNG", "FLASH"],


Add macro MBEDTLS_CONFIG_HW_SUPPORT ?

Actually not as AES driver does not support STM32L0x2 yet.

mbed-ci · 2018-01-23T19:20:27Z

Exporter Build : SUCCESS

Build number : 608
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5905/

cmonr · 2018-01-23T22:49:52Z

It's a tiny change, but holding off on another rebuild until .gitignore is restored. .gitignore change is not related to PR.

mbed-ci · 2018-01-23T23:37:08Z

Test : SUCCESS

Build number : 764
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5905/764

bcostm · 2018-01-24T09:21:50Z

I have a remark about the subfolder name TARGET_STM32L0x2xB.

You wrote in the PR description that this module is based on the STM32L082CZ MCU. So, I think it would be better to use TARGET_STM32L082xZ in order to be aligned with the other targets.

If it is a mistake and the MCU is a STM32L082CB, I would use TARGET_STM32L082xB.

ithinuel · 2018-01-24T09:35:00Z

@bcostm Actually this is intended.
This is to match the 072 & 082 as they only differ by the presence of an AES hw on the 082.
The memory range does not collide with other as they are identified by the last letter "B" of the 128K/20K range. So any target based on l072xB or L082xB within this directory share the same code.
for reference : stm32l0x2 USB line

@cmonr Ok, I remove it

@0xc0170 I couldn't run them yet as I miss the DAPLink support for this soc.

cmonr · 2018-01-24T17:27:00Z

/morph build

mbed-ci · 2018-01-24T17:46:21Z

Build : SUCCESS

Build number : 941
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5905/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2018-01-24T19:07:20Z

Exporter Build : SUCCESS

Build number : 629
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5905/

ithinuel · 2018-01-25T17:29:09Z

Update: rebase + rename from stm32l0x2xB to stm32l0x2xZ + disable LOWPOWERTIM as some tests were not passing.

compiler	result
GCC	✔
ARMC6	✔
ARMC5	I cannot test
IAR	I cannot test

jeromecoutant · 2018-01-26T08:19:47Z

Hi

Just a comment on:

disable LOWPOWERTIM as some tests were not passing

I think disabling LPT for a Lora board doesn't have any sense...
System clock is using HSI which is a low precise clock, timers are then not precise, and tests become FAIL...

ithinuel · 2018-01-26T08:38:20Z

@jeromecoutant Enabling LPT actually requires LSE/LSI and I couldn't get tests to pass with them.
Couldn't this be part of a further issue/pr ?

jeromecoutant · 2018-01-26T08:53:21Z

Enabling LPT actually requires LSE/LSI and I couldn't get tests to pass with them.

Yes, LPT is using LSE from Murata module.
System timer is using HSI from STM32 chip (tests are using system timer to check lp timer).

Couldn't this be part of a further issue/pr ?

It is up to you, it's your board :-)

ithinuel · 2018-01-26T11:34:23Z

This PR needs #5937

mbed-ci · 2018-01-26T15:08:41Z

Build : SUCCESS

Build number : 974
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5905/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2018-01-26T17:12:41Z

Exporter Build : FAILURE

Build number : 660
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5905/

cmonr · 2018-01-26T18:09:56Z

@ithinuel In that case, can you rebase this PR so we can rebuild?

ithinuel · 2018-01-26T19:12:06Z

@cmonr It is already rebased & built but it seems I still have issue with the exporter of uvision.

cmonr · 2018-01-26T21:02:51Z

@ithinuel Looks like this is an issue on our side.

cmonr · 2018-01-26T23:35:18Z

/morph export-build

mbed-ci · 2018-01-27T01:13:28Z

Exporter Build : FAILURE

Build number : 672
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5905/

0xc0170 · 2018-01-29T12:26:49Z

@ithinuel Looks like this is an issue on our side.

@studavekar Can you please check the latest exporters failure here?

cmonr · 2018-01-29T20:13:10Z

@ithinuel, we're currently working to resolve this on our side.

Once it's resolved, we'll relaunch the export build.

studavekar · 2018-01-29T21:18:31Z

@cmonr @0xc0170 can you please provide the link to cmsis pack which needs to be installed?

studavekar · 2018-01-29T23:13:33Z

Thanks, @cmonr. Have installed required pack for CMWX1ZZABZ

/morph export-build

mbed-ci · 2018-01-30T01:31:48Z

Exporter Build : SUCCESS

Build number : 695
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5905/

0xc0170 · 2018-01-30T10:47:24Z

/morph test

mbed-ci · 2018-01-30T23:29:51Z

Test : SUCCESS

Build number : 827
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5905/827

0xc0170 added needs: review scope: new-target labels Jan 23, 2018

0xc0170 approved these changes Jan 23, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Jan 23, 2018

jeromecoutant reviewed Jan 23, 2018

View reviewed changes

cmonr added needs: work and removed needs: CI labels Jan 23, 2018

add support for the murata's module based on STM32L0

f8e88d7

cmonr added needs: CI and removed needs: work labels Jan 26, 2018

cmonr added needs: work and removed needs: CI labels Jan 26, 2018

0xc0170 added ready for merge and removed needs: work labels Jan 31, 2018

cmonr added the release-version: 5.7.5 label Jan 31, 2018

cmonr merged commit 097966b into ARMmbed:master Jan 31, 2018

cmonr removed the ready for merge label Jan 31, 2018

ithinuel deleted the add-CMWX1ZZABZ-078-support branch January 31, 2018 18:55

factoryal mentioned this pull request May 24, 2021

Add support for Murata Type ABZ (CMWX1ZZABZ-078) #14695

Closed

		@@ -0,0 +1,239 @@
		;****************** (C) COPYRIGHT 2016 STMicroelectronics ******************
		;* File Name : startup_stm32l053xx.s

		@@ -0,0 +1,44 @@
		; Scatter-Loading Description File
		;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

add support for the murata's module CMWX1ZZABZ-078 based on STM32L0 #5905

add support for the murata's module CMWX1ZZABZ-078 based on STM32L0 #5905

Conversation

ithinuel commented Jan 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Status

Related PR

Todos

Uh oh!

0xc0170 commented Jan 23, 2018

Uh oh!

0xc0170 commented Jan 23, 2018

Uh oh!

mbed-ci commented Jan 23, 2018

Triggering tests

Uh oh!

jeromecoutant left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmonr Jan 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mbed-ci commented Jan 23, 2018

Uh oh!

cmonr commented Jan 23, 2018

Uh oh!

mbed-ci commented Jan 23, 2018

Uh oh!

bcostm commented Jan 24, 2018

Uh oh!

ithinuel commented Jan 24, 2018

Uh oh!

cmonr commented Jan 24, 2018

Uh oh!

mbed-ci commented Jan 24, 2018

Triggering tests

Uh oh!

mbed-ci commented Jan 24, 2018

Uh oh!

ithinuel commented Jan 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jeromecoutant commented Jan 26, 2018

Uh oh!

ithinuel commented Jan 26, 2018

Uh oh!

jeromecoutant commented Jan 26, 2018

Uh oh!

ithinuel commented Jan 26, 2018

Uh oh!

mbed-ci commented Jan 26, 2018

Triggering tests

Uh oh!

mbed-ci commented Jan 26, 2018

ithinuel commented Jan 23, 2018 •

edited

Loading

cmonr Jan 23, 2018 •

edited

Loading

ithinuel commented Jan 25, 2018 •

edited

Loading

cmonr commented Jan 26, 2018 •

edited

Loading

cmonr commented Jan 26, 2018 •

edited

Loading