CriticalSectionLock: fixing missing include

[MikeDK]

Description

Macro MBED_DEPRECATED_SINCE is defined in platform/mbed_toolchain.h which was not included.
If someone used member functions lock or unlock (which are prefixed with MBED_DEPRECATED_SINCE since some time), there would be a compile error instead of a warning.
Including mbed_toolchain.h fixes that.

Status

READY

Steps to test or reproduce

Use CriticalSectionLock.lock() in a cpp file where CriticalSectionLock.h is included before mbed.h - compile error will occur.

[mbed-ci]

Automatic CI verification build not done, please verify manually.

[0xc0170]

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 927
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5912/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

[mbed-ci]

Exporter Build : SUCCESS

Build number : 615
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5912/

[mbed-ci]

Test : FAILURE

Build number : 767
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5912/767

[MikeDK]

seems like some test hardware failed to sync

[MikeDK]

Am I able to trigger the tests? Or do only members have the permissions to do the /morph build ? :)

[MikeDK]

/morph build

[MikeDK]

Ok, I answered the question to myself :P

[0xc0170]

Ok, I answered the question to myself :P

We will retrigger CI, there is known issue with one device (not related to this PR), fix is already under tests

[MikeDK]

yeah I experience the same issue here with my NUCLEO-F746ZG board ... It is stuck somewhere before entering my application code.
When I revert the commit 4c07c1c (Merge pull request #5821 from bcostm/add_BL_nucleo-f746zg), everything works again.

As I own such a board - can I be of any help fixing the issue? ;)

[0xc0170]

As I own such a board - can I be of any help fixing the issue? ;)

Any help appreciated 👍 Thanks for confirming the issue !
We currently have a revert under test #5927, and the addition needs to be retested and fixed

[MikeDK]

I already found that revert and tested it ... just to realize it only reverts the changes for NUCLEO_F767ZI ... but the issue is also present on the NUCLEO_F746ZG (which I own)

[0xc0170]

@MikeDK Correct, F7 cache settings needs to be reverted, here #5932

[MikeDK]

Ok I just tested #5932, and I can confirm that it fixes the problem

[0xc0170]

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 947
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5912/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

[mbed-ci]

Test : SUCCESS

Build number : 778
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5912/778

[mbed-ci]

Exporter Build : SUCCESS

Build number : 635
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5912/