Skip to content

allow use of external memory as heap with TOOLCHAIN_GCC_ARM #5994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

bmcdonnell-ionx
Copy link
Contributor

@bmcdonnell-ionx bmcdonnell-ionx commented Feb 1, 2018

This PR addresses #5638. It allows the user to optionally (with the right additional software) use external memory for all dynamic memory with TOOLCHAIN_GCC_ARM, by allowing the user to override the _sbrk() function defined in platform/mbed_retarget.cpp.

For example, when using the Embedded Artists' LPC4088 QuickStart Board with EALib's SDRAM module (cpp, h) and the Mbed online compiler (and Keil uVision offline IDE, I presume), dynamic memory uses the off-chip on-board 32 MB SDRAM. I assume there are other boards that can support this behavior too, but this is the one I know of for sure. This PR makes this behavior the same on TOOLCHAIN_GCC_ARM.

@mbed-ci
Copy link

mbed-ci commented Feb 1, 2018

User not whitelisted, CI not run.

@cmonr cmonr added the needs: CI label Feb 1, 2018
@cmonr
Copy link
Contributor

cmonr commented Feb 1, 2018

/morph build

2 similar comments
@cmonr
Copy link
Contributor

cmonr commented Feb 1, 2018

/morph build

@studavekar
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 1, 2018

Build : SUCCESS

Build number : 1045
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5994/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Feb 2, 2018

@mbed-ci
Copy link

mbed-ci commented Feb 2, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 2, 2018

@bmcdonnell-ionx bmcdonnell-ionx deleted the gcc-arm-extram branch August 2, 2018 14:19
@bmcdonnell-ionx
Copy link
Contributor Author

I just edited a typo in the OP here, and for some reason the CI did whatever it just did above.

🤷

@cmonr
Copy link
Contributor

cmonr commented Aug 2, 2018

@bmcdonnell-ionx Yeah, it's a known ghost in the machine that happens every once in a while, but considering how fast it fails and that it doesn't impact anything else in CI, it's a low priority fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants