-
Notifications
You must be signed in to change notification settings - Fork 3k
allow use of external memory as heap with TOOLCHAIN_GCC_ARM #5994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…always use external memory
User not whitelisted, CI not run. |
/morph build |
2 similar comments
/morph build |
/morph build |
Build : SUCCESSBuild number : 1045 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 726 |
Test : SUCCESSBuild number : 853 |
Exporter Build : FAILUREBuild number : 2361 |
I just edited a typo in the OP here, and for some reason the CI did whatever it just did above. 🤷 |
@bmcdonnell-ionx Yeah, it's a known ghost in the machine that happens every once in a while, but considering how fast it fails and that it doesn't impact anything else in CI, it's a low priority fix. |
This PR addresses #5638. It allows the user to optionally (with the right additional software) use external memory for all dynamic memory with
TOOLCHAIN_GCC_ARM
, by allowing the user to override the_sbrk()
function defined inplatform/mbed_retarget.cpp
.For example, when using the Embedded Artists' LPC4088 QuickStart Board with EALib's SDRAM module (cpp, h) and the Mbed online compiler (and Keil uVision offline IDE, I presume), dynamic memory uses the off-chip on-board 32 MB SDRAM. I assume there are other boards that can support this behavior too, but this is the one I know of for sure. This PR makes this behavior the same on
TOOLCHAIN_GCC_ARM
.