Skip to content

Nuvoton: Replace __wrap__sbrk with overriding _sbrk #7603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2018
Merged

Nuvoton: Replace __wrap__sbrk with overriding _sbrk #7603

merged 1 commit into from
Jul 26, 2018

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Jul 26, 2018

Description

With _sbrk being weak (#5994), this PR replaces __wrap__sbrk with overriding _sbrk to support heap with two-region model on Nuvoton targets.

Pull request type

[ ] Fix
[X] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@ccli8
[Nuvoton] Replace __wrap__sbrk with overriding _sbrk
313f322 
With _sbrk being weak, we can override it directly rather than #if to support heap with
two-region model.
@0xc0170 0xc0170 requested a review from a team July 26, 2018 10:22
@cmonr
Copy link
Contributor

cmonr commented Jul 26, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 26, 2018

Build : SUCCESS

Build number : 2676
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7603/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 26, 2018

Exporter Build : SUCCESS

Build number : 2312
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7603/

@mbed-ci
Copy link

mbed-ci commented Jul 26, 2018

Test : SUCCESS

Build number : 2414
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7603/2414

@cmonr cmonr merged commit cc506ee into ARMmbed:master Jul 26, 2018
@0xc0170 0xc0170 removed the needs: CI label Jul 26, 2018
@ccli8 ccli8 deleted the nuvoton_override_gcc_sbrk branch July 27, 2018 01:13
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Merge pull request ARMmbed#7603 from OpenNuvoton/nuvoton_override_gcc…
5c7ca15 
…_sbrk

Nuvoton: Replace __wrap__sbrk with overriding _sbrk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ccli8 @cmonr @mbed-ci @0xc0170