Nuvoton: Rework us_ticker and lp_ticker #6048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rework includes the following: 1. Remove ticker overflow handling because upper layer (mbed_ticker_api.c) has done with it. This makes us_ticker/lp_ticker implementation more succinct and avoids potential error. 2. Refine timer register access with low-power clock source
|
Can you share test results for tickers ? |
Target: NUMAKER_PFM_NUC472Toolchain: ARMToolchain: GCC_ARMToolchain: IAR |
Target: NUMAKER_PFM_M453Toolchain: ARMToolchain: GCC_ARMToolchain: IAR |
Target: NUMAKER_PFM_M487Toolchain: ARMToolchain: GCC_ARMToolchain: IAR |
Target: NUMAKER_PFM_NANO130Toolchain: ARMToolchain: GCC_ARMToolchain: IAR |
0xc0170
reviewed
Feb 12, 2018
| * |-------------------alarm_intvl1_clk-------------------| | ||
| * |-alarm_intvl2_clk-| | ||
| * | ||
| * Unfortunately, `tick_last_read` is not passed along the xx_ticker_set_interrupt() call. To solve it, we |
There was a problem hiding this comment.
shouldnt this work without storing the last read? There should not be any event in the past when set_interrupt is called (processed via different branch in the upper layer) ?
There was a problem hiding this comment.
@0xc0170 Assume at t1, upper layer calls us_ticker_read and has handled all past events; at t2, upper layer calls us_ticker_set_interrupt to schedule future event (timestamp) relative to t1. There is very low possibility that future event (timestamp) relative to t1 becomes past event (timestamp) relative to t2. But for robustness, I need the last read (t1) as a reference point to distinguish the order of t1, t2, and timestamp in timeline and then to distinguish timestamp is a future or past event.
|
/morph build |
Build : SUCCESSBuild number : 1156 Triggering tests/morph test |
0xc0170
approved these changes
Feb 16, 2018
Exporter Build : SUCCESSBuild number : 830 |
Test : SUCCESSBuild number : 961 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes rework on us_ticker/lp_ticker. Because upper layer (hal/mbed_ticker_api.c) has addressed ticker frequency/bit size/some wrap-around issues, us_ticker/lp_ticker are reworked to make code more concise and reasonable.
It update the following Nuvoton targets:
Related PRs
#6028