Nuvoton: Rework us_ticker, lp_ticker and RTC #6028
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rework includes the following: 1. Remove ticker overflow handling because upper layer (mbed_ticker_api.c) has done with it. This makes us_ticker/lp_ticker implementation more succinct and avoids potential error. 2. Refine timer register access with low-power clock source
The rework includes the following: 1. Support year range beyond H/W RTC 2000~2099. 2. Refine RTC register access with low-power clock source
0xc0170
reviewed
Feb 7, 2018
| TIMER_EnableInt(timer3_base); | ||
| TIMER_EnableWakeup((TIMER_T *) NU_MODBASE(timer3_modinit.modname)); | ||
| /* NOTE: When engine is clocked by low power clock source (LXT/LIRC), we need to wait for 3 engine clocks. */ |
There was a problem hiding this comment.
@0xc0170 It means just the Timer H/W. For power-saving consideration, H/W is so designed. When its clock source is low power oscillator (LXT/LIRC), wait cycles are needed to avoid the programming pitfall.
|
Can you split this to two PR? RTC and another one us/lp ticker changes? |
@0xc0170 OK. I will split this PR into two. |
This was referenced Feb 9, 2018
Merged
|
Thanks, we will review them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates for all Nuvoton targets:
It has the following updates:
hal/mbed_ticker_api.c) has addressed ticker frequency/bit size/some wrap-around issues, us_ticker/lp_ticker are reworked to make code more concise and reasonable.time/set_timerequires POSIX time which starts from 1970. The rework fixes it by using H/W RTC to keep elapsed time since some time point rather than real date time.