Pull request template update #6078

0xc0170 · 2018-02-13T12:22:36Z

This is the new template proposal below, please review. The idea here is to have 2 sections that needs to be filled in (description and pull request (PR) type).

Note: workflow url should be updated to point to a good PR example (@AnotherButler Can you help to get that url to a specific section? We will create new PR to handbook shortly, will be referenced in this PR).

Description

Detailed changes summary | testing | dependencies
Good example: https://os.mbed.com/docs/latest/reference/guidelines.html#workflow

Pull request type

Fix
Refactor
New Target
Feature

adbridge

LGTM

theotherjimmy

Sure. Maybe more people will fill it out if it's shorter.

cmonr

Non-blocking comment/question. LGTM.

cmonr · 2018-02-13T16:35:32Z

.github/pull_request_template.md


-## Description
+> Detailed changes summary | testing | dependencies
+> Good example: https://os.mbed.com/docs/latest/reference/guidelines.html#workflow


Is this meant to point to an example bug/issue/PR?

Yes, my comment above:

Note: workflow url should be updated to point to a good PR example (@AnotherButler Can you help to get that url to a specific section? We will create new PR to handbook shortly, will be referenced in this PR).

I'll attach here the PR addition that gives a good example

@AnotherButler the workflow PR template was merged, when it is published so I can edit the line 4 (update url to point to it) ? Or is it fine with link as it is ? This is the last blocking part for this PR

I noticed Pull request template is already in the docs, but I do not see any anchor that I could add here. Is workflow enough (users need to scroll a bit to get the info we would like to)

0xc0170 · 2018-02-15T08:08:41Z

Waiting on ARMmbed/mbed-os-5-docs#411 to be integrated, will update the url here to point to that. please review it (to have a good example how PR description should look like)

0xc0170 · 2018-02-16T14:23:22Z

@AnotherButler Please review

AnotherButler

Nice work on this 👍

0xc0170 · 2018-02-20T16:01:04Z

/morph build

New version of the PR template. Ideal PR should contain: - detailed description of changes - how it was tested - dependencies - PR type (one of)

0xc0170 · 2018-02-20T16:03:31Z

Ready now, I fixed the link (added there a comment about (Pull request template)).

/morph build

mbed-ci · 2018-02-20T16:33:17Z

Build : SUCCESS

Build number : 1185
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6078/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-02-20T16:45:24Z

Build : SUCCESS

Build number : 1186
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6078/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-02-20T17:42:35Z

Test : FAILURE

Build number : 987
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6078/987

mbed-ci · 2018-02-20T17:46:20Z

Test : FAILURE

Build number : 988
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6078/988

cmonr · 2018-02-20T17:51:30Z

/morph test

mbed-ci · 2018-02-20T18:30:35Z

Exporter Build : SUCCESS

Build number : 862
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6078/

mbed-ci · 2018-02-20T18:30:37Z

Exporter Build : SUCCESS

Build number : 862
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6078/

cmonr · 2018-02-20T19:30:48Z

/morph test

mbed-ci · 2018-02-20T21:04:48Z

Test : FAILURE

Build number : 992
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6078/992

0xc0170 · 2018-02-21T08:07:39Z

/morph test

mbed-ci · 2018-02-21T08:11:42Z

Test : FAILURE

Build number : 994
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6078/994

0xc0170 · 2018-02-21T12:28:45Z

/morph build

mbed-ci · 2018-02-21T12:58:23Z

Build : SUCCESS

Build number : 1198
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6078/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-02-21T14:08:01Z

Exporter Build : SUCCESS

Build number : 870
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6078/

mbed-ci · 2018-02-21T15:46:17Z

Test : SUCCESS

Build number : 1000
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6078/1000

0xc0170 added the needs: review label Feb 13, 2018

0xc0170 requested review from cmonr, sg-, theotherjimmy and adbridge February 13, 2018 12:23

0xc0170 force-pushed the dev_template_pr branch from b83fde9 to 8af2736 Compare February 13, 2018 12:25

adbridge approved these changes Feb 13, 2018

View reviewed changes

theotherjimmy approved these changes Feb 13, 2018

View reviewed changes

cmonr approved these changes Feb 13, 2018

View reviewed changes

0xc0170 mentioned this pull request Feb 14, 2018

PR template addition ARMmbed/mbed-os-5-docs#411

Merged

0xc0170 added the needs: preceding PR label Feb 15, 2018

0xc0170 requested a review from AnotherButler February 16, 2018 14:23

AnotherButler approved these changes Feb 16, 2018

View reviewed changes

sg- approved these changes Feb 19, 2018

View reviewed changes

0xc0170 removed the needs: preceding PR label Feb 19, 2018

Pull request template update

775a1fb

New version of the PR template. Ideal PR should contain: - detailed description of changes - how it was tested - dependencies - PR type (one of)

0xc0170 force-pushed the dev_template_pr branch from 8af2736 to 775a1fb Compare February 20, 2018 16:02

0xc0170 added needs: CI and removed needs: review labels Feb 20, 2018

0xc0170 mentioned this pull request Feb 21, 2018

Correct single file excludes for some exporters #6145

Merged

cmonr added ready for merge release-version: 5.7.6 and removed needs: CI labels Feb 21, 2018

0xc0170 merged commit c32b822 into ARMmbed:master Feb 22, 2018

0xc0170 removed the ready for merge label Feb 22, 2018

Pull request template update #6078

Pull request template update #6078

Uh oh!

Conversation

0xc0170 commented Feb 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Uh oh!

adbridge left a comment

Choose a reason for hiding this comment

Uh oh!

theotherjimmy left a comment

Choose a reason for hiding this comment

Uh oh!

cmonr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 Feb 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Feb 15, 2018

Uh oh!

0xc0170 commented Feb 16, 2018

Uh oh!

AnotherButler left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Feb 20, 2018

Uh oh!

0xc0170 commented Feb 20, 2018

Uh oh!

mbed-ci commented Feb 20, 2018

Triggering tests

Uh oh!

mbed-ci commented Feb 20, 2018

Triggering tests

Uh oh!

mbed-ci commented Feb 20, 2018

Uh oh!

mbed-ci commented Feb 20, 2018

Uh oh!

cmonr commented Feb 20, 2018

Uh oh!

mbed-ci commented Feb 20, 2018

Uh oh!

mbed-ci commented Feb 20, 2018

Uh oh!

cmonr commented Feb 20, 2018

Uh oh!

mbed-ci commented Feb 20, 2018

Uh oh!

0xc0170 commented Feb 21, 2018

Uh oh!

mbed-ci commented Feb 21, 2018

Uh oh!

0xc0170 commented Feb 21, 2018

Uh oh!

mbed-ci commented Feb 21, 2018

Triggering tests

Uh oh!

mbed-ci commented Feb 21, 2018

Uh oh!

mbed-ci commented Feb 21, 2018

Uh oh!

Uh oh!

0xc0170 commented Feb 13, 2018 •

edited

Loading

0xc0170 Feb 14, 2018 •

edited

Loading