Skip to content

Correct single file excludes for some exporters #6145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2018

Conversation

theotherjimmy
Copy link
Contributor

Resolves #6060

@theotherjimmy
Copy link
Contributor Author

/morph build

@theotherjimmy theotherjimmy force-pushed the exclude-file-gnuarmeclipse branch from 941b0a7 to 166a463 Compare February 20, 2018 18:09
@mbed-ci
Copy link

mbed-ci commented Feb 20, 2018

Build : SUCCESS

Build number : 1190
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6145/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@JojoS62
Copy link
Contributor

JojoS62 commented Feb 20, 2018

@theotherjimmy as you're working on the exporters, I'm checking if this is reported already: the gnuarmeclipse creates unnecessary include file entries in the .cproject for a lot of Feature/... directories. For the target -m BLUEPILL_F103C8 for example for lorawan, mbedtls, nanostack and more. Are these features default? In the target.json they are not defined for this target, how is it determined which features to add?

@theotherjimmy
Copy link
Contributor Author

Are these features default?

Yes.

In the target.json they are not defined for this target, how is it determined which features to add?

They need to be behind FEATURE_ directories to be "disableable".

@mbed-ci
Copy link

mbed-ci commented Feb 20, 2018

@cmonr
Copy link
Contributor

cmonr commented Feb 20, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Feb 20, 2018

@mbed-ci
Copy link

mbed-ci commented Feb 20, 2018

@studavekar
Copy link
Contributor

Test : FAILURE
Build number : 993
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6145/993

Build was tagged with SHA 941b0a70d971d9dd22fb3f7b012ab3b7a2397ade , however tests are looking for 166a463

@cmonr any idea ?

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 21, 2018

@studavekar Seems similar to #6078 (comment) ? Where can I obtain sha as you did ?

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 21, 2018

Seems like first build was before the last commit, rerunning.

@studavekar Shall this be fixed (kill any running job for the PR if we run again) ?

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 21, 2018

Build : SUCCESS

Build number : 1202
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6145/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Feb 21, 2018

@mbed-ci
Copy link

mbed-ci commented Feb 21, 2018

@cmonr
Copy link
Contributor

cmonr commented Feb 21, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Feb 22, 2018

@cmonr cmonr merged commit d9cb00d into ARMmbed:master Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants