Skip to content

LPC546XX: Add support for 220MHz core speed available on LPC54628 #6147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2018

Conversation

mmahadevan108
Copy link
Contributor

Read the part ID at bootup and increase core speed to 220MHz on LPC54628

Status

**READY

@mmahadevan108
Copy link
Contributor Author

cc @0xc0170 @maclobdell @gorazdko

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 21, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 21, 2018

Build : SUCCESS

Build number : 1197
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6147/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Feb 21, 2018

@mmahadevan108 mmahadevan108 force-pushed the Increase_Speed_LPC54628 branch from 453f217 to 668e124 Compare February 21, 2018 13:32
@mmahadevan108
Copy link
Contributor Author

I have pushed in an update to fix the Exporter BUILD Failure.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 21, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 21, 2018

Build : SUCCESS

Build number : 1199
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6147/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 21, 2018

/morph uvisor-test

@gorazdko
Copy link
Contributor

@mmahadevan108 Can you cherry pick also

gorazdko@da46ce7

If the line is present the wait() function takes longer when adc enabled. What do you think?

@mbed-ci
Copy link

mbed-ci commented Feb 21, 2018

@mmahadevan108
Copy link
Contributor Author

@gorazdko Can you provide details on why this change is required?

@mmahadevan108
Copy link
Contributor Author

@0xc0170 I am not clear why mbed-ci is failing

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 21, 2018

We will review the logs (seems based on the info I am seeing to me that this is CI failure but need to confirm).

@mbed-ci
Copy link

mbed-ci commented Feb 21, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 21, 2018

I missed that you pushed an update we run CI, restarting

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 21, 2018

Build : SUCCESS

Build number : 1205
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6147/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Feb 21, 2018

@mmahadevan108
Copy link
Contributor Author

@gorazdko I understand your change. Can you please submit a separate PR for your change. Thanks.

@gorazdko
Copy link
Contributor

@mmahadevan108 Ok I will. I will change this at 546xx and 54114

@mmahadevan108
Copy link
Contributor Author

@gorazdko Thank you.

@mbed-ci
Copy link

mbed-ci commented Feb 21, 2018

@mmahadevan108
Copy link
Contributor Author

@0xc0170 I don't see this failure reported by mbed-ci. I am using

 IAR Command Line Build Utility V8.0.11.5069
 Copyright 2002-2017 IAR Systems AB.

mbed-ci is using

 IAR Command Line Build Utility V7.5.6.4719
 Copyright 2002-2017 IAR Systems AB.

Can you help update and try.

@gorazdko
Copy link
Contributor

@0xc0170 I see the "release_versions" in targets.json should be placed inside children afterall since now the parent (MCU_LPC546XX) is treated as a target. Will correct this next time. Hope this is not causing problems now.
screenshot from 2018-02-21 20-03-31

@cmonr
Copy link
Contributor

cmonr commented Feb 21, 2018

@mmahadevan108, it looks like the difference between our build tools is that you're building using v8 of IAR. At the moment, mbed-os and its tools do not support v8.

@mmahadevan108
Copy link
Contributor Author

@cmonr How do you suggest we proceed?

@cmonr
Copy link
Contributor

cmonr commented Feb 21, 2018

@mmahadevan108 Is the LPC54628J512 only supported in IAR 8?

@mmahadevan108
Copy link
Contributor Author

Here is what I see in IAR release notes:

Device | Released
LPC54628J512 | 8.11.3

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 22, 2018

This has to wait for IAR update 8. If this is the case, exporting should not be enabled

@mmahadevan108 mmahadevan108 force-pushed the Increase_Speed_LPC54628 branch from 668e124 to 069c80b Compare February 22, 2018 13:35
@mmahadevan108
Copy link
Contributor Author

@0xc0170 @cmonr I have backed off the IAR change.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 22, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 22, 2018

Build : SUCCESS

Build number : 1221
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6147/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Feb 22, 2018

@mbed-ci
Copy link

mbed-ci commented Feb 22, 2018

@cmonr cmonr merged commit bf2f24f into ARMmbed:master Feb 23, 2018
@mmahadevan108 mmahadevan108 deleted the Increase_Speed_LPC54628 branch February 23, 2018 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants