Skip to content

Update mbed-coap to version 4.3.0 #6171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2018
Merged

Conversation

anttiylitokola
Copy link
Contributor

@anttiylitokola anttiylitokola commented Feb 22, 2018

Description

Add new API to clear whole sent blockwise message list.

Pull request type

  • Fix
  • Refactor
  • New Target
  • Feature

Add new api to clear whole sent blockwise message list
@anttiylitokola
Copy link
Contributor Author

@yogpan01 something to review.

@cmonr
Copy link
Contributor

cmonr commented Mar 6, 2018

Wawiting on review from @yogpan01, but will start build now.

/morph build

@cmonr
Copy link
Contributor

cmonr commented Mar 6, 2018

@0xc0170 Dunno why, but gonna need you to start morph...

@studavekar fyi.

@yogpan01
Copy link
Contributor

yogpan01 commented Mar 6, 2018

@0xc0170 Can this be taken into one of the mbedOS 5.8 Release candidates ?

@studavekar
Copy link
Contributor

/morph build

@studavekar
Copy link
Contributor

@cmonr did something changed with ur gitbub account by any chance ?

@cmonr
Copy link
Contributor

cmonr commented Mar 6, 2018

@studavekar Not that I'm aware of. Still part of the same groups.

@yogpan01 @adbridge Would be the one to make that final call, but as a rule of thumb, the only PRs that should make it into an Release Candidate after RC1 has been made are bug fixes to the Release Candidate.

@adbridge
Copy link
Contributor

adbridge commented Mar 6, 2018

@yogpan01 I'm afraid this has missed the boat for mbed-os 5.8 and this looks like it is adding a new API which means it will need to wait until 5.9. @cmonr was correct in his assertion above. Feel free to plead your case to @sg- or @ChiefBureaucraticOfficer once the first release candidate is cut we should not be taking any new code.

@mbed-ci
Copy link

mbed-ci commented Mar 6, 2018

Build : SUCCESS

Build number : 1362
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6171/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 6, 2018

@mbed-ci
Copy link

mbed-ci commented Mar 6, 2018

@yogpan01
Copy link
Contributor

@adbridge @0xc0170 Please refer to my comment on here #6357 (comment)
This comment is valid also for any mbed-coap commits. These are internal changes and have no impact on any mbedOS API beahviour since they are used by Client for its own purpose. We ensure that these are backward compatible with each release (it has been backward compatible for last 2 years) and we provide promise for not changing API in breaking way otherwise it will go to Major release of mbedOS , we follow semantic versioning there. To get minor release of this library into mbedOS shouldn't have to wait for major release , the cycle is too long for client.
Hence, please take this one also for 5.8.1 candidate.

@adbridge
Copy link
Contributor

@yogpan01 We will take 4.3 and 4.4 into 5.8.1, however please be aware of the following:
Adding a new feature / API that is available to users go to minor releases irrespective of backward compatibility. We will soon update our guidelines on what each of the checkbox options mean and exactly what can and cannot be taken to a patch release. That, along with your help to ensure things are marked correctly will help to ensure a smoother flow going forward.

@mbed-ci
Copy link

mbed-ci commented Mar 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants