-
Notifications
You must be signed in to change notification settings - Fork 3k
Update mbed-coap to version 4.4.0 #6357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Make sn_coap_protocol_send_rst as public needed for CoAP ping sending Allow disabling resendings by defining SN_COAP_DISABLE_RESENDINGS
@yogpan01, @TeroJaasko please review. |
@0xc0170, can you push this one into 5.8 release? We need to get this in to replace TCP keepalive socket option which might not be part of every socket implementation. |
looks good. We need this feature to fix critical client error where it keeps dropping connection because there is no CoAP ping functionality to keep the connection alive. |
/morph build |
Looking at the changes, it adds new API, by default this would be marked for 5.9 |
@0xc0170 These are internal changes required for cloud client. This has no direct relevance to any mbed-os functionality. This is C API anyway which we use internally to fix our keep alive logic which is completely cloud client internal logic. Because coap happens to be part of mbed-os and we need to extend this functionality there. You need to take exception for Cloud Client components to allow them to add extensions to their features. |
Labeled as such, thanks for the further information. |
Build : SUCCESSBuild number : 1485 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1130 |
Test : SUCCESSBuild number : 1272 |
This sits on top of coap 4.3 which is going to 5.9, so this also needs to go to 5.9! |
@yogpan01 if this contains a specific fix that is unrelated to the 4.3 coap release and needs to go to 5.8, then please create a PR again directly to that branch. We also need to revisit how this flow is working as it keeps breaking our release process... |
@adbridge I dont get it how it breaks your release process ? I already provided explaination that these are internal API changes needed for client only, Also, these are C APIs only so according to mbedOS backward compatibility promise, this is not an issue for any customer as they don't see these directly. |
Description
Make sn_coap_protocol_send_rst as public needed for CoAP ping sending
Allow disabling resendings by defining SN_COAP_DISABLE_RESENDINGS
Pull request type