Update for VK_RZ_A1H #6245

mbedNoobNinja · 2018-03-01T14:28:51Z

Description

Platform VK_RZ_A1H synced with mbed-os 5.7.6

Test Rezults:
VK_RZ_A1H_ARM_TESTs.log
VK_RZ_A1H_GCC_TESTs.log
VK_RZ_A1H_IAR_TESTs.log

Pull request type

Fix

cmonr · 2018-03-01T21:38:07Z

@TomoYamanaka, if you could also take a look at this PR, that would be great.

cmonr · 2018-03-01T21:54:39Z

@mbedNoobNinja It looks like there were a lot of changes that went into this PR. Could you clarify what you mean by "synced with mbed-os 5.7.6"?

mbedNoobNinja · 2018-03-02T07:35:02Z

I mean after a bug was introduced in issue № (#5777), this is the supposed fix that should resolve that issue. In short the last working mbed-os for the platform VK_RZ_A1H was 5.4.7 and there was no Cortex A9 support then. But since the maintenance is already a fact with 5.6.0, and there were some drastic changes in folder's structure as whole (#4440) and so on, ... update was needed. Now VK_RZ_A1H is "aligned" with GR_PEACH (RZ_A1H) & GR_LYCHEE (RZ_A1LU) and VK_RZ_A1H should be compilable with 5.6.x and above.

bulislaw

Could you extend the commit message, and describe what's actually going on. Something like in your last comment. Also you are adding release_version: [2, 5] to VK_RZ_A1H so that's a basically new board support as it was not active before.

bulislaw · 2018-03-02T10:52:46Z

targets/TARGET_RENESAS/TARGET_RZ_A1XX/TARGET_VK_RZ_A1H/device.h

@@ -31,6 +31,7 @@



+#define TRANSACTION_QUEUE_SIZE_SPI 16


Can you delete the unnecessary empty lines.

cmonr · 2018-03-05T16:31:30Z

@ashok-rao

cmonr · 2018-03-05T16:32:03Z

@bulislaw Is the updated commit message a bit better?

TomoYamanaka · 2018-03-07T05:09:41Z

@TomoYamanaka, if you could also take a look at this PR, that would be great.

Sorry for late reply. I think that it is okay regarding the changed code.

0xc0170 · 2018-03-07T18:22:24Z

After I read the referenced issue above (#5777) that I created earlier, I understand the changes here. This target was disabled as it was out of sync with other Renesas targets. This PR is updating the codebase, aligning it with the rest of the targets and thus reenabling it back to 2 and 5 (thus that release version).

@mbedNoobNinja it's always good to describe briefly at least changes even if reference is provided (that came later ,thanks!). Can you amend you commit message to contain these details? What update is it -

I mean after a bug was introduced in issue № (#5777), this is the supposed fix that should resolve that issue. In short the last working mbed-os for the platform VK_RZ_A1H was 5.4.7 and there was no Cortex A9 support then. But since the maintenance is already a fact with 5.6.0, and there were some drastic changes in folder's structure as whole (#4440) and so on, ... update was needed. Now VK_RZ_A1H is "aligned" with GR_PEACH (RZ_A1H) & GR_LYCHEE (RZ_A1LU) and VK_RZ_A1H should be compilable with 5.6.x and above.

This info is crucial here

mbedNoobNinja · 2018-03-08T09:25:09Z

Yeah. The commit message became a little longer ...

0xc0170 · 2018-03-08T11:28:58Z

Yeah. The commit message became a little longer ...

That is why there is a commit message, can be few paragraphs long if it needs to be. I find it now more clear (note that first line should be the most 50 characters, as you can see how it wraps here).

0xc0170 · 2018-03-08T11:31:37Z

@mbedNoobNinja Looking at the test results, some of the networking tests fail? Can you please clarify.

mbedNoobNinja · 2018-03-08T12:51:30Z

Yes, the Ethernet functions very well, ( at least the sockets -> I managed to receive video RTSP stream on mbed through both: UDP & TCP) even though these 3 tests

mbed-os-tests-netsocket-socket_sigio
mbed-os-tests-netsocket-tcp_hello_world
mbed-os-tests-netsocket-udp_dtls_handshake

always fails, and I don't know why. Even in OS 5.4.7 TCP hello world has never passed.
The strange thing is even in RZ_A1H UDP DTLS handshake also does not pass, but sigio & TCP hello world pass.

Perhaps this is an Internet provider related issue, I don't know.
In 5.4.7 TCP hello world failed because of timeout (the response of the request arrived in two pieces and only the first was checked and therefore - incomplete response)
For the situation here I have no idea.

0xc0170 · 2018-03-08T14:23:38Z

@TomoYamanaka Are you aware of these issues, are they reproducible ? we shall take them to a separate issue.

This PR does not touch networking code. Shall ethernet be disabled until it's fixed?

TomoYamanaka · 2018-03-09T03:01:36Z

@0xc0170
I have never faced the above NET test. Whether Mbed OS 5.4 or Mbed OS 5.7, GR-PEACH and GR-LYCHEE passed the test.
It may be a problem with @mbedNoobNinja 's Internet environment.

Addressed via new commit

0xc0170 · 2018-03-09T09:57:35Z

/morph build

mbed-ci · 2018-03-09T10:42:56Z

Build : FAILURE

Build number : 1397
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6245/

0xc0170 · 2018-03-09T10:48:23Z

@mbedNoobNinja Please review the ARMCC build problem

mbedNoobNinja · 2018-03-09T13:11:30Z

Hm strange. With mbed CLI it is compiled successfully (blinky example).
When mbed_config.h is created and where is located from test environment point of view ?
Is it creates temporary linker script (.link_script.sct) ?
If Yes -> then the beginning of this file is it starts with #! armcc -E --cpu=Cortex-A9-I mbed-os\targets\TARGET_RENESAS\TARGET_RZ_A1XX\TARGET_VK_RZ_A1H\device\TOOLCHAIN_ARM_STD
I mean the path where mbed_config.h is located, should be included in the .link_script file as well.
With mbed CLI apparently there is no problem because mbed_config.h & .link_script.sct are in the same folder and there is no need to be explicitly included.

0xc0170 · 2018-03-12T12:56:49Z

I can not reproduce the problem. I fetched your branch locally, build the sermaphore test without any error (I am using locally armcc 5.06 update 5 at the moment)

@studavekar Can you reproduce the build failure here?

/morph build

mbed-ci · 2018-03-12T13:28:30Z

Build : FAILURE

Build number : 1417
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6245/

0xc0170 · 2018-03-12T13:41:52Z

Locally mbed test --compile -m VK_RZ_A1H -t ARM -DMBED_HEAP_STATS_ENABLED=1 -DMBED_STACK_STATS_ENABLED=1 -DMBED_TRAP_ERRORS_ENABLED=1 --clean - no failure 😕

Mbed-os 5.4.7 was the last unofficial working support for this target. Since Mbed-os 5.6.0, the support is now official and VK_RZ_A1H is now "codebase aligned" with GR_PEACH (RZ_A1H) & GR_LYCHEE (RZ_A1LU) !

mbedNoobNinja · 2018-03-20T09:58:06Z

Found the problem --preinclude does not act on h files, only on c Now it should compile. Hit a build 👍 when it's convenient.

0xc0170 · 2018-03-20T10:00:03Z

Found the problem --preinclude does not act on h files, only on c Now it should compile. Hit a build 👍 when it's convenient.

🙌

/morph build

mbed-ci · 2018-03-20T11:05:15Z

Build : SUCCESS

Build number : 1486
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6245/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-03-20T14:14:27Z

Exporter Build : SUCCESS

Build number : 1131
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6245/

mbed-ci · 2018-03-20T16:44:09Z

Test : SUCCESS

Build number : 1273
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6245/1273

studavekar · 2018-03-20T18:53:25Z

/morph mbed2-build

cmonr

All prior comments were addressed, and looks like the only change outside of TARGET_RENESAS was targets.json.

👍

mbedNoobNinja mentioned this pull request Mar 1, 2018

VK RZ A1H: needs an update from RZ A1H (cmsis, rtos related) #5777

Closed

cmonr requested review from bulislaw and hanno-becker March 1, 2018 21:36

cmonr added the needs: review label Mar 1, 2018

bulislaw previously requested changes Mar 2, 2018

View reviewed changes

mbedNoobNinja force-pushed the Sync_PR branch from 26318fc to a0af134 Compare March 2, 2018 15:48

0xc0170 added needs: work and removed needs: review labels Mar 5, 2018

cmonr added the scope: new-target label Mar 5, 2018

cmonr added needs: review and removed needs: work labels Mar 5, 2018

0xc0170 removed the request for review from hanno-becker March 7, 2018 18:22

mbedNoobNinja force-pushed the Sync_PR branch from a0af134 to 1226d06 Compare March 8, 2018 09:22

0xc0170 previously approved these changes Mar 8, 2018

View reviewed changes

0xc0170 added needs: work and removed needs: review labels Mar 9, 2018

Enabled os5 support for VK_RZ_A1H & synced with rest Renesas targets !

cf8fd20

Mbed-os 5.4.7 was the last unofficial working support for this target. Since Mbed-os 5.6.0, the support is now official and VK_RZ_A1H is now "codebase aligned" with GR_PEACH (RZ_A1H) & GR_LYCHEE (RZ_A1LU) !

mbedNoobNinja dismissed 0xc0170’s stale review via cf8fd20 March 20, 2018 09:50

mbedNoobNinja force-pushed the Sync_PR branch from 1226d06 to cf8fd20 Compare March 20, 2018 09:50

cmonr added ready for merge and removed needs: work labels Mar 20, 2018

cmonr approved these changes Mar 20, 2018

View reviewed changes

cmonr added the release-version: 5.8.1 label Mar 20, 2018

cmonr merged commit 2c7f909 into ARMmbed:master Mar 20, 2018

cmonr removed the ready for merge label Mar 20, 2018

mbedNoobNinja deleted the Sync_PR branch March 21, 2018 10:30

Update for VK_RZ_A1H #6245

Update for VK_RZ_A1H #6245

Uh oh!

Conversation

mbedNoobNinja commented Mar 1, 2018

Description

Pull request type

Uh oh!

cmonr commented Mar 1, 2018

Uh oh!

cmonr commented Mar 1, 2018

Uh oh!

mbedNoobNinja commented Mar 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bulislaw left a comment

Choose a reason for hiding this comment

Uh oh!

bulislaw Mar 2, 2018

Choose a reason for hiding this comment

Uh oh!

mbedNoobNinja Mar 2, 2018

Choose a reason for hiding this comment

Uh oh!

cmonr commented Mar 5, 2018

Uh oh!

cmonr commented Mar 5, 2018

Uh oh!

TomoYamanaka commented Mar 7, 2018

Uh oh!

0xc0170 commented Mar 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbedNoobNinja commented Mar 8, 2018

Uh oh!

0xc0170 commented Mar 8, 2018

Uh oh!

0xc0170 commented Mar 8, 2018

Uh oh!

mbedNoobNinja commented Mar 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Mar 8, 2018

Uh oh!

TomoYamanaka commented Mar 9, 2018

Uh oh!

0xc0170 commented Mar 9, 2018

Uh oh!

mbed-ci commented Mar 9, 2018

Build : FAILURE

Uh oh!

0xc0170 commented Mar 9, 2018

Uh oh!

mbedNoobNinja commented Mar 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Mar 12, 2018

Uh oh!

mbed-ci commented Mar 12, 2018

Build : FAILURE

Uh oh!

0xc0170 commented Mar 12, 2018

Uh oh!

mbedNoobNinja commented Mar 20, 2018

Uh oh!

0xc0170 commented Mar 20, 2018

Uh oh!

mbed-ci commented Mar 20, 2018

Build : SUCCESS

Triggering tests

Uh oh!

mbed-ci commented Mar 20, 2018

Exporter Build : SUCCESS

Uh oh!

mbed-ci commented Mar 20, 2018

Test : SUCCESS

Uh oh!

studavekar commented Mar 20, 2018

Uh oh!

cmonr left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

mbedNoobNinja commented Mar 2, 2018 •

edited

Loading

0xc0170 commented Mar 7, 2018 •

edited

Loading

mbedNoobNinja commented Mar 8, 2018 •

edited

Loading

mbedNoobNinja commented Mar 9, 2018 •

edited

Loading

cmonr left a comment •

edited

Loading