Skip to content

Update HID classes #6447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 7, 2018
Merged

Update HID classes #6447

merged 7 commits into from
May 7, 2018

Conversation

c1728p9
Copy link
Contributor

@c1728p9 c1728p9 commented Mar 24, 2018

Update and the USB classes USBHID and USBKeyboard from the unsupported folder.

@c1728p9
Copy link
Contributor Author

c1728p9 commented Mar 24, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 24, 2018

Build : SUCCESS

Build number : 1558
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6447/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 24, 2018

Test : FAILURE

Build number : 1336
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6447/1336

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 24, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Mar 24, 2018

Test : FAILURE

Build number : 1338
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6447/1338

@mbed-ci
Copy link

mbed-ci commented Mar 24, 2018

Exporter Build : FAILURE

Build number : 1199
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6447/

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 24, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Mar 24, 2018

Test : FAILURE

Build number : 1339
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6447/1339

@c1728p9
Copy link
Contributor Author

c1728p9 commented Mar 24, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 25, 2018

Build : SUCCESS

Build number : 1565
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6447/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 25, 2018

Exporter Build : FAILURE

Build number : 1203
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6447/

@mbed-ci
Copy link

mbed-ci commented Mar 25, 2018

Test : SUCCESS

Build number : 1342
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6447/1342

@c1728p9
Copy link
Contributor Author

c1728p9 commented Mar 26, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Mar 26, 2018

Exporter Build : FAILURE

Build number : 1205
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6447/

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 26, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Mar 26, 2018

Exporter Build : FAILURE

Build number : 1210
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6447/

@cmonr
Copy link
Contributor

cmonr commented Mar 26, 2018

@studavekar @theotherjimmy Would y'all mind taking a look at these export failures? On both runs, the same devices have failed.

A snippet of one of the errors:
startup_nrf52832.S: error: A3907U: Via file '.\build\startup_nrf52832._ia' command too long for buffer.

It's possible that we need to increase the terminal emulator's command buffer in Jenkins.

@c1728p9 c1728p9 force-pushed the feature-hal-spec-usb-device branch from 088cafe to 9a4eefc Compare March 27, 2018 12:32
@c1728p9
Copy link
Contributor Author

c1728p9 commented Mar 27, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 27, 2018

Build : SUCCESS

Build number : 1584
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6447/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 27, 2018

Test : SUCCESS

Build number : 1374
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6447/1374

@mbed-ci
Copy link

mbed-ci commented Mar 27, 2018

Exporter Build : FAILURE

Build number : 1223
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6447/

@cmonr
Copy link
Contributor

cmonr commented Mar 27, 2018

Looks like build commands for uVision are starting to get too long.

Snippet error:
irq_cm4f.S: error: A3907U: Via file '.\build\irq_cm4f._ia' command too long for buffer.

@cmonr
Copy link
Contributor

cmonr commented Mar 27, 2018

@c1728p9 Fix is incoming in #6487

Will need you to rebase or cherry pick once its in, and we can restart CI after.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 11, 2018

Fix 6487 integrated, can you rebase this PR and restart CI?

@c1728p9 c1728p9 force-pushed the usb_updates branch 4 times, most recently from 10d9cf7 to 0f721cd Compare May 3, 2018 02:34
@c1728p9 c1728p9 changed the title Update USBHID and USBKeyboard Update HID classes May 3, 2018
@c1728p9
Copy link
Contributor Author

c1728p9 commented May 3, 2018

/morph build

@c1728p9
Copy link
Contributor Author

c1728p9 commented May 3, 2018

@maciejbocianski could you take a look at this?

@mbed-ci
Copy link

mbed-ci commented May 3, 2018

Build : FAILURE

Build number : 1893
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6447/

@0xc0170
Copy link
Contributor

0xc0170 commented May 3, 2018

Please review the build failures (related to the changeset)

@maciejbocianski
Copy link
Contributor

@c1728p9 this commit will fix compilation maciejbocianski@f0bc469
add it to your PR

@c1728p9 c1728p9 force-pushed the feature-hal-spec-usb-device branch from 9882af1 to 4e1bac1 Compare May 3, 2018 15:34
c1728p9 and others added 7 commits May 3, 2018 10:35
@c1728p9
Remove blocking option from USB connect
a775922 
Remove the option to block in USBDevice::connect since this
should be handled at a higher level. Also call init to ensure that
the USBDevice has been initalized.
@c1728p9
Remove extra USBDevice constructor
110bf3b 
Remove the second USBDevice constructor since it does not provide
any new functionality.
@c1728p9
Add USBDevice destructor
84c2216 
Add a destructor to USBDevice to ensure that resources have been
properly released. Additionally add an assert in the destructor that
deinit has already been called. If it has not been called then
interrupts can still occur which may cause a crash.
@c1728p9
Cleanup USBSerial
2d5eafc 
Make the following changes
-Make blocking the first parameter in the constructor
-Add destructor and proper cleanup
-Add ready and wait_ready functions
@c1728p9
Fix typo in USBTester.h
3e4bf14 
Fix the spelling of product_release.
@c1728p9
Update the USBHID classes
1c38b21 
Update the USB classes USBHID, USBKeyboard, USBMouse and
USBMouseKeyboard from the unsupported folder.
@maciejbocianski @c1728p9
Update usb test to connect and block itself
4011505 
Update the basic usb test so it does blocking itself since blocking
connect was removed from USBDevice.
@c1728p9
Copy link
Contributor Author

c1728p9 commented May 3, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 3, 2018

Build : SUCCESS

Build number : 1919
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6447/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 4, 2018

Exporter Build : SUCCESS

Build number : 1564
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6447/

@mbed-ci
Copy link

mbed-ci commented May 4, 2018

Test : SUCCESS

Build number : 1735
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6447/1735

@0xc0170
Copy link
Contributor

0xc0170 commented May 7, 2018

One question, _putc is having _ prefix as _getc but its public?

@0xc0170 0xc0170 merged commit 6e499d6 into ARMmbed:feature-hal-spec-usb-device May 7, 2018
@0xc0170 0xc0170 removed the needs: CI label May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@c1728p9 @mbed-ci @0xc0170 @cmonr @theotherjimmy @maciejbocianski