Skip to content

Minimize the size of uvision include paths #6487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2018
Merged

Minimize the size of uvision include paths #6487

merged 2 commits into from
Mar 28, 2018

Conversation

theotherjimmy
Copy link
Contributor

Description

The size of uvision include paths can break the exporter with very large
projects. Some nordic devices are very large projects by themselves.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

cmonr
cmonr approved these changes Mar 27, 2018
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on local machine.

Build fails with #6447. Updating with this PR branch completes build.

@cmonr
Copy link
Contributor

cmonr commented Mar 27, 2018

/morph build

@cmonr cmonr mentioned this pull request Mar 27, 2018
Merged
@cmonr
Copy link
Contributor

cmonr commented Mar 27, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 27, 2018

Build : SUCCESS

Build number : 1599
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6487/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 27, 2018

Exporter Build : SUCCESS

Build number : 1231
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6487/

@mbed-ci
Copy link

mbed-ci commented Mar 28, 2018

Test : FAILURE

Build number : 1382
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6487/1382

@cmonr
Copy link
Contributor

cmonr commented Mar 28, 2018 •
edited
Loading

ಠ_ಠ

/morph test

@mbed-ci
Copy link

mbed-ci commented Mar 28, 2018

Test : SUCCESS

Build number : 1383
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6487/1383

0xc0170
0xc0170 approved these changes Mar 28, 2018
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve to unblock PR.

But still we might face this issue in the future . How big buffer is in uvision? Can it be fixed there ? What other options we have once we have this problem again ?

@0xc0170 0xc0170 merged commit 25a2d15 into ARMmbed:master Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.8.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theotherjimmy @cmonr @mbed-ci @0xc0170