-
Notifications
You must be signed in to change notification settings - Fork 3k
tests-mbed_hal-common_tickers / lp ticker speed test : remove set_interrupt call loop #6459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests-mbed_hal-common_tickers / lp ticker speed test : remove set_interrupt call loop #6459
Conversation
yes, DEVICE_LOWPOWERTIMER #if has not been updated in TESTS\mbed_drivers\timeout\timeout_tests.h |
afd66ab
to
6daa7fc
Compare
b6ccb77
to
c409825
Compare
Rebase done |
/morph build |
Still waiting for the review.
Based on the description above, I would expect the target implementation handles the case (wait for completion of the command) ? |
Build : SUCCESSBuild number : 1650 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1282 |
Test : SUCCESSBuild number : 1439 |
@0xc0170 Jerome (@jeromecoutant) is the one to remove lines instead of commenting out. |
With #6536 this test should pass even with the loop so this change may not be needed. |
Thanks @c1728p9 for the confirmation, will wait for that one to land |
Description
There is some issue when lp_ticker_set_interrupt function is called into a loop with no delay between.
NB: extract of STM32 reference manual (in chip supporting LPTIM feature):
After a write to the LPTIM_ARR register or the LPTIM_CMP register, a new write operation
to the same register can only be performed when the previous write operation is completed.
Any successive write before respectively the ARROK flag or the CMPOK flag be set, will
lead to unpredictable results.
After dicussion, we decide to remove the loop and check requirement time during an unique call
@LMESTM @c1728p9 @sg- @bulislaw
Additional question:
is there really a sense to define the same requirement for ticker_set_interrupt time completion for usticket and lpticker ?
Pull request type
[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change