Skip to content

STM32 LPTICKER update for targets supporting LPTIMER #6474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 24, 2018
Merged

STM32 LPTICKER update for targets supporting LPTIMER #6474

merged 4 commits into from
Apr 24, 2018

Conversation

jeromecoutant
Copy link
Collaborator

Description

STM32 LPTICKER update for targets supporting ST LPTIM

Targets: STM32L0, STM32L4, STM32F7 and few STM32F4

@bulislaw @LMESTM @c1728p9 @screamerbg

Pull request type

[ ] Fix
[x] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

0xc0170
0xc0170 reviewed Mar 27, 2018
View reviewed changes
targets/TARGET_STM/lp_ticker.c Outdated

// Enable IRQs
core_util_critical_section_exit();
// core_util_critical_section_exit();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall this be removed completely? or why is it still here

0xc0170
0xc0170 reviewed Mar 27, 2018
View reviewed changes
targets/TARGET_STM/lp_ticker.c Outdated
@@ -142,18 +136,20 @@ void lp_ticker_init(void)
}

NVIC_SetVector(LPTIM1_IRQn, (uint32_t)LPTIM1_IRQHandler);
NVIC_EnableIRQ(LPTIM1_IRQn);
//NVIC_EnableIRQ(LPTIM1_IRQn);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dead code removal on some lines around here?

@jeromecoutant jeromecoutant force-pushed the PR_LPTICKER_NEWAPI_LPTIM branch from 87385b3 to 84db2b9 Compare March 27, 2018 12:31
@bulislaw bulislaw force-pushed the feature-hal-spec-ticker branch from afd66ab to 6daa7fc Compare March 27, 2018 14:06
@jeromecoutant jeromecoutant force-pushed the PR_LPTICKER_NEWAPI_LPTIM branch from 84db2b9 to 239f14b Compare March 27, 2018 14:44
@cmonr
Copy link
Contributor

cmonr commented Apr 3, 2018

@0xc0170 Which PR is this waiting on?

@jeromecoutant
Copy link
Collaborator Author

@0xc0170 Which PR is this waiting on?

I would say #6459

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 4, 2018

It is but there are few updates to tickers that come from @c1728p9 , and those should help.

@LMESTM LMESTM mentioned this pull request Apr 9, 2018
Closed
@jeromecoutant
Copy link
Collaborator Author

Status:

Here is my current branch:

Tests are OK :
| NUCLEO_F767ZI-GCC_ARM | NUCLEO_F767ZI | tests-mbed_drivers-lp_ticker | OK | 19.76 | default |
| NUCLEO_F767ZI-GCC_ARM | NUCLEO_F767ZI | tests-mbed_drivers-ticker | OK | 42.07 | default |
| NUCLEO_F767ZI-GCC_ARM | NUCLEO_F767ZI | tests-mbed_hal-common_tickers | OK | 19.09 | default |
| NUCLEO_F767ZI-GCC_ARM | NUCLEO_F767ZI | tests-mbed_hal-common_tickers_freq | OK | 35.5 | default |
| NUCLEO_F767ZI-GCC_ARM | NUCLEO_F767ZI | tests-mbed_hal-lp_ticker | OK | 14.92 | default |
| NUCLEO_F767ZI-GCC_ARM | NUCLEO_F767ZI | tests-mbed_hal-ticker | OK | 24.57 | default |
| NUCLEO_F767ZI-GCC_ARM | NUCLEO_F767ZI | tests-mbed_hal-us_ticker | OK | 13.21 | default |

Please, merge all these PR in the feature branch.

@jeromecoutant jeromecoutant force-pushed the PR_LPTICKER_NEWAPI_LPTIM branch from 239f14b to 0e0e6e5 Compare April 17, 2018 09:38
@bulislaw bulislaw force-pushed the feature-hal-spec-ticker branch from 155a9a0 to 61c0007 Compare April 19, 2018 10:33
@jeromecoutant jeromecoutant force-pushed the PR_LPTICKER_NEWAPI_LPTIM branch from 0e0e6e5 to a4b8979 Compare April 23, 2018 16:02
@jeromecoutant
Copy link
Collaborator Author

Hi @0xc0170
Every thing is green on my side now, could you start morph build and tests ?
Thx

@cmonr
Copy link
Contributor

cmonr commented Apr 23, 2018

We're working on finishing up the 5.8.3 patch release through first. Once that's in, we'll be working through other PRs to get them through CI.

@cmonr
Copy link
Contributor

cmonr commented Apr 23, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 23, 2018

Build : SUCCESS

Build number : 1825
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6474/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 24, 2018

Test : SUCCESS

Build number : 1631
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6474/1631

@mbed-ci
Copy link

mbed-ci commented Apr 24, 2018

Exporter Build : SUCCESS

Build number : 1469
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6474/

@cmonr cmonr merged commit 0acd761 into ARMmbed:feature-hal-spec-ticker Apr 24, 2018
@jeromecoutant jeromecoutant deleted the PR_LPTICKER_NEWAPI_LPTIM branch April 24, 2018 07:37
@jeromecoutant jeromecoutant mentioned this pull request Apr 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeromecoutant @cmonr @0xc0170 @mbed-ci @bulislaw