Skip to content

TEST update : tests-mbed_hal-common_tickers_freq #6573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jeromecoutant
Copy link
Collaborator

Description

For me, tests-mbed_hal-common_tickers_freq needs few update:

  • explicit use of u32 instead of unsigned int
  • the acceptable tolerance is 10%
  • the overflowCounter init should be moved just before begin_ticks

Thx

@mprse @c1728p9 @bulislaw

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@mprse
Copy link
Contributor

mprse commented Apr 9, 2018

The changes looks ok. Only the modification of the host test can not be performed in this way. The host test is used by other tests which expects 5% tolerance. So I think host test should be modified, so the tolerance can be configured or we need a copy of it adapted to the 10% tolerance.

@jeromecoutant
Copy link
Collaborator Author

As host part is not really need for my tests, I removed this part from this PR.

@jeromecoutant jeromecoutant changed the title Pr test common freq TEST update : tests-mbed_hal-common_tickers_freq Apr 9, 2018
@cmonr
Copy link
Contributor

cmonr commented Apr 9, 2018

/morph build

@cmonr
Copy link
Contributor

cmonr commented Apr 9, 2018

@jeromecoutant What's the reason for migrating from unsigned int to uint32_t?

@cmonr
Copy link
Contributor

cmonr commented Apr 9, 2018

Nvm, re-read the description.

@mbed-ci
Copy link

mbed-ci commented Apr 9, 2018

Build : SUCCESS

Build number : 1691
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6573/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 10, 2018

@mbed-ci
Copy link

mbed-ci commented Apr 10, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 10, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Apr 10, 2018

@0xc0170 0xc0170 merged commit 83b8970 into ARMmbed:feature-hal-spec-ticker Apr 10, 2018
@jeromecoutant jeromecoutant deleted the PR_TEST_COMMON_FREQ branch April 10, 2018 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants