Fix deep sleep implementation #6468

mmahadevan108 · 2018-03-27T08:01:03Z

Fixes the Deep sleep implementation for the MCUXpresso SoC's. This is based on testing using the latest sleep manager that invokes deepsleep mode in the idle loop

mmahadevan108 · 2018-03-27T08:01:20Z

cc @0xc0170 @maclobdell

bulislaw · 2018-03-27T10:42:38Z

Why are we changing so many Flash files?

mmahadevan108 · 2018-03-27T10:45:04Z

This commit is updating the SDK flash drivers on certain platforms to use the API's available in the new drivers that are required for deep sleep entry and exit.

0xc0170 · 2018-03-27T15:45:15Z

/morph build

mbed-ci · 2018-03-27T18:19:35Z

Build : FAILURE

Build number : 1593
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6468/

mmahadevan108 · 2018-03-27T20:14:26Z

Updated LPC546XX to address build issue seen.

cmonr · 2018-03-28T04:00:41Z

targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_LPC546XX/TARGET_FF_LPC546XX/device.h

-#define LPC_CLOCK_INTERNAL_IRC BOARD_BootClockFRO12M
-#define LPC_CLOCK_RUN          BOARD_BootClockFROHF48M
+#define LPC_CLOCK_INTERNAL_IRC BOARD_BootClockFRO12M()
+#define LPC_CLOCK_RUN          ((SYSCON->DEVICE_ID0 == 0xFFF54628) ? \


This feels very strange to do. What's the reason that a different clock sequence/function is required for a single part?

This is to identify a LPC54628 part in the LPC546XX family. LPC54628 which is capable of running at higher speeds.

cmonr · 2018-03-28T04:01:15Z

@bulislaw @0xc0170 Requesting a re-review.

0xc0170 · 2018-03-28T08:10:30Z

/morph build

mbed-ci · 2018-03-28T08:39:07Z

Build : SUCCESS

Build number : 1606
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6468/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-03-28T12:37:53Z

Exporter Build : FAILURE

Build number : 1239
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6468/

mbed-ci · 2018-03-28T16:07:14Z

Test : FAILURE

Build number : 1392
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6468/1392

studavekar · 2018-03-28T16:09:19Z

Test : FAILURE
Build number : 1392
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6468/1392

This failure is because of USB devices going offline. as the pipeline is deep, not re-triggering.

0xc0170 · 2018-04-03T07:48:30Z

/morph test
/morph export-build

mbed-ci · 2018-04-03T11:08:44Z

Test : FAILURE

Build number : 1427
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6468/1427

mbed-ci · 2018-04-03T11:14:48Z

Exporter Build : SUCCESS

Build number : 1270
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6468/

Add a check to return to 220MHz on LPC54628 Signed-off-by: Mahesh Mahadevan <[email protected]>

mmahadevan108 · 2018-04-10T13:18:00Z

I have rebased and updated this PR.

cmonr · 2018-04-10T22:35:21Z

Going to restart build since rebase caused status to be lost. Still on hold pending pr-head resolution.

/morph build

mbed-ci · 2018-04-10T23:31:15Z

Build : SUCCESS

Build number : 1716
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6468/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-04-11T03:28:06Z

Exporter Build : SUCCESS

Build number : 1350
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6468/

0xc0170 · 2018-04-11T09:11:34Z

jenkins CI still failing. We are investigating other options, github has not yet fixed the issue 😢

mbed-ci · 2018-04-11T20:17:48Z

Test : FAILURE

Build number : 1513
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6468/1513

cmonr · 2018-04-11T20:32:45Z

...huh. Unless I'm mistaken, it looks like this singular test finished too quickly.

[1523474064.61][HTST][INF] DUT greentea-client version: 1.3.0 [1523474064.61][CONN][INF] found KV pair in stream: {{__timeout;30}}, queued... [1523474064.61][HTST][INF] setting timeout to: 30 sec [1523474064.61][CONN][INF] found KV pair in stream: {{__host_test_name;echo}}, queued... [1523474064.61][CONN][INF] found KV pair in stream: {{__testcase_count;1}}, queued... [1523474064.61][HTST][INF] host test class: ''
[1523474064.61][HTST][INF] host test setup() call...
[1523474064.61][HTST][INF] CALLBACKs updated
[1523474064.61][HTST][INF] host test detected: echo
[1523474064.62][CONN][RXD] >>> Running 1 test cases...
[1523474064.62][CONN][RXD] 
[1523474064.62][CONN][INF] found KV pair in stream: {{__testcase_name;Echo server: x16}}, queued...
[1523474064.71][CONN][RXD] >>> Running case #1: 'Echo server: x16'...
[1523474064.71][CONN][INF] found KV pair in stream: {{__testcase_start;Echo server: x16}}, queued...
[1523474064.71][CONN][INF] found KV pair in stream: {{echo_count;16}}, queued...
[1523474064.71][GLRM][TXD] {{echo_count;16}}
[1523474064.71][GLRM][TXD] {{echo;b7839f98-f198-4889-a1c6-6a8d9e6d170e}}
[1523474094.74][HTST][INF] test suite run finished after 30.13 sec...
[1523474094.74][CONN][INF] received special event '__host_test_finished' value='True', finishing
[1523474094.74][urllib3.connectionpool]Starting new HTTP connection (1): iron-gatekeeper
[1523474094.79][urllib3.connectionpool]http://iron-gatekeeper:8000 "PUT /resource/0602000041114e45001a3003b60f0012a6e1000097969900/disconnect HTTP/1.1" 200 2
[1523474094.79][urllib3.connectionpool]Starting new HTTP connection (1): iron-gatekeeper
[1523474097.97][urllib3.connectionpool]http://iron-gatekeeper:8000 "PUT /resource/0602000041114e45001a3003b60f0012a6e1000097969900/release HTTP/1.1" 200 66
[1523474097.97][HTST][INF] CONN exited with code: 0
[1523474097.97][HTST][INF] No events in queue
[1523474097.97][HTST][INF] stopped consuming events
[1523474097.97][HTST][INF] host test result(): False
[1523474097.97][HTST][WRN] missing __exit event from DUT
[1523474097.97][HTST][WRN] missing __exit_event_queue event from host test
[1523474097.97][HTST][INF] calling blocking teardown()
[1523474097.97][HTST][INF] teardown() finished
[1523474097.97][HTST][INF] {{result;failure}}

0xc0170 · 2018-04-12T12:29:15Z

/morph test

mbed-ci · 2018-04-12T22:25:38Z

Test : SUCCESS

Build number : 1530
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6468/1530

mmahadevan108 · 2018-04-16T20:30:00Z

Can you let me know the reason failure.

cmonr · 2018-04-16T21:48:59Z

@mmahadevan108 The morph test failure and cause for restart appears to be due to a test that is completing too fast. We're monitoring that particular test for right now.

As for the pr-head failure, about a week ago, we discovered an issue with how that particular job pulls references from GitHub and GitHub confirmed that they were getting other complaints as well. Once this is solved, we'll rerun all pr-head jobs that are currently blocking ~10 PRs.

PR ARMmbed#6468 updated flash driver, but not for KL27Z target (another CPU type). It is missing and leads to build failure. This fixes it.

adbridge · 2018-04-25T10:52:54Z

@mmahadevan108 For future reference could we please have more details in the PR body. It should really contain the following:

Description of the actual problem
Description of the fix
How this was tested
Any other dependencies related to the PR

Thanks :)

mmahadevan108 · 2018-04-25T12:15:40Z

Sure

0xc0170 added the needs: review label Mar 27, 2018

0xc0170 previously approved these changes Mar 27, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Mar 27, 2018

bulislaw previously approved these changes Mar 27, 2018

View reviewed changes

mmahadevan108 dismissed stale reviews from bulislaw and 0xc0170 via 1e40702 March 27, 2018 20:13

mmahadevan108 force-pushed the Fix_DeepSleep_Implementation branch from 41009c0 to 1e40702 Compare March 27, 2018 20:13

cmonr reviewed Mar 28, 2018

View reviewed changes

cmonr added needs: review and removed needs: CI labels Mar 28, 2018

0xc0170 previously approved these changes Mar 28, 2018

View reviewed changes

bulislaw previously approved these changes Mar 28, 2018

View reviewed changes

theotherjimmy added needs: CI and removed needs: review labels Mar 29, 2018

LPC546XX: Fix deepsleep implementation

9a1e749

Add a check to return to 220MHz on LPC54628 Signed-off-by: Mahesh Mahadevan <[email protected]>

mmahadevan108 dismissed 0xc0170’s stale review via 9a1e749 April 10, 2018 13:17

mmahadevan108 force-pushed the Fix_DeepSleep_Implementation branch from 13e6d2a to 9a1e749 Compare April 10, 2018 13:17

0xc0170 approved these changes Apr 17, 2018

View reviewed changes

0xc0170 added ready for merge and removed needs: CI labels Apr 17, 2018

cmonr added the release-version: 5.8.3 label Apr 17, 2018

cmonr merged commit 7489401 into ARMmbed:master Apr 17, 2018

cmonr removed the ready for merge label Apr 17, 2018

mmahadevan108 deleted the Fix_DeepSleep_Implementation branch April 19, 2018 14:56

0xc0170 mentioned this pull request Apr 23, 2018

Release candidate for mbed-os-5.8.3 #6697

Merged

0xc0170 added a commit to 0xc0170/mbed-os that referenced this pull request Apr 23, 2018

KL27Z: Flash protection macro addition

43d0f17

PR ARMmbed#6468 updated flash driver, but not for KL27Z target (another CPU type). It is missing and leads to build failure. This fixes it.

0xc0170 mentioned this pull request Apr 23, 2018

KL27Z: Flash protection macro addition #6703

Merged

Fix deep sleep implementation #6468

Fix deep sleep implementation #6468

Uh oh!

Conversation

mmahadevan108 commented Mar 27, 2018

Uh oh!

mmahadevan108 commented Mar 27, 2018

Uh oh!

bulislaw commented Mar 27, 2018

Uh oh!

mmahadevan108 commented Mar 27, 2018

Uh oh!

0xc0170 commented Mar 27, 2018

Uh oh!

mbed-ci commented Mar 27, 2018

Uh oh!

mmahadevan108 commented Mar 27, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmonr commented Mar 28, 2018

Uh oh!

0xc0170 commented Mar 28, 2018

Uh oh!

mbed-ci commented Mar 28, 2018

Triggering tests

Uh oh!

mbed-ci commented Mar 28, 2018

Uh oh!

mbed-ci commented Mar 28, 2018

Uh oh!

studavekar commented Mar 28, 2018

Uh oh!

0xc0170 commented Apr 3, 2018

Uh oh!

mbed-ci commented Apr 3, 2018

Uh oh!

mbed-ci commented Apr 3, 2018

Uh oh!

mmahadevan108 commented Apr 10, 2018

Uh oh!

cmonr commented Apr 10, 2018

Uh oh!

mbed-ci commented Apr 10, 2018

Triggering tests

Uh oh!

mbed-ci commented Apr 11, 2018

Uh oh!

0xc0170 commented Apr 11, 2018

Uh oh!

mbed-ci commented Apr 11, 2018

Uh oh!

cmonr commented Apr 11, 2018

Uh oh!

0xc0170 commented Apr 12, 2018

Uh oh!

mbed-ci commented Apr 12, 2018

Uh oh!

mmahadevan108 commented Apr 16, 2018

Uh oh!

cmonr commented Apr 16, 2018

Uh oh!

adbridge commented Apr 25, 2018

Uh oh!

mmahadevan108 commented Apr 25, 2018

Uh oh!

Uh oh!