Skip to content

KL27Z: Flash protection macro addition #6703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2018
Merged

KL27Z: Flash protection macro addition #6703

merged 1 commit into from
Apr 23, 2018
+2 −0

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Apr 23, 2018

Description

It should unblock #6697. Adding one more addition on top of #6468

Library: mbed.ar
Copy: mbed_board.o
Copy: mbed_sdk_boot.o
Copy: mbed_retarget.o

Completed in: (18.42)s

Build successes:
  * ARM::KL27Z

cc @mmahadevan108

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170
KL27Z: Flash protection macro addition
43d0f17 
PR ARMmbed#6468 updated flash driver, but not for KL27Z target (another CPU type).
It is missing and leads to build failure. This fixes it.
@adbridge adbridge self-requested a review April 23, 2018 10:01
adbridge
adbridge approved these changes Apr 23, 2018
View reviewed changes
Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adbridge
Copy link
Contributor

/morph build

@adbridge
Copy link
Contributor

/morph mbed2-release

Running this job so that we definitely test compile this board

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph mbed2-release

Running this job so that we definitely test compile this board

@mbed-ci
Copy link

mbed-ci commented Apr 23, 2018

Build : SUCCESS

Build number : 1822
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6703/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 23, 2018

Test : SUCCESS

Build number : 1629
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6703/1629

@mbed-ci
Copy link

mbed-ci commented Apr 23, 2018

Exporter Build : FAILURE

Build number : 1466
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6703/

@adbridge
Copy link
Contributor

Exporters failed for Nucleo_f410rb
https://mbed-os.mbedcloudtesting.com/job/exporter-build-matrix/1466/
Thinks the device is offline ?

@0xc0170
Copy link
Contributor Author

0xc0170 commented Apr 23, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Apr 23, 2018

Exporter Build : SUCCESS

Build number : 1467
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6703/

@cmonr cmonr merged commit b033a6e into ARMmbed:master Apr 23, 2018
@cmonr cmonr removed the needs: CI label Apr 23, 2018
cmonr pushed a commit that referenced this pull request Apr 23, 2018
@cmonr
Merge pull request #6703 from 0xc0170/fix_kl27z_flash
ed4df0b 
KL27Z: Flash protection macro addition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adbridge adbridge adbridge approved these changes

Assignees
No one assigned
Labels
release-version: 5.8.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0xc0170 @adbridge @mbed-bot @mbed-ci @cmonr