standard non-blocking NetworkInterface::connect #6496

jarvte · 2018-03-28T13:32:05Z

Description

• the standard non-blocking NetworkInterface::connect API introduced in mbed OS 5.8, including its events
• new cellular-specific status events

Internal ref to defect: IOTCELL-526

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

cmonr · 2018-03-29T06:28:24Z

As an FYI, this PR is being discussed in an internal email, determining if this PR needs to be considered a Feature.

AnttiKauppila · 2018-04-04T07:12:44Z

features/cellular/easy_cellular/CellularConnectionFSM.h

    uint16_t _retry_timeout_array[MAX_RETRY_ARRAY_SIZE];
    int _retry_array_length;
    events::EventQueue _at_queue;
+    char _st_string[20];
+    int _eventID;


0xc0170 · 2018-04-06T11:35:08Z

Can you please rebase to resolve conflicts?

jarvte · 2018-04-06T12:08:33Z

@0xc0170 , rebased master and fixed conflicts.

0xc0170

Just a question,

virtual void attach(mbed::Callback<void(nsapi_event_t, intptr_t)> status_cb); - a user is expected to have a state machine there in the callback? Would it be worse to attach actually a callback for a state ? so callback, state, similar to how Serial does (RX or TX).

0xc0170 · 2018-04-06T13:59:05Z

/morph build

mbed-ci · 2018-04-06T14:37:19Z

Build : FAILURE

Build number : 1676
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6496/

0xc0170 · 2018-04-06T14:42:59Z

@jarvte Please review failures, look related to the changeset

0xc0170 · 2018-04-09T07:31:22Z

Jenkins CI failure is know github issue, haven't yet received an update from github about it.

/morph build

mbed-ci · 2018-04-09T08:12:00Z

Build : SUCCESS

Build number : 1679
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6496/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

jarvte · 2018-04-09T08:17:12Z

@0xc0170
virtual void attach(mbed::Callback<void(nsapi_event_t, intptr_t)> status_cb); is declared in NetworkInterface, we are kind of proxy here, adding some callbacks. We have different callback for statemachine states: void set_callback(mbed::Callback<bool(int, int)> status_callback);

mbed-ci · 2018-04-09T11:06:13Z

Exporter Build : SUCCESS

Build number : 1312
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6496/

mbed-ci · 2018-04-09T12:15:12Z

Test : SUCCESS

Build number : 1474
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6496/1474

jarvte · 2018-04-10T09:15:17Z

@0xc0170 should I try to rebase latest from master to github issue potentially working?
Or is it proceeding?

0xc0170 · 2018-04-10T09:25:58Z

@0xc0170 should I try to rebase latest from master to github issue potentially working?
Or is it proceeding?

Lets try. I am testing jenkins CI and github but so far have not found a solution. We experienced that adding a commit sometimes help to refresh github PR

would be great to workaround this for now, the results should be visible quickly

cmonr · 2018-04-10T22:36:18Z

/morph build

mbed-ci · 2018-04-10T23:15:24Z

Build : SUCCESS

Build number : 1715
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6496/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-04-11T02:44:11Z

Exporter Build : SUCCESS

Build number : 1349
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6496/

…p to one minute and at timeout was 10s.

jarvte · 2018-04-11T06:41:30Z

@0xc0170 had to fix conflicts that appeared so let's try once again :)

0xc0170 · 2018-04-11T10:04:17Z

Will do soon, fixing one target issue in CI

0xc0170 · 2018-04-11T11:07:29Z

/morph build

mbed-ci · 2018-04-11T11:44:19Z

Build : SUCCESS

Build number : 1719
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6496/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-04-11T14:16:43Z

Exporter Build : SUCCESS

Build number : 1355
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6496/

mbed-ci · 2018-04-11T18:51:28Z

Test : FAILURE

Build number : 1512
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6496/1512

cmonr · 2018-04-11T19:16:48Z

Ignore the above (^^^) failure. This is from the first morph build command.

mbed-ci · 2018-04-12T05:31:15Z

Test : SUCCESS

Build number : 1519
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6496/1519

jarvte · 2018-04-12T06:19:35Z

@0xc0170 please approve and merge as our development continues over this change.

0xc0170 · 2018-04-12T06:59:09Z

As an FYI, this PR is being discussed in an internal email, determining if this PR needs to be considered a Feature.

Tagged as feature/refactor, 5.9

There's one change I would like @kjbracey-arm to check, nsapi_event_t additions in https://github.com/ARMmbed/mbed-os/pull/6496/files#diff-343c62b2c4de5626e8e2a8e0823ef74aR81

kjbracey · 2018-04-12T07:06:29Z

I'm fine with the nsapi_event_t change. Just one thing I want clarified - the PR description of what this is implementing. From reading the code, I believe it's

the standard non-blocking NetworkInterface::connect API introduced in mbed OS 5.8, including its events
new cellular-specific status events

0xc0170 · 2018-04-12T07:10:21Z

@jarvte CAn you please edit the title (it's used for release notes) so better be specific what this PR introduces (keep it within 50 characters)

jarvte · 2018-04-12T09:58:15Z

@0xc0170 comment updated, please merge.

Update Mbed OS to a pre 5.9 master branch for the PR 6494 (ARMmbed/mbed-os#6496). This is for testing with WISE-1570 NBIoT module

0xc0170 requested a review from AnttiKauppila April 3, 2018 13:09

AnttiKauppila reviewed Apr 4, 2018

View reviewed changes

AnttiKauppila approved these changes Apr 4, 2018

View reviewed changes

jarvte force-pushed the async_cellular branch from 20c7d19 to bb23b1c Compare April 6, 2018 12:07

jarvte closed this Apr 6, 2018

jarvte reopened this Apr 6, 2018

0xc0170 previously approved these changes Apr 6, 2018

View reviewed changes

0xc0170 added the needs: CI label Apr 6, 2018

0xc0170 added needs: work and removed needs: CI labels Apr 6, 2018

jarvte dismissed 0xc0170’s stale review via 3e8e4e4 April 9, 2018 07:22

0xc0170 added needs: CI and removed needs: work labels Apr 9, 2018

jarvte force-pushed the async_cellular branch from 3e8e4e4 to 6c43dae Compare April 10, 2018 09:51

Teppo Järvelin added 4 commits April 11, 2018 09:38

modified at timeout while doing attach and connect as it might take u…

12e1f07

…p to one minute and at timeout was 10s.

Cellular: review fixes and fixed unit tests.

f7f21dc

Cellular: Fixed rebase error.

b3226ac

Cellular: Fixing to skip greentea test if sim pin is not configured.

9c185d9

jarvte force-pushed the async_cellular branch from 19cb2ca to 9c185d9 Compare April 11, 2018 06:40

0xc0170 approved these changes Apr 12, 2018

View reviewed changes

0xc0170 added ready for merge release-version: 5.9.0-rc1 and removed needs: CI labels Apr 12, 2018

jarvte changed the title ~~Async cellular~~ standard non-blocking NetworkInterface::connect Apr 12, 2018

kjbracey approved these changes Apr 12, 2018

View reviewed changes

0xc0170 merged commit a463b07 into ARMmbed:master Apr 12, 2018

0xc0170 removed the ready for merge label Apr 12, 2018

jarvte deleted the async_cellular branch April 12, 2018 10:03

chuanga added a commit to chuanga/wise-1570-mbed-os-example-cellular that referenced this pull request Apr 19, 2018

Update mbed-os.lib

2461196

Update Mbed OS to a pre 5.9 master branch for the PR 6494 (ARMmbed/mbed-os#6496). This is for testing with WISE-1570 NBIoT module

This was referenced Apr 20, 2018

Cellular: Separated context activation in CellularConnectionFSM. #6626

Merged

cellular: Error messages #6632

Merged

standard non-blocking NetworkInterface::connect #6496

standard non-blocking NetworkInterface::connect #6496

Uh oh!

Conversation

jarvte commented Mar 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Uh oh!

cmonr commented Mar 29, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Apr 6, 2018

Uh oh!

jarvte commented Apr 6, 2018

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Apr 6, 2018

Uh oh!

mbed-ci commented Apr 6, 2018

Uh oh!

0xc0170 commented Apr 6, 2018

Uh oh!

0xc0170 commented Apr 9, 2018

Uh oh!

mbed-ci commented Apr 9, 2018

Triggering tests

Uh oh!

jarvte commented Apr 9, 2018

Uh oh!

mbed-ci commented Apr 9, 2018

Uh oh!

mbed-ci commented Apr 9, 2018

Uh oh!

jarvte commented Apr 10, 2018

Uh oh!

0xc0170 commented Apr 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmonr commented Apr 10, 2018

Uh oh!

mbed-ci commented Apr 10, 2018

Triggering tests

Uh oh!

mbed-ci commented Apr 11, 2018

Uh oh!

jarvte commented Apr 11, 2018

Uh oh!

0xc0170 commented Apr 11, 2018

Uh oh!

0xc0170 commented Apr 11, 2018

Uh oh!

mbed-ci commented Apr 11, 2018

Triggering tests

Uh oh!

mbed-ci commented Apr 11, 2018

Uh oh!

mbed-ci commented Apr 11, 2018

Uh oh!

cmonr commented Apr 11, 2018

Uh oh!

mbed-ci commented Apr 12, 2018

Uh oh!

jarvte commented Apr 12, 2018

Uh oh!

0xc0170 commented Apr 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kjbracey commented Apr 12, 2018

Uh oh!

0xc0170 commented Apr 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jarvte commented Apr 12, 2018

Uh oh!

jarvte commented Mar 28, 2018 •

edited

Loading

0xc0170 commented Apr 10, 2018 •

edited

Loading

0xc0170 commented Apr 12, 2018 •

edited

Loading

0xc0170 commented Apr 12, 2018 •

edited

Loading